summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Mike Ma <yanmin@google.com> 2020-03-30 16:38:19 -0700
committer Mike Ma <yanmin@google.com> 2020-03-30 17:13:39 -0700
commit1b75683d4f0a6a74267564caf45ebe3be128f7b6 (patch)
tree61365ce9a488e270ee8fc21d03ee76d2405ac216
parent603713009eee83b60939ca0a709026b1f63cad97 (diff)
Remove registerSection API with optional Executor
This patch addresses an issue from API review: registerSection cannot have an optional Executor registerSection is an unreleased API in R, therefore can be hard removed. Fixes: 148867197 Test: Build Change-Id: Icdb8b97f7fa3f1880aa3039dbbe82f8331a45202
-rwxr-xr-xapi/system-current.txt1
-rw-r--r--api/test-current.txt1
-rw-r--r--core/java/android/os/IncidentManager.java20
3 files changed, 2 insertions, 20 deletions
diff --git a/api/system-current.txt b/api/system-current.txt
index c7536f852a53..fe72ff50f726 100755
--- a/api/system-current.txt
+++ b/api/system-current.txt
@@ -8269,7 +8269,6 @@ package android.os {
method @Nullable @RequiresPermission(allOf={android.Manifest.permission.DUMP, android.Manifest.permission.PACKAGE_USAGE_STATS}) public android.os.IncidentManager.IncidentReport getIncidentReport(android.net.Uri);
method @NonNull @RequiresPermission(allOf={android.Manifest.permission.DUMP, android.Manifest.permission.PACKAGE_USAGE_STATS}) public java.util.List<android.net.Uri> getIncidentReportList(String);
method @RequiresPermission(android.Manifest.permission.APPROVE_INCIDENT_REPORTS) public java.util.List<android.os.IncidentManager.PendingReport> getPendingReports();
- method public void registerSection(int, @NonNull String, @NonNull android.os.IncidentManager.DumpCallback);
method public void registerSection(int, @NonNull String, @NonNull java.util.concurrent.Executor, @NonNull android.os.IncidentManager.DumpCallback);
method @RequiresPermission(allOf={android.Manifest.permission.DUMP, android.Manifest.permission.PACKAGE_USAGE_STATS}) public void reportIncident(android.os.IncidentReportArgs);
method @RequiresPermission("android.permission.REQUEST_INCIDENT_REPORT_APPROVAL") public void requestAuthorization(int, String, int, android.os.IncidentManager.AuthListener);
diff --git a/api/test-current.txt b/api/test-current.txt
index f95f8e8198c5..4e150a8434d9 100644
--- a/api/test-current.txt
+++ b/api/test-current.txt
@@ -2409,7 +2409,6 @@ package android.os {
method @Nullable @RequiresPermission(allOf={android.Manifest.permission.DUMP, android.Manifest.permission.PACKAGE_USAGE_STATS}) public android.os.IncidentManager.IncidentReport getIncidentReport(android.net.Uri);
method @NonNull @RequiresPermission(allOf={android.Manifest.permission.DUMP, android.Manifest.permission.PACKAGE_USAGE_STATS}) public java.util.List<android.net.Uri> getIncidentReportList(String);
method @RequiresPermission(android.Manifest.permission.APPROVE_INCIDENT_REPORTS) public java.util.List<android.os.IncidentManager.PendingReport> getPendingReports();
- method public void registerSection(int, @NonNull String, @NonNull android.os.IncidentManager.DumpCallback);
method public void registerSection(int, @NonNull String, @NonNull java.util.concurrent.Executor, @NonNull android.os.IncidentManager.DumpCallback);
method @RequiresPermission(allOf={android.Manifest.permission.DUMP, android.Manifest.permission.PACKAGE_USAGE_STATS}) public void reportIncident(android.os.IncidentReportArgs);
method @RequiresPermission("android.permission.REQUEST_INCIDENT_REPORT_APPROVAL") public void requestAuthorization(int, String, int, android.os.IncidentManager.AuthListener);
diff --git a/core/java/android/os/IncidentManager.java b/core/java/android/os/IncidentManager.java
index 8dde117fd19a..565d31a26dbc 100644
--- a/core/java/android/os/IncidentManager.java
+++ b/core/java/android/os/IncidentManager.java
@@ -567,7 +567,8 @@ public class IncidentManager {
}
/**
- * Register a callback to dump an extended incident report section with the given id and name.
+ * Register a callback to dump an extended incident report section with the given id and name,
+ * running on the supplied executor.
*
* Calling <code>registerSection</code> with a duplicate id will override previous registration.
* However, the request must come from the same calling uid.
@@ -578,23 +579,6 @@ public class IncidentManager {
* Also see incident.proto for other rules about the ID.
* @param name the name to display in logs and/or stderr when taking an incident report
* containing this section, mainly for debugging purpose
- * @param callback the callback function to be invoked when an incident report with all sections
- * or sections matching the given id is being taken
- */
- public void registerSection(int id, @NonNull String name, @NonNull DumpCallback callback) {
- registerSection(id, name, mContext.getMainExecutor(), callback);
- }
-
- /**
- * Register a callback to dump an extended incident report section with the given id and name,
- * running on the supplied executor.
- *
- * @param id the ID of the extended section. It should be unique system-wide, and be
- * different from IDs of all existing section in
- * frameworks/base/core/proto/android/os/incident.proto.
- * Also see incident.proto for other rules about the ID.
- * @param name the name to display in logs and/or stderr when taking an incident report
- * containing this section, mainly for debugging purpose
* @param executor the executor used to run the callback
* @param callback the callback function to be invoked when an incident report with all sections
* or sections matching the given id is being taken