diff options
| author | 2024-06-17 20:23:49 +0000 | |
|---|---|---|
| committer | 2024-07-25 07:23:55 +0000 | |
| commit | 1a9747ec8e105e380ec924ac99135f3e36e16ea9 (patch) | |
| tree | bf4acf39a456171d64ef11c68c0c1056750f5f6a | |
| parent | cd6318bd0bdd79762095dc541d613b963b59d8b0 (diff) | |
Fix CDM UI regressions
This change addresses two regressions:
UI flashing after selecting a device of the same OEM for pairing,
and occasional failure to display the spinner in the multiple devices dialog.
Flag: EXEMPT bugfix
Test: cts
Bug: 327049496
Bug: 353187081
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:fed5619a564e9e6802340cca73d11159f710cd75)
Merged-In: Iccd74ad5d74be605cf2b88edefa5bc998dfb1461
Change-Id: Iccd74ad5d74be605cf2b88edefa5bc998dfb1461
2 files changed, 3 insertions, 1 deletions
diff --git a/packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionAssociationActivity.java b/packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionAssociationActivity.java index f98908cf2d56..864de87b918d 100644 --- a/packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionAssociationActivity.java +++ b/packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionAssociationActivity.java @@ -568,6 +568,8 @@ public class CompanionAssociationActivity extends FragmentActivity implements updateSingleDeviceUi(); + if (mRequest.isSkipPrompt()) return; + mSummary.setVisibility(View.VISIBLE); mButtonAllow.setVisibility(View.VISIBLE); mButtonNotAllow.setVisibility(View.VISIBLE); diff --git a/packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionDeviceDiscoveryService.java b/packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionDeviceDiscoveryService.java index e809433a1261..2a8ce87b7bf6 100644 --- a/packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionDeviceDiscoveryService.java +++ b/packages/CompanionDeviceManager/src/com/android/companiondevicemanager/CompanionDeviceDiscoveryService.java @@ -127,6 +127,7 @@ public class CompanionDeviceDiscoveryService extends Service { return false; } } + sScanResultsLiveData.setValue(Collections.emptyList()); requireNonNull(associationRequest); final Intent intent = new Intent(context, CompanionDeviceDiscoveryService.class); intent.setAction(ACTION_START_DISCOVERY); @@ -192,7 +193,6 @@ public class CompanionDeviceDiscoveryService extends Service { sDiscoveryStarted = true; } mStopAfterFirstMatch = request.isSingleDevice(); - sScanResultsLiveData.setValue(Collections.emptyList()); sStateLiveData.setValue(DiscoveryState.IN_PROGRESS); final List<DeviceFilter<?>> allFilters = request.getDeviceFilters(); |