diff options
| author | 2023-06-28 18:40:43 +0000 | |
|---|---|---|
| committer | 2023-06-28 18:40:43 +0000 | |
| commit | 1a16cbcfa00594907ff733c0ad3afbbc153b3918 (patch) | |
| tree | f85a30b9af7bcd6baec1d37cb63cebf9a0bd5044 | |
| parent | 4526916c42ec3e73bd0b7941edeee1afba264eb3 (diff) | |
| parent | 7547bbff49aa16d06fdf2dbed9c6593185970496 (diff) | |
Merge "Avoid fullscreen bounds check while exiting pip" into udc-dev am: 7f3ff219a2 am: 7547bbff49
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/23816915
Change-Id: Id8b1437495c4b5769e6048ea48080d1dad049507
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
| -rw-r--r-- | libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java index 24aaa9b75ebe..d6451d75a012 100644 --- a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java +++ b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java @@ -567,7 +567,16 @@ public class PipTransition extends PipTransitionController { mPipBoundsState.getDisplayBounds()); mFinishCallback = (wct, wctCB) -> { mPipOrganizer.onExitPipFinished(taskInfo); - if (!Transitions.SHELL_TRANSITIONS_ROTATION && toFullscreen) { + + // TODO(b/286346098): remove the OPEN app flicker completely + // not checking if we go to fullscreen helps avoid getting pip into an inconsistent + // state after the flicker occurs. This is a temp solution until flicker is removed. + if (!Transitions.SHELL_TRANSITIONS_ROTATION) { + // will help to debug the case when we are not exiting to fullscreen + if (!toFullscreen) { + ProtoLog.d(ShellProtoLogGroup.WM_SHELL_PICTURE_IN_PICTURE, + "%s: startExitAnimation() not exiting to fullscreen", TAG); + } wct = wct != null ? wct : new WindowContainerTransaction(); wct.setBounds(pipTaskToken, null); mPipOrganizer.applyWindowingModeChangeOnExit(wct, TRANSITION_DIRECTION_LEAVE_PIP); |