summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Harini Rajan <harinirajan@google.com> 2024-02-05 21:43:42 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2024-02-05 21:43:42 +0000
commit18cd311fca9c48cab403b81cd08edd5a47d70bab (patch)
tree7cbb73a9198965f985a73d9e44fb86bddc740496
parent30c4962d6f909d5691012ff0dc5f02e460969137 (diff)
parent2764541384bb37bb303f554085ee285594064579 (diff)
Merge "Modify components to fit go/wear-passkey-3p-app-sign-in" into main
-rw-r--r--packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/AccountRow.kt12
-rw-r--r--packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/SignInHeader.kt59
-rw-r--r--packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/passkey/SinglePasskeyScreen.kt7
-rw-r--r--packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/password/SinglePasswordScreen.kt2
4 files changed, 30 insertions, 50 deletions
diff --git a/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/AccountRow.kt b/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/AccountRow.kt
index c20ee0c22ad6..3ed0c9c505ba 100644
--- a/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/AccountRow.kt
+++ b/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/AccountRow.kt
@@ -30,20 +30,20 @@ import com.google.android.horologist.compose.tools.WearPreview
@Composable
fun AccountRow(
- name: String,
- email: String,
+ primaryText: String,
+ secondaryText: String,
modifier: Modifier = Modifier,
) {
Column(modifier = modifier, horizontalAlignment = Alignment.CenterHorizontally) {
Text(
- text = name,
+ text = primaryText,
color = Color(0xFFE6FF7B),
overflow = TextOverflow.Ellipsis,
maxLines = 1,
style = MaterialTheme.typography.title2
)
Text(
- text = email,
+ text = secondaryText,
modifier = Modifier.padding(top = 7.dp),
color = Color(0xFFCAC5BC),
overflow = TextOverflow.Ellipsis,
@@ -57,7 +57,7 @@ fun AccountRow(
@Composable
fun AccountRowPreview() {
AccountRow(
- name = "Elisa Beckett",
- email = "beckett_bakery@gmail.com",
+ primaryText = "Elisa Beckett",
+ secondaryText = "beckett_bakery@gmail.com",
)
}
diff --git a/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/SignInHeader.kt b/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/SignInHeader.kt
index 956c56b2c7b1..1ddf4af1d923 100644
--- a/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/SignInHeader.kt
+++ b/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/components/SignInHeader.kt
@@ -16,45 +16,24 @@
package com.android.credentialmanager.ui.components
-import androidx.annotation.DrawableRes
+import android.graphics.drawable.Drawable
import androidx.compose.foundation.layout.Column
-import androidx.compose.foundation.layout.ColumnScope
import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.size
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
-import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.graphics.asImageBitmap
import androidx.compose.ui.unit.dp
-import androidx.wear.compose.material.MaterialTheme
+import androidx.core.graphics.drawable.toBitmap
import androidx.wear.compose.material.Text
-import com.android.credentialmanager.R
-import com.google.android.horologist.annotations.ExperimentalHorologistApi
-import com.google.android.horologist.compose.material.Icon
-import com.google.android.horologist.compose.material.util.DECORATIVE_ELEMENT_CONTENT_DESCRIPTION
-import com.google.android.horologist.compose.tools.WearPreview
+import androidx.compose.material3.Icon
+import androidx.wear.compose.material.MaterialTheme as WearMaterialTheme
+import androidx.compose.ui.text.style.TextAlign
-@OptIn(ExperimentalHorologistApi::class)
@Composable
fun SignInHeader(
- @DrawableRes icon: Int,
- title: String,
- modifier: Modifier = Modifier,
-) {
- SignInHeader(
- iconContent = {
- Icon(
- id = icon,
- contentDescription = DECORATIVE_ELEMENT_CONTENT_DESCRIPTION
- )
- },
- title = title,
- modifier = modifier,
- )
-}
-
-@Composable
-fun SignInHeader(
- iconContent: @Composable ColumnScope.() -> Unit,
+ icon: Drawable?,
title: String,
modifier: Modifier = Modifier,
) {
@@ -62,22 +41,22 @@ fun SignInHeader(
modifier = modifier,
horizontalAlignment = Alignment.CenterHorizontally
) {
- iconContent()
+ if (icon != null) {
+ Icon(
+ bitmap = icon.toBitmap().asImageBitmap(),
+ modifier = Modifier.size(32.dp),
+ // Decorative purpose only.
+ contentDescription = null
+ )
+ }
+
Text(
text = title,
+ textAlign = TextAlign.Center,
modifier = Modifier
.padding(top = 6.dp)
.padding(horizontal = 10.dp),
- style = MaterialTheme.typography.title3
+ style = WearMaterialTheme.typography.title3
)
}
}
-
-@WearPreview
-@Composable
-fun SignInHeaderPreview() {
- SignInHeader(
- icon = R.drawable.passkey_icon,
- title = stringResource(R.string.use_passkey_title)
- )
-}
diff --git a/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/passkey/SinglePasskeyScreen.kt b/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/passkey/SinglePasskeyScreen.kt
index 9558bb0c3ff9..2878b0b8b016 100644
--- a/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/passkey/SinglePasskeyScreen.kt
+++ b/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/passkey/SinglePasskeyScreen.kt
@@ -30,6 +30,7 @@ import com.android.credentialmanager.ui.screens.single.SingleAccountScreen
import com.google.android.horologist.annotations.ExperimentalHorologistApi
import com.google.android.horologist.compose.layout.ScalingLazyColumnState
+@OptIn(ExperimentalHorologistApi::class)
@Composable
fun SinglePasskeyScreen(
name: String,
@@ -40,14 +41,14 @@ fun SinglePasskeyScreen(
SingleAccountScreen(
headerContent = {
SignInHeader(
- icon = R.drawable.passkey_icon,
+ icon = null,
title = stringResource(R.string.use_passkey_title),
)
},
accountContent = {
AccountRow(
- name = name,
- email = email,
+ primaryText = name,
+ secondaryText = email,
modifier = Modifier.padding(top = 10.dp),
)
},
diff --git a/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/password/SinglePasswordScreen.kt b/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/password/SinglePasswordScreen.kt
index 54636122397f..95ef7dbfef30 100644
--- a/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/password/SinglePasswordScreen.kt
+++ b/packages/CredentialManager/wear/src/com/android/credentialmanager/ui/screens/single/password/SinglePasswordScreen.kt
@@ -103,7 +103,7 @@ fun SinglePasswordScreen(
SingleAccountScreen(
headerContent = {
SignInHeader(
- icon = R.drawable.passkey_icon,
+ icon = null,
title = stringResource(R.string.use_password_title),
)
},