diff options
| author | 2023-11-06 16:23:34 +0000 | |
|---|---|---|
| committer | 2023-11-06 16:23:34 +0000 | |
| commit | 18587bca28b02a5ed04665c5763259c254be662a (patch) | |
| tree | d1be944b9eb39acaca8dd079048ae878988b0625 | |
| parent | 9bca36457d76539ddf5771df5da5adfb5d2c3917 (diff) | |
| parent | 9a835c801db5ec5f10487835e166b512670502d7 (diff) | |
Merge "Add Class for flag notification_async_hybrid_view_inflation" into main
| -rw-r--r-- | packages/SystemUI/aconfig/systemui.aconfig | 14 | ||||
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/statusbar/notification/row/shared/AsyncHybridViewInflation.kt | 47 |
2 files changed, 54 insertions, 7 deletions
diff --git a/packages/SystemUI/aconfig/systemui.aconfig b/packages/SystemUI/aconfig/systemui.aconfig index 069ba6cd02aa..8019b381e56b 100644 --- a/packages/SystemUI/aconfig/systemui.aconfig +++ b/packages/SystemUI/aconfig/systemui.aconfig @@ -15,6 +15,13 @@ flag { } flag { + name: "notification_async_hybrid_view_inflation" + namespace: "systemui" + description: "Inflates hybrid (single-line) notification views from the background thread." + bug: "217799515" +} + +flag { name: "notifications_footer_view_refactor" namespace: "systemui" description: "Enables the refactored version of the footer view in the notification shade " @@ -39,13 +46,6 @@ flag { } flag { - name: "notification_async_hybrid_view_inflation" - namespace: "systemui" - description: "Inflates the hybrid (single-line) notification views form the background thread." - bug: "217799515" -} - -flag { name: "scene_container" namespace: "systemui" description: "Enables the scene container framework go/flexiglass." diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/shared/AsyncHybridViewInflation.kt b/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/shared/AsyncHybridViewInflation.kt new file mode 100644 index 000000000000..24e7f05a9c1d --- /dev/null +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/shared/AsyncHybridViewInflation.kt @@ -0,0 +1,47 @@ +/* + * Copyright (C) 2023 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.systemui.statusbar.notification.row.shared + +import com.android.systemui.Flags +import com.android.systemui.flags.RefactorFlagUtils + +/** Helper for reading or using the async hybrid view inflation flag state. */ +@Suppress("NOTHING_TO_INLINE") +object AsyncHybridViewInflation { + const val FLAG_NAME = Flags.FLAG_NOTIFICATION_ASYNC_HYBRID_VIEW_INFLATION + + /** Is async hybrid (single-line) view inflation enabled */ + @JvmStatic + inline val isEnabled + get() = Flags.notificationAsyncHybridViewInflation() + + /** + * Called to ensure code is only run when the flag is enabled. This protects users from the + * unintended behaviors caused by accidentally running new logic, while also crashing on an eng + * build to ensure that the refactor author catches issues in testing. + */ + @JvmStatic + inline fun isUnexpectedlyInLegacyMode() = + RefactorFlagUtils.isUnexpectedlyInLegacyMode(isEnabled, FLAG_NAME) + + /** + * Called to ensure code is only run when the flag is disabled. This will throw an exception if + * the flag is enabled to ensure that the refactor author catches issues in testing. + */ + @JvmStatic + inline fun assertInLegacyMode() = RefactorFlagUtils.assertInLegacyMode(isEnabled, FLAG_NAME) +} |