summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author TreeHugger Robot <treehugger-gerrit@google.com> 2020-04-17 20:17:08 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2020-04-17 20:17:08 +0000
commit171cf884ffe4f4f4831d1ea080e8cc6fa8b65085 (patch)
tree0f9d35d05693241fe38d7ccd1f51403a7faaea0f
parentc6ce2f04fcc4314e05f1750fbf2f98fdaee2bd66 (diff)
parent94d9dc7d3aaeacf88b99f6b608a2172a45830fcf (diff)
Merge "System NLSs have up-to-date targetSdks" into rvc-dev
-rw-r--r--services/core/java/com/android/server/notification/ConditionProviders.java3
-rw-r--r--services/core/java/com/android/server/notification/ManagedServices.java11
-rwxr-xr-xservices/core/java/com/android/server/notification/NotificationManagerService.java4
-rw-r--r--services/tests/uiservicestests/src/com/android/server/notification/ManagedServicesTest.java2
4 files changed, 10 insertions, 10 deletions
diff --git a/services/core/java/com/android/server/notification/ConditionProviders.java b/services/core/java/com/android/server/notification/ConditionProviders.java
index e98326b620b2..bdf0fb9cee59 100644
--- a/services/core/java/com/android/server/notification/ConditionProviders.java
+++ b/services/core/java/com/android/server/notification/ConditionProviders.java
@@ -76,7 +76,8 @@ public class ConditionProviders extends ManagedServices {
public void addSystemProvider(SystemConditionProviderService service) {
mSystemConditionProviders.add(service);
service.attachBase(mContext);
- registerService(service.asInterface(), service.getComponent(), UserHandle.USER_SYSTEM);
+ registerSystemService(
+ service.asInterface(), service.getComponent(), UserHandle.USER_SYSTEM);
}
public Iterable<SystemConditionProviderService> getSystemProviders() {
diff --git a/services/core/java/com/android/server/notification/ManagedServices.java b/services/core/java/com/android/server/notification/ManagedServices.java
index 5d3dc5f19714..fad0a7db6c4e 100644
--- a/services/core/java/com/android/server/notification/ManagedServices.java
+++ b/services/core/java/com/android/server/notification/ManagedServices.java
@@ -118,7 +118,7 @@ abstract public class ManagedServices {
protected final Context mContext;
protected final Object mMutex;
private final UserProfiles mUserProfiles;
- private final IPackageManager mPm;
+ protected final IPackageManager mPm;
protected final UserManager mUm;
private final Config mConfig;
private final Handler mHandler = new Handler(Looper.getMainLooper());
@@ -890,9 +890,10 @@ abstract public class ManagedServices {
unregisterServiceImpl(service, userid);
}
- public void registerService(IInterface service, ComponentName component, int userid) {
+ public void registerSystemService(IInterface service, ComponentName component, int userid) {
checkNotNull(service);
- ManagedServiceInfo info = registerServiceImpl(service, component, userid);
+ ManagedServiceInfo info = registerServiceImpl(
+ service, component, userid, Build.VERSION_CODES.CUR_DEVELOPMENT);
if (info != null) {
onServiceAdded(info);
}
@@ -1458,9 +1459,9 @@ abstract public class ManagedServices {
}
private ManagedServiceInfo registerServiceImpl(final IInterface service,
- final ComponentName component, final int userid) {
+ final ComponentName component, final int userid, int targetSdk) {
ManagedServiceInfo info = newServiceInfo(service, component, userid,
- true /*isSystem*/, null /*connection*/, Build.VERSION_CODES.LOLLIPOP);
+ true /*isSystem*/, null /*connection*/, targetSdk);
return registerServiceImpl(info);
}
diff --git a/services/core/java/com/android/server/notification/NotificationManagerService.java b/services/core/java/com/android/server/notification/NotificationManagerService.java
index 9b02b48f7825..8e9af1c63dc4 100755
--- a/services/core/java/com/android/server/notification/NotificationManagerService.java
+++ b/services/core/java/com/android/server/notification/NotificationManagerService.java
@@ -222,7 +222,6 @@ import android.util.Log;
import android.util.Pair;
import android.util.Slog;
import android.util.SparseArray;
-import android.util.SparseArrayMap;
import android.util.StatsEvent;
import android.util.Xml;
import android.util.proto.ProtoOutputStream;
@@ -290,7 +289,6 @@ import java.io.InputStream;
import java.io.OutputStream;
import java.io.PrintWriter;
import java.nio.charset.StandardCharsets;
-import java.util.ArrayDeque;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Iterator;
@@ -3830,7 +3828,7 @@ public class NotificationManagerService extends SystemService {
public void registerListener(final INotificationListener listener,
final ComponentName component, final int userid) {
enforceSystemOrSystemUI("INotificationManager.registerListener");
- mListeners.registerService(listener, component, userid);
+ mListeners.registerSystemService(listener, component, userid);
}
/**
diff --git a/services/tests/uiservicestests/src/com/android/server/notification/ManagedServicesTest.java b/services/tests/uiservicestests/src/com/android/server/notification/ManagedServicesTest.java
index 28ff9a545513..99433a6603c9 100644
--- a/services/tests/uiservicestests/src/com/android/server/notification/ManagedServicesTest.java
+++ b/services/tests/uiservicestests/src/com/android/server/notification/ManagedServicesTest.java
@@ -972,7 +972,7 @@ public class ManagedServicesTest extends UiServiceTestCase {
when(service.asBinder()).thenReturn(mock(IBinder.class));
ManagedServices services = new TestManagedServices(getContext(), mLock, mUserProfiles,
mIpm, APPROVAL_BY_PACKAGE);
- services.registerService(service, null, 10);
+ services.registerSystemService(service, null, 10);
ManagedServices.ManagedServiceInfo info = services.checkServiceTokenLocked(service);
info.isSystem = true;