summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author paulhu <paulhu@google.com> 2019-04-04 00:57:26 -0700
committer Lorenzo Colitti <lorenzo@google.com> 2019-04-09 08:57:08 +0000
commit1677869191cf1e7c70a1fa6fb6d92072f3a03944 (patch)
tree3c36262d4ada8e25f2dec5ec34afe4aaf2766977
parent8d994400b5f24062a10c26bb3fa53bbf615bc0f1 (diff)
Fix ConnectivityServiceTest fail.
NetdService#getInstance() will get null object in WrappedConnectivityService constructor. Then pass this null INetd object to PermissionMonitor will case NPE in PermissionMonitor#sendPackagePermissionsToNetd() Bug: 128024100 Test: atest FrameworksNetTests Change-Id: Ia1c80f9600a19c4aaf3f3c1b497b355d96c49c8e Merged-In: I7f185e731db91c30a9b0f14aefbdbb067942190e Merged-In: Ic77ef73841266da487401ffd657ef63562b6fc1e (cherry picked from commit 7d215078521ea03bbd692364e882d02ad065ced0)
-rw-r--r--services/core/java/com/android/server/connectivity/PermissionMonitor.java5
1 files changed, 4 insertions, 1 deletions
diff --git a/services/core/java/com/android/server/connectivity/PermissionMonitor.java b/services/core/java/com/android/server/connectivity/PermissionMonitor.java
index da1360d59539..b6946023e870 100644
--- a/services/core/java/com/android/server/connectivity/PermissionMonitor.java
+++ b/services/core/java/com/android/server/connectivity/PermissionMonitor.java
@@ -469,7 +469,10 @@ public class PermissionMonitor {
*/
@VisibleForTesting
void sendPackagePermissionsToNetd(SparseIntArray netdPermissionsAppIds) {
-
+ if (mNetd == null) {
+ Log.e(TAG, "Failed to get the netd service");
+ return;
+ }
ArrayList<Integer> allPermissionAppIds = new ArrayList<>();
ArrayList<Integer> internetPermissionAppIds = new ArrayList<>();
ArrayList<Integer> updateStatsPermissionAppIds = new ArrayList<>();