diff options
| author | 2023-06-28 18:39:34 +0000 | |
|---|---|---|
| committer | 2023-06-28 18:39:34 +0000 | |
| commit | 150077cc045ccd1a99c3c4836496aa404a6a2258 (patch) | |
| tree | 38cb7eaf203f44c05fb5d1ca59ea4368d1ee1dbc | |
| parent | a43e6a4c53756f1c4c66e0f1438ca385f7a3a1a0 (diff) | |
| parent | 7f3ff219a28e5256dfdc7d5e78f1258204ef4fba (diff) | |
Merge "Avoid fullscreen bounds check while exiting pip" into udc-dev am: 7f3ff219a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/23816915
Change-Id: Ic8c739a83ef969a595eb5a620e3179eca4d071f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
| -rw-r--r-- | libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java index 24aaa9b75ebe..d6451d75a012 100644 --- a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java +++ b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java @@ -567,7 +567,16 @@ public class PipTransition extends PipTransitionController { mPipBoundsState.getDisplayBounds()); mFinishCallback = (wct, wctCB) -> { mPipOrganizer.onExitPipFinished(taskInfo); - if (!Transitions.SHELL_TRANSITIONS_ROTATION && toFullscreen) { + + // TODO(b/286346098): remove the OPEN app flicker completely + // not checking if we go to fullscreen helps avoid getting pip into an inconsistent + // state after the flicker occurs. This is a temp solution until flicker is removed. + if (!Transitions.SHELL_TRANSITIONS_ROTATION) { + // will help to debug the case when we are not exiting to fullscreen + if (!toFullscreen) { + ProtoLog.d(ShellProtoLogGroup.WM_SHELL_PICTURE_IN_PICTURE, + "%s: startExitAnimation() not exiting to fullscreen", TAG); + } wct = wct != null ? wct : new WindowContainerTransaction(); wct.setBounds(pipTaskToken, null); mPipOrganizer.applyWindowingModeChangeOnExit(wct, TRANSITION_DIRECTION_LEAVE_PIP); |