diff options
| author | 2020-02-25 16:29:52 -0500 | |
|---|---|---|
| committer | 2020-02-26 12:42:11 +0000 | |
| commit | 146e157a69dc751999883dde82b8d12d9a420e3e (patch) | |
| tree | fd9839cb5e9e5f62c68c7401591962d7a9fe1b15 | |
| parent | d61bdf17dd3493e6963a645bd851c421a70c3e3e (diff) | |
Update colors for inline controls
- Buttons and whatnot should match the theme accent color
- Background should be white to maintain a11y contrast
Test: manual
Fixes: 149569128
Change-Id: I0d38484bb91aa1cdd4ae2f7de6dc2c72d15cd0ef
9 files changed, 8 insertions, 21 deletions
diff --git a/packages/SystemUI/res/color/notification_guts_priority_button_bg_stroke.xml b/packages/SystemUI/res/color/notification_guts_priority_button_bg_stroke.xml index 7964609f62e0..015e9f99212d 100644 --- a/packages/SystemUI/res/color/notification_guts_priority_button_bg_stroke.xml +++ b/packages/SystemUI/res/color/notification_guts_priority_button_bg_stroke.xml @@ -16,6 +16,6 @@ <selector xmlns:android="http://schemas.android.com/apk/res/android"> <item android:state_selected="true" - android:color="@color/notification_guts_priority_button_bg_stroke_color_selected" /> + android:color="?android:attr/colorAccent" /> <item android:color="@color/notification_guts_priority_button_bg_stroke_color" /> </selector> diff --git a/packages/SystemUI/res/color/notification_guts_priority_contents.xml b/packages/SystemUI/res/color/notification_guts_priority_contents.xml index 56c43f0e5642..42f01896d7a1 100644 --- a/packages/SystemUI/res/color/notification_guts_priority_contents.xml +++ b/packages/SystemUI/res/color/notification_guts_priority_contents.xml @@ -16,6 +16,6 @@ <selector xmlns:android="http://schemas.android.com/apk/res/android"> <item android:state_selected="true" - android:color="@color/notification_guts_priority_button_content_color_selected" /> + android:color="?android:attr/colorAccent" /> <item android:color="@color/notification_guts_priority_button_content_color" /> </selector> diff --git a/packages/SystemUI/res/drawable/notification_guts_bg.xml b/packages/SystemUI/res/drawable/notification_guts_bg.xml index 1730dcefe480..2fe6c7b2d1a2 100644 --- a/packages/SystemUI/res/drawable/notification_guts_bg.xml +++ b/packages/SystemUI/res/drawable/notification_guts_bg.xml @@ -16,7 +16,7 @@ --> <shape xmlns:android="http://schemas.android.com/apk/res/android"> - <solid android:color="@color/notification_guts_bg_color" /> + <solid android:color="@color/notification_material_background_color" /> <!--The radius is 1dp smaller than the notification one, to avoid aliasing bugs on the corners --> <corners android:radius="1dp" /> </shape> diff --git a/packages/SystemUI/res/layout/app_ops_info.xml b/packages/SystemUI/res/layout/app_ops_info.xml index 82a0115098f2..bfa252c5a14b 100644 --- a/packages/SystemUI/res/layout/app_ops_info.xml +++ b/packages/SystemUI/res/layout/app_ops_info.xml @@ -26,7 +26,7 @@ android:orientation="vertical" android:paddingStart="@*android:dimen/notification_content_margin_start" android:paddingEnd="@*android:dimen/notification_content_margin_end" - android:background="@color/notification_guts_bg_color" + android:background="@color/notification_material_background_color" android:theme="@*android:style/Theme.DeviceDefault.Light"> <!-- Package Info --> diff --git a/packages/SystemUI/res/layout/notification_info.xml b/packages/SystemUI/res/layout/notification_info.xml index 87de9d4d3b51..5d03eee11f75 100644 --- a/packages/SystemUI/res/layout/notification_info.xml +++ b/packages/SystemUI/res/layout/notification_info.xml @@ -24,8 +24,7 @@ android:clipChildren="false" android:clipToPadding="true" android:orientation="vertical" - android:paddingStart="@*android:dimen/notification_content_margin_start" - android:background="@color/notification_guts_bg_color"> + android:paddingStart="@*android:dimen/notification_content_margin_start"> <!-- Package Info --> <RelativeLayout diff --git a/packages/SystemUI/res/layout/notification_snooze.xml b/packages/SystemUI/res/layout/notification_snooze.xml index ffe2eee80447..c350ed22b765 100644 --- a/packages/SystemUI/res/layout/notification_snooze.xml +++ b/packages/SystemUI/res/layout/notification_snooze.xml @@ -21,7 +21,7 @@ android:layout_height="wrap_content" android:orientation="vertical" android:clickable="true" - android:background="@color/notification_guts_bg_color" + android:background="@color/notification_material_background_color" android:theme="@style/Theme.SystemUI"> <RelativeLayout diff --git a/packages/SystemUI/res/values-night/colors.xml b/packages/SystemUI/res/values-night/colors.xml index 9a66e8bc8791..9b0fe465deee 100644 --- a/packages/SystemUI/res/values-night/colors.xml +++ b/packages/SystemUI/res/values-night/colors.xml @@ -39,23 +39,16 @@ <!-- The color of the ripples on the untinted notifications --> <color name="notification_ripple_untinted_color">#30ffffff</color> - <!-- The "inside" of a notification, reached via longpress --> - <color name="notification_guts_bg_color">@color/GM2_grey_900</color> - <!-- The color of the text inside a notification --> <color name="notification_primary_text_color">@*android:color/notification_primary_text_color_dark</color> <color name="notification_guts_link_icon_tint">@color/GM2_grey_500</color> <color name="notification_guts_sub_text_color">@color/GM2_grey_300</color> <color name="notification_guts_header_text_color">@color/GM2_grey_200</color> - <color name="notification_guts_info_button_color">@color/GM2_blue_300</color> <color name="notification_guts_priority_button_content_color">@color/GM2_grey_500</color> - <color name="notification_guts_priority_button_content_color_selected">@color/GM2_blue_300</color> <color name="notification_guts_priority_button_bg_fill_color">@color/transparent</color> <color name="notification_guts_priority_button_bg_fill_color_selected">@color/GM2_grey_800</color> <color name="notification_guts_priority_button_bg_stroke_color">@color/GM2_grey_700</color> - <color name="notification_guts_priority_button_bg_stroke_color_selected">@color/GM2_blue_300</color> - <color name="notification_section_header_label_color">@color/GM2_grey_200</color> <color name="notification_section_clear_all_btn_color">@color/GM2_grey_500</color> <color name="notification_channel_dialog_separator">@color/GM2_grey_700</color> diff --git a/packages/SystemUI/res/values/colors.xml b/packages/SystemUI/res/values/colors.xml index 43ceb4ecaee8..73e49cee6a8b 100644 --- a/packages/SystemUI/res/values/colors.xml +++ b/packages/SystemUI/res/values/colors.xml @@ -88,21 +88,16 @@ <!-- The color of the text inside a notification --> <color name="notification_primary_text_color">@*android:color/notification_primary_text_color_light</color> - <!-- The "inside" of a notification, reached via longpress --> - <color name="notification_guts_bg_color">@color/GM2_grey_50</color> <color name="notification_guts_link_icon_tint">@color/GM2_grey_700</color> <color name="notification_guts_sub_text_color">@color/GM2_grey_700</color> <color name="notification_guts_header_text_color">@color/GM2_grey_900</color> <color name="notification_silence_color">#FF32c1de</color> <color name="notification_alert_color">#FFF87B2B</color> - <color name="notification_guts_info_button_color">@color/GM2_blue_700</color> <color name="notification_guts_priority_button_content_color">@color/GM2_grey_700</color> - <color name="notification_guts_priority_button_content_color_selected">@color/GM2_blue_700</color> <color name="notification_guts_priority_button_bg_fill_color">@color/transparent</color> <color name="notification_guts_priority_button_bg_fill_color_selected">#FFFFFF</color> <color name="notification_guts_priority_button_bg_stroke_color">@color/GM2_grey_300</color> - <color name="notification_guts_priority_button_bg_stroke_color_selected">@color/GM2_blue_600</color> <color name="notification_section_header_label_color">@color/GM2_grey_900</color> <color name="notification_section_clear_all_btn_color">@color/GM2_grey_700</color> diff --git a/packages/SystemUI/res/values/styles.xml b/packages/SystemUI/res/values/styles.xml index 36c4526fb521..d9b1452b6bb1 100644 --- a/packages/SystemUI/res/values/styles.xml +++ b/packages/SystemUI/res/values/styles.xml @@ -514,7 +514,7 @@ <style name="TextAppearance.NotificationInfo.Button"> <item name="android:fontFamily">@*android:string/config_headlineFontFamilyMedium</item> <item name="android:textSize">14sp</item> - <item name="android:textColor">@color/notification_guts_info_button_color</item> + <item name="android:textColor">?android:attr/colorAccent</item> <item name="android:background">@drawable/btn_borderless_rect</item> <item name="android:gravity">center_vertical</item> <item name="android:focusable">true</item> @@ -550,7 +550,7 @@ <style name="TextAppearance.NotificationImportanceButton"> <item name="android:textSize">@dimen/notification_importance_button_text</item> <item name="android:fontFamily">@*android:string/config_headlineFontFamilyMedium</item> - <item name="android:textColor">@color/notification_guts_priority_contents</item> + <item name="android:textColor">?android:attr/colorAccent</item> <item name="android:gravity">center</item> </style> |