summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Marco Nelissen <marcone@google.com> 2014-01-14 08:15:13 -0800
committer Android Git Automerger <android-git-automerger@android.com> 2014-01-14 08:15:13 -0800
commit13249411b1c7dd4a476eec6905998217636a9344 (patch)
treec6e2bc40f781808e1d4dfd3898e59d70023cc77e
parent80b0496abeb03fe4c5086430218c7e4bcf3773db (diff)
parenta9045d24a73faa6aa1e8ad204a1e14a53711a824 (diff)
am a9045d24: am 337aa376: Merge "Add NULL check in updateProxyConfig"
* commit 'a9045d24a73faa6aa1e8ad204a1e14a53711a824': Add NULL check in updateProxyConfig
-rw-r--r--media/jni/android_media_MediaPlayer.cpp19
1 files changed, 11 insertions, 8 deletions
diff --git a/media/jni/android_media_MediaPlayer.cpp b/media/jni/android_media_MediaPlayer.cpp
index 4be9cd611ded..5e3fb1a1be46 100644
--- a/media/jni/android_media_MediaPlayer.cpp
+++ b/media/jni/android_media_MediaPlayer.cpp
@@ -826,16 +826,19 @@ android_media_MediaPlayer_updateProxyConfig(
jstring exclusionListObj = (jstring)env->CallObjectMethod(
proxyProps, fields.proxyConfigGetExclusionList);
- const char *exclusionList =
- env->GetStringUTFChars(exclusionListObj, NULL);
-
if (host != NULL && exclusionListObj != NULL) {
- thisplayer->updateProxyConfig(host, port, exclusionList);
- }
+ const char *exclusionList = env->GetStringUTFChars(exclusionListObj, NULL);
+
+ if (exclusionList != NULL) {
+ thisplayer->updateProxyConfig(host, port, exclusionList);
- if (exclusionList != NULL) {
- env->ReleaseStringUTFChars(exclusionListObj, exclusionList);
- exclusionList = NULL;
+ env->ReleaseStringUTFChars(exclusionListObj, exclusionList);
+ exclusionList = NULL;
+ } else {
+ thisplayer->updateProxyConfig(host, port, "");
+ }
+ } else if (host != NULL) {
+ thisplayer->updateProxyConfig(host, port, "");
}
if (host != NULL) {