summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Hongwei Wang <hwwang@google.com> 2020-04-30 13:28:29 -0700
committer Hongwei Wang <hwwang@google.com> 2020-04-30 13:41:41 -0700
commit1273c953455d497d93f504e17fa592834ed3a123 (patch)
tree23165fcc6b0d7d878715d9927b7eea72138d2751
parentb8ad491e6d81ae96f43f57cddbd50060cdde27f5 (diff)
Put safeguard in dismissPip
Not able to reproduce the crash but in general, dismissPip should not happen when not in PiP mode. Bug: 155024023 Test: N/A Change-Id: Iea19ffc632ca8ca411b25d8b08ee4e91b2dd7360
-rw-r--r--packages/SystemUI/src/com/android/systemui/pip/PipTaskOrganizer.java5
1 files changed, 5 insertions, 0 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/pip/PipTaskOrganizer.java b/packages/SystemUI/src/com/android/systemui/pip/PipTaskOrganizer.java
index d38c481752c6..7295f327d47a 100644
--- a/packages/SystemUI/src/com/android/systemui/pip/PipTaskOrganizer.java
+++ b/packages/SystemUI/src/com/android/systemui/pip/PipTaskOrganizer.java
@@ -238,6 +238,11 @@ public class PipTaskOrganizer extends TaskOrganizer {
* @param animationDurationMs duration in millisecond for the exiting PiP transition
*/
public void dismissPip(int animationDurationMs) {
+ if (!mInPip || mToken == null) {
+ Log.wtf(TAG, "Not allowed to dismissPip in current state"
+ + " mInPip=" + mInPip + " mToken=" + mToken);
+ return;
+ }
final WindowContainerTransaction wct = new WindowContainerTransaction();
wct.setActivityWindowingMode(mToken, WINDOWING_MODE_UNDEFINED);
WindowOrganizer.applyTransaction(wct);