summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Ruchi Kandoi <kandoiruchi@google.com> 2016-04-20 20:59:18 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2016-04-20 20:59:20 +0000
commit0fea8ad44748abd031c2e73cd5e6bce6a086c5f3 (patch)
tree5a9644b1c0599e6167d5efc12e0d308e29f06d05
parentf3d5a4dd60b3ec461e4d9fee97ce99a92cb29b1b (diff)
parent9c36c02f0ea5f54bcb7cdf2a6175f4b8f92205a2 (diff)
Merge "Revert "PowerManager: Adds the Sustained performance API."" into nyc-dev
-rw-r--r--api/current.txt1
-rw-r--r--api/system-current.txt1
-rw-r--r--api/test-current.txt1
-rw-r--r--core/java/android/os/PowerManager.java10
-rw-r--r--services/core/java/com/android/server/power/PowerManagerService.java73
5 files changed, 7 insertions, 79 deletions
diff --git a/api/current.txt b/api/current.txt
index 823ceeeab5e9..7fe5728ec0d0 100644
--- a/api/current.txt
+++ b/api/current.txt
@@ -29146,7 +29146,6 @@ package android.os {
field public static final int RELEASE_FLAG_WAIT_FOR_NO_PROXIMITY = 1; // 0x1
field public static final deprecated int SCREEN_BRIGHT_WAKE_LOCK = 10; // 0xa
field public static final deprecated int SCREEN_DIM_WAKE_LOCK = 6; // 0x6
- field public static final int SUSTAINED_PERFORMANCE_WAKE_LOCK = 256; // 0x100
}
public final class PowerManager.WakeLock {
diff --git a/api/system-current.txt b/api/system-current.txt
index 78039ae34bee..dfaae6bf694b 100644
--- a/api/system-current.txt
+++ b/api/system-current.txt
@@ -31574,7 +31574,6 @@ package android.os {
field public static final int RELEASE_FLAG_WAIT_FOR_NO_PROXIMITY = 1; // 0x1
field public static final deprecated int SCREEN_BRIGHT_WAKE_LOCK = 10; // 0xa
field public static final deprecated int SCREEN_DIM_WAKE_LOCK = 6; // 0x6
- field public static final int SUSTAINED_PERFORMANCE_WAKE_LOCK = 256; // 0x100
field public static final int USER_ACTIVITY_EVENT_ACCESSIBILITY = 3; // 0x3
field public static final int USER_ACTIVITY_EVENT_BUTTON = 1; // 0x1
field public static final int USER_ACTIVITY_EVENT_OTHER = 0; // 0x0
diff --git a/api/test-current.txt b/api/test-current.txt
index 6fddf8c0c95f..88031cf9d505 100644
--- a/api/test-current.txt
+++ b/api/test-current.txt
@@ -29214,7 +29214,6 @@ package android.os {
field public static final int RELEASE_FLAG_WAIT_FOR_NO_PROXIMITY = 1; // 0x1
field public static final deprecated int SCREEN_BRIGHT_WAKE_LOCK = 10; // 0xa
field public static final deprecated int SCREEN_DIM_WAKE_LOCK = 6; // 0x6
- field public static final int SUSTAINED_PERFORMANCE_WAKE_LOCK = 256; // 0x100
}
public final class PowerManager.WakeLock {
diff --git a/core/java/android/os/PowerManager.java b/core/java/android/os/PowerManager.java
index 92edc62617cb..16d90de1acb0 100644
--- a/core/java/android/os/PowerManager.java
+++ b/core/java/android/os/PowerManager.java
@@ -219,15 +219,6 @@ public final class PowerManager {
public static final int DRAW_WAKE_LOCK = 0x00000080;
/**
- * Wake lock level: Enables Sustained Performance Mode.
- * <p>
- * This is used by Gaming and VR applications to ensure the device
- * will provide consistent performance over a large amount of time.
- * </p>
- */
- public static final int SUSTAINED_PERFORMANCE_WAKE_LOCK = 0x00000100;
-
- /**
* Mask for the wake lock level component of a combined wake lock level and flags integer.
*
* @hide
@@ -559,7 +550,6 @@ public final class PowerManager {
case PROXIMITY_SCREEN_OFF_WAKE_LOCK:
case DOZE_WAKE_LOCK:
case DRAW_WAKE_LOCK:
- case SUSTAINED_PERFORMANCE_WAKE_LOCK:
break;
default:
throw new IllegalArgumentException("Must specify a valid wake lock level.");
diff --git a/services/core/java/com/android/server/power/PowerManagerService.java b/services/core/java/com/android/server/power/PowerManagerService.java
index 8cd536de9b54..12a2d2ef924a 100644
--- a/services/core/java/com/android/server/power/PowerManagerService.java
+++ b/services/core/java/com/android/server/power/PowerManagerService.java
@@ -143,7 +143,6 @@ public final class PowerManagerService extends SystemService
private static final int WAKE_LOCK_STAY_AWAKE = 1 << 5; // only set if already awake
private static final int WAKE_LOCK_DOZE = 1 << 6;
private static final int WAKE_LOCK_DRAW = 1 << 7;
- private static final int WAKE_LOCK_SUSTAINED_PERFORMANCE = 1 << 8;
// Summarizes the user activity state.
private static final int USER_ACTIVITY_SCREEN_BRIGHT = 1 << 0;
@@ -162,7 +161,6 @@ public final class PowerManagerService extends SystemService
// Power hints defined in hardware/libhardware/include/hardware/power.h.
private static final int POWER_HINT_LOW_POWER = 5;
- private static final int POWER_HINT_SUSTAINED_PERFORMANCE = 6;
private static final int POWER_HINT_VR_MODE = 7;
// Power features defined in hardware/libhardware/include/hardware/power.h.
@@ -470,9 +468,6 @@ public final class PowerManagerService extends SystemService
// True if we are currently in light device idle mode.
private boolean mLightDeviceIdleMode;
- // True if we are currently in sustained performance mode.
- private boolean mSustainedPerformanceMode;
-
// Set of app ids that we will always respect the wake locks for.
int[] mDeviceIdleWhitelist = new int[0];
@@ -481,8 +476,6 @@ public final class PowerManagerService extends SystemService
private final SparseIntArray mUidState = new SparseIntArray();
- private final SparseIntArray mSustainedPerformanceUid = new SparseIntArray();
-
// True if theater mode is enabled
private boolean mTheaterModeEnabled;
@@ -879,12 +872,6 @@ public final class PowerManagerService extends SystemService
throw new IllegalArgumentException("Wake lock is already dead.");
}
mWakeLocks.add(wakeLock);
-
- if ((flags & PowerManager.WAKE_LOCK_LEVEL_MASK)
- == PowerManager.SUSTAINED_PERFORMANCE_WAKE_LOCK) {
- int numberWakelock = mSustainedPerformanceUid.get(uid);
- mSustainedPerformanceUid.put(uid, numberWakelock + 1);
- }
setWakeLockDisabledStateLocked(wakeLock);
notifyAcquire = true;
}
@@ -953,17 +940,6 @@ public final class PowerManagerService extends SystemService
mRequestWaitForNegativeProximity = true;
}
-
- if ((wakeLock.mFlags & PowerManager.WAKE_LOCK_LEVEL_MASK)
- == PowerManager.SUSTAINED_PERFORMANCE_WAKE_LOCK) {
- int numberWakelock = mSustainedPerformanceUid.get(wakeLock.mOwnerUid);
- if (numberWakelock == 1) {
- mSustainedPerformanceUid.delete(wakeLock.mOwnerUid);
- } else {
- mSustainedPerformanceUid.put(wakeLock.mOwnerUid, numberWakelock - 1);
- }
- }
-
wakeLock.mLock.unlinkToDeath(wakeLock, 0);
removeWakeLockLocked(wakeLock, index);
}
@@ -1586,10 +1562,6 @@ public final class PowerManagerService extends SystemService
break;
case PowerManager.DRAW_WAKE_LOCK:
mWakeLockSummary |= WAKE_LOCK_DRAW;
- case PowerManager.SUSTAINED_PERFORMANCE_WAKE_LOCK:
- if (!wakeLock.mDisabled) {
- mWakeLockSummary |= WAKE_LOCK_SUSTAINED_PERFORMANCE;
- }
break;
}
}
@@ -2288,14 +2260,6 @@ public final class PowerManagerService extends SystemService
if (autoSuspend && mDecoupleHalAutoSuspendModeFromDisplayConfig) {
setHalAutoSuspendModeLocked(true);
}
-
- if (mSustainedPerformanceMode
- && (mWakeLockSummary & WAKE_LOCK_SUSTAINED_PERFORMANCE) == 0) {
- setSustainedPerformanceModeLocked(false);
- } else if (!mSustainedPerformanceMode
- && (mWakeLockSummary & WAKE_LOCK_SUSTAINED_PERFORMANCE) != 0) {
- setSustainedPerformanceModeLocked(true);
- }
}
/**
@@ -2394,12 +2358,6 @@ public final class PowerManagerService extends SystemService
}
}
- private void setSustainedPerformanceModeLocked(boolean mode) {
- mSustainedPerformanceMode = mode;
- powerHintInternal(POWER_HINT_SUSTAINED_PERFORMANCE,
- mSustainedPerformanceMode ? 1 : 0);
- }
-
boolean isDeviceIdleModeInternal() {
synchronized (mLock) {
return mDeviceIdleMode;
@@ -2531,7 +2489,7 @@ public final class PowerManagerService extends SystemService
void updateUidProcStateInternal(int uid, int procState) {
synchronized (mLock) {
mUidState.put(uid, procState);
- if (mDeviceIdleMode || mSustainedPerformanceUid.get(uid) != 0) {
+ if (mDeviceIdleMode) {
updateWakeLockDisabledStatesLocked();
}
}
@@ -2552,9 +2510,7 @@ public final class PowerManagerService extends SystemService
for (int i = 0; i < numWakeLocks; i++) {
final WakeLock wakeLock = mWakeLocks.get(i);
if ((wakeLock.mFlags & PowerManager.WAKE_LOCK_LEVEL_MASK)
- == PowerManager.PARTIAL_WAKE_LOCK
- || (wakeLock.mFlags & PowerManager.WAKE_LOCK_LEVEL_MASK)
- == PowerManager.SUSTAINED_PERFORMANCE_WAKE_LOCK) {
+ == PowerManager.PARTIAL_WAKE_LOCK) {
if (setWakeLockDisabledStateLocked(wakeLock)) {
changed = true;
if (wakeLock.mDisabled) {
@@ -2573,9 +2529,9 @@ public final class PowerManagerService extends SystemService
}
private boolean setWakeLockDisabledStateLocked(WakeLock wakeLock) {
- boolean disabled = false;
if ((wakeLock.mFlags & PowerManager.WAKE_LOCK_LEVEL_MASK)
== PowerManager.PARTIAL_WAKE_LOCK) {
+ boolean disabled = false;
if (mDeviceIdleMode) {
final int appid = UserHandle.getAppId(wakeLock.mOwnerUid);
// If we are in idle mode, we will ignore all partial wake locks that are
@@ -2589,16 +2545,10 @@ public final class PowerManagerService extends SystemService
disabled = true;
}
}
- } else if ((wakeLock.mFlags & PowerManager.WAKE_LOCK_LEVEL_MASK)
- == PowerManager.SUSTAINED_PERFORMANCE_WAKE_LOCK
- && mUidState.get(wakeLock.mOwnerUid,
- ActivityManager.PROCESS_STATE_CACHED_EMPTY)
- > ActivityManager.PROCESS_STATE_TOP) {
- disabled = true;
- }
- if (wakeLock.mDisabled != disabled) {
- wakeLock.mDisabled = disabled;
- return true;
+ if (wakeLock.mDisabled != disabled) {
+ wakeLock.mDisabled = disabled;
+ return true;
+ }
}
return false;
}
@@ -2806,7 +2756,6 @@ public final class PowerManagerService extends SystemService
pw.println(" mBatteryLevelLow=" + mBatteryLevelLow);
pw.println(" mLightDeviceIdleMode=" + mLightDeviceIdleMode);
pw.println(" mDeviceIdleMode=" + mDeviceIdleMode);
- pw.println(" mSustainedPerformanceMode=" + mSustainedPerformanceMode);
pw.println(" mDeviceIdleWhitelist=" + Arrays.toString(mDeviceIdleWhitelist));
pw.println(" mDeviceIdleTempWhitelist=" + Arrays.toString(mDeviceIdleTempWhitelist));
pw.println(" mLastWakeTime=" + TimeUtils.formatUptime(mLastWakeTime));
@@ -2921,14 +2870,6 @@ public final class PowerManagerService extends SystemService
pw.println();
pw.println("Display Power: " + mDisplayPowerCallbacks);
- pw.println();
- pw.println("Sustained Performance UIDs:");
- for (int i=0; i<mSustainedPerformanceUid.size(); i++) {
- pw.print(" UID "); UserHandle.formatUid(pw, mSustainedPerformanceUid.keyAt(i));
- pw.print(": "); pw.println(mSustainedPerformanceUid.valueAt(i));
- }
-
-
wcd = mWirelessChargerDetector;
}