summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Ioana Alexandru <aioana@google.com> 2024-11-22 13:03:21 +0100
committer Ioana Alexandru <aioana@google.com> 2024-12-09 19:31:34 +0100
commit0f3f196a99f37e66bd8b26dbdef3b71c87a9411e (patch)
treec8a4511d85a026f5f08f492fd726009315ff231f
parent37507ae292eef969c507d9438a4692539035f764 (diff)
[Notif redesign] Consolidate MessagingGroup
The icons and alignment for the old messaging style and the new conversation style are no longer different, so we don't need to override things in MessagingGroup based on whether it's in a conversation or not. Bug: 378660052 Test: visual test, screenshot tests to come later Flag: android.app.notifications_redesign_templates Change-Id: Ic25829bcc8120762621065fab37a10808eb2e7ec
-rw-r--r--core/java/com/android/internal/widget/MessagingGroup.java6
-rw-r--r--core/res/res/layout/notification_2025_messaging_group.xml12
2 files changed, 11 insertions, 7 deletions
diff --git a/core/java/com/android/internal/widget/MessagingGroup.java b/core/java/com/android/internal/widget/MessagingGroup.java
index 4305ba753e46..169a9e8585b0 100644
--- a/core/java/com/android/internal/widget/MessagingGroup.java
+++ b/core/java/com/android/internal/widget/MessagingGroup.java
@@ -81,7 +81,6 @@ public class MessagingGroup extends NotificationOptimizedLinearLayout implements
private MessagingLinearLayout mMessageContainer;
ImageFloatingTextView mSenderView;
private ImageView mAvatarView;
- private View mAvatarContainer;
private String mAvatarSymbol = "";
private int mLayoutColor;
private CharSequence mAvatarName = "";
@@ -717,6 +716,11 @@ public class MessagingGroup extends NotificationOptimizedLinearLayout implements
* @param isInConversation is this in a conversation
*/
public void setIsInConversation(boolean isInConversation) {
+ if (Flags.notificationsRedesignTemplates()) {
+ // No alignment adjustments are necessary in the redesign, as the size of the icons
+ // in both conversations and old messaging notifications are the same.
+ return;
+ }
if (mIsInConversation != isInConversation) {
mIsInConversation = isInConversation;
MarginLayoutParams layoutParams =
diff --git a/core/res/res/layout/notification_2025_messaging_group.xml b/core/res/res/layout/notification_2025_messaging_group.xml
index c1b491fc4b0e..ecaf0b9a785f 100644
--- a/core/res/res/layout/notification_2025_messaging_group.xml
+++ b/core/res/res/layout/notification_2025_messaging_group.xml
@@ -24,13 +24,13 @@
android:orientation="horizontal" >
<FrameLayout
android:id="@+id/message_icon_container"
- android:layout_width="@dimen/conversation_content_start"
+ android:layout_width="@dimen/notification_2025_content_margin_start"
android:layout_height="wrap_content">
<ImageView
android:layout_gravity="top|center_horizontal"
android:id="@+id/message_icon"
- android:layout_width="@dimen/messaging_avatar_size"
- android:layout_height="@dimen/messaging_avatar_size"
+ android:layout_width="@dimen/notification_2025_icon_circle_size"
+ android:layout_height="@dimen/notification_2025_icon_circle_size"
android:background="@drawable/notification_icon_circle"
android:clipToOutline="true"
android:scaleType="centerCrop"
@@ -58,14 +58,14 @@
</com.android.internal.widget.RemeasuringLinearLayout>
<FrameLayout
android:id="@+id/messaging_group_icon_container"
- android:layout_width="@dimen/messaging_avatar_size"
- android:layout_height="@dimen/messaging_avatar_size"
+ android:layout_width="@dimen/notification_2025_icon_circle_size"
+ android:layout_height="@dimen/notification_2025_icon_circle_size"
android:layout_marginStart="12dp"
android:visibility="gone"/>
<FrameLayout
android:id="@+id/messaging_group_sending_progress_container"
android:layout_width="@dimen/messaging_group_sending_progress_size"
- android:layout_height="@dimen/messaging_avatar_size"
+ android:layout_height="@dimen/notification_2025_icon_circle_size"
android:layout_marginStart="12dp"
android:layout_gravity="top"
android:visibility="gone">