summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Ale Nijamkin <nijamkin@google.com> 2023-04-20 22:00:09 +0000
committer Ale Nijamkin <nijamkin@google.com> 2023-04-20 22:00:16 +0000
commit0c4de34deffa78a9ad9270effeaf1efd28398d69 (patch)
tree3cc041a11a39ef5d04797e9dc67cb5cac90662e6
parenta235daba420d2f600f5708196a26c8dd49b5937e (diff)
Makes lock screen long-press popup background fixed.
By design, the icon, text, and background colors should not be changed between light and dark theme. The current code only uses a fixed color for the icon and text but uses a theme-changing color for the background. In light theme, this means that the popup is displayed as dark icon and text over a dark background, manifesting as the attached bug. Change-Id: Iba53a5742fd209bd8abbaf14eb57f2d9600f9b2c Fix: 279068244 Test: manually verified that the bug no longer manifest in either light or dark theme, restarting System UI each time the system theme was switched. It's now always dark icon/text over light background, as per UX design.
-rw-r--r--packages/SystemUI/res/drawable/keyguard_settings_popup_menu_background.xml2
1 files changed, 1 insertions, 1 deletions
diff --git a/packages/SystemUI/res/drawable/keyguard_settings_popup_menu_background.xml b/packages/SystemUI/res/drawable/keyguard_settings_popup_menu_background.xml
index a0ceb81d42f4..fe76ba7e5b8c 100644
--- a/packages/SystemUI/res/drawable/keyguard_settings_popup_menu_background.xml
+++ b/packages/SystemUI/res/drawable/keyguard_settings_popup_menu_background.xml
@@ -26,7 +26,7 @@
</item>
<item>
<shape android:shape="rectangle">
- <solid android:color="?androidprv:attr/materialColorOnBackground" />
+ <solid android:color="?androidprv:attr/materialColorSecondaryFixed" />
<corners android:radius="@dimen/keyguard_affordance_fixed_radius" />
</shape>
</item>