summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Yao Chen <yaochen@google.com> 2017-12-05 09:29:24 -0800
committer Yao Chen <yaochen@google.com> 2017-12-05 09:37:06 -0800
commit0b73ccad8fb47b1bcc5c89b0c10fac937336ab1e (patch)
tree2f05205e8008e39ba744896e297ec6ae6b1de088
parent456385cba9eaa3c1c04a8c0b877c896966234a44 (diff)
Urgent fix. Once UidMap size exceeds the limit, statsd triggers data drop every time a log comes in
Test: manual Change-Id: Idf93e5aca19b80acf964670fa4bc9f1f0781df1f
-rw-r--r--cmds/statsd/src/StatsLogProcessor.cpp10
1 files changed, 6 insertions, 4 deletions
diff --git a/cmds/statsd/src/StatsLogProcessor.cpp b/cmds/statsd/src/StatsLogProcessor.cpp
index bc63f5905e23..c6b8418077c7 100644
--- a/cmds/statsd/src/StatsLogProcessor.cpp
+++ b/cmds/statsd/src/StatsLogProcessor.cpp
@@ -84,10 +84,12 @@ void StatsLogProcessor::onAnomalyAlarmFired(
void StatsLogProcessor::OnLogEvent(const LogEvent& msg) {
StatsdStats::getInstance().noteAtomLogged(msg.GetTagId(), msg.GetTimestampNs() / NS_PER_SEC);
// pass the event to metrics managers.
- for (auto& pair : mMetricsManagers) {
- pair.second->onLogEvent(msg);
- flushIfNecessary(msg.GetTimestampNs(), pair.first, pair.second);
- }
+ // TODO: THIS CHECK FAILS BECAUSE ONCE UIDMAP SIZE EXCEEDS LIMIT, DROPPING METRICS DATA
+ // DOESN'T HELP. FIX THIS.
+ //for (auto& pair : mMetricsManagers) {
+ // pair.second->onLogEvent(msg);
+ // flushIfNecessary(msg.GetTimestampNs(), pair.first, pair.second);
+ //}
// Hard-coded logic to update the isolated uid's in the uid-map.
// The field numbers need to be currently updated by hand with atoms.proto