diff options
| author | 2022-12-07 04:36:46 +0000 | |
|---|---|---|
| committer | 2023-05-15 22:33:15 +0000 | |
| commit | 0a4792b62ea86c153653b0663ffe920d90b7cc15 (patch) | |
| tree | 0b83fffabfeea817a77d63bb28472a0ac21ae5ff | |
| parent | d978682f24776942469df0de39939918e000c890 (diff) | |
RingtoneManager: verify default ringtone is audio
When a ringtone picker tries to set a ringtone through
RingtoneManager.setActualDefaultRingtoneUri (also
called by com.android.settings.DefaultRingtonePreference),
verify the mimeType can be obtained (not found when caller
doesn't have access to it) and it is an audio resource.
Bug: 205837340
Test: atest android.media.audio.cts.RingtoneManagerTest
Change-Id: I3f2c487ded405c0c1a83ef0a2fe99cff7cc9328e
Merged-In: I3f2c487ded405c0c1a83ef0a2fe99cff7cc9328e
(cherry picked from commit 38618f9fb16d3b5617e2289354d47abe5af17dad)
| -rw-r--r-- | media/java/android/media/RingtoneManager.java | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/media/java/android/media/RingtoneManager.java b/media/java/android/media/RingtoneManager.java index 4ec79b7e085a..8aecf7f17026 100644 --- a/media/java/android/media/RingtoneManager.java +++ b/media/java/android/media/RingtoneManager.java @@ -802,10 +802,10 @@ public class RingtoneManager { return ringtoneUri; } - + /** * Sets the {@link Uri} of the default sound for a given sound type. - * + * * @param context A context used for querying. * @param type The type whose default sound should be set. One of * {@link #TYPE_RINGTONE}, {@link #TYPE_NOTIFICATION}, or @@ -826,6 +826,21 @@ public class RingtoneManager { if(!isInternalRingtoneUri(ringtoneUri)) { ringtoneUri = ContentProvider.maybeAddUserId(ringtoneUri, context.getUserId()); } + + if (ringtoneUri != null) { + final String mimeType = resolver.getType(ringtoneUri); + if (mimeType == null) { + Log.e(TAG, "setActualDefaultRingtoneUri for URI:" + ringtoneUri + + " ignored: failure to find mimeType (no access from this context?)"); + return; + } + if (!(mimeType.startsWith("audio/") || mimeType.equals("application/ogg"))) { + Log.e(TAG, "setActualDefaultRingtoneUri for URI:" + ringtoneUri + + " ignored: associated mimeType:" + mimeType + " is not an audio type"); + return; + } + } + Settings.System.putStringForUser(resolver, setting, ringtoneUri != null ? ringtoneUri.toString() : null, context.getUserId()); |