summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Yunlian Jiang <yunlian@google.com> 2017-03-22 00:21:57 +0000
committer android-build-merger <android-build-merger@google.com> 2017-03-22 00:21:57 +0000
commit0889a8a070a3efca70b0284b8df7145e82c7cc4f (patch)
tree2b95cec99ac0dc2704af1723fc3e3f16848d9855
parent4ff81206e05880943dc34af4b4e23f644f06bde3 (diff)
parent58ba53bd53d08c8d23f8fa338aa4c4bb6bc86c91 (diff)
Merge "Fix warning: Potential leak of memory pointed to by 'set'"
am: 58ba53bd53 Change-Id: I7186dc35fb7f4a3c226e35447ce9c748164e7bf8
-rw-r--r--libs/androidfw/ResourceTypes.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/libs/androidfw/ResourceTypes.cpp b/libs/androidfw/ResourceTypes.cpp
index e10db05e8557..38d2a588b594 100644
--- a/libs/androidfw/ResourceTypes.cpp
+++ b/libs/androidfw/ResourceTypes.cpp
@@ -4320,6 +4320,7 @@ ssize_t ResTable::getBagLocked(uint32_t resID, const bag_entry** outBag,
if (curOff > (dtohl(entry.type->header.size)-sizeof(ResTable_map))) {
ALOGW("ResTable_map at %d is beyond type chunk data %d",
(int)curOff, dtohl(entry.type->header.size));
+ free(set);
return BAD_TYPE;
}
map = (const ResTable_map*)(((const uint8_t*)entry.type) + curOff);
@@ -4332,6 +4333,7 @@ ssize_t ResTable::getBagLocked(uint32_t resID, const bag_entry** outBag,
if (grp->dynamicRefTable.lookupResourceId(&newName) != NO_ERROR) {
ALOGE("Failed resolving ResTable_map name at %d with ident 0x%08x",
(int) curOff, (int) newName);
+ free(set);
return UNKNOWN_ERROR;
}
}