summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Daichi Hirono <hirono@google.com> 2024-12-20 09:45:46 +0900
committer Daichi Hirono <hirono@google.com> 2024-12-20 10:50:14 +0900
commit0733b2e928d0a1d6f568308d00bba6ee2ff0b1b9 (patch)
treef160f5e5d461943a0795b0a4d75f553263d50740
parent26d9bbd3fe9d83dbbeff39007243c21bad1dd08e (diff)
Fix the format of argument name comments
This CL updates the format of argument name comments. The following command is used to find comments to be fixed: rg '/\*\s+\w+\s+\*/' \ -g "**/desktopmode/**" \ -g "!src/com/android/wm/shell/desktopmode/DesktopModeEventLogger.kt" \ -g "!tests/unittest/src/com/android/wm/shell/desktopmode/DesktopModeEventLoggerTest.kt" The comments are then replaced with the `/* name= */ value` style, or Kotlin's named arguments. Some comments in DesktopModeEventLogger.kt and DesktopModeEventLoggerTest.kt are unchanged. This is because the proto binding generator gives arguments less meaningful names like `arg0`. Using `/* name= */ value` style comments with inconsistent names resulted in warnings in the IDE. Bug: None Test: None Flag: DOCS_ONLY Change-Id: I626ee944b13f99ccd4b23536c21fd1aac3ece08f
-rw-r--r--libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopImmersiveController.kt2
-rw-r--r--libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeEventLogger.kt2
-rw-r--r--libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeVisualIndicator.java4
-rw-r--r--libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksController.kt16
-rw-r--r--libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksLimiter.kt2
-rw-r--r--libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandler.kt20
-rw-r--r--libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/CloseDesktopTaskTransitionHandlerTest.kt2
-rw-r--r--libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopBackNavigationTransitionHandlerTest.kt2
-rw-r--r--libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopMixedTransitionHandlerTest.kt2
-rw-r--r--libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksControllerTest.kt58
-rw-r--r--libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksLimiterTest.kt44
-rw-r--r--libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksTransitionObserverTest.kt8
-rw-r--r--libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandlerTest.kt2
13 files changed, 82 insertions, 82 deletions
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopImmersiveController.kt b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopImmersiveController.kt
index 536dc2a58534..a4620d5a4dfe 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopImmersiveController.kt
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopImmersiveController.kt
@@ -339,7 +339,7 @@ class DesktopImmersiveController(
.setWindowCrop(leash, endBounds.width(), endBounds.height())
.apply()
onTaskResizeAnimationListener?.onAnimationEnd(taskId)
- finishCallback.onTransitionFinished(null /* wct */)
+ finishCallback.onTransitionFinished(/* wct= */ null)
}
)
addUpdateListener { animation ->
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeEventLogger.kt b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeEventLogger.kt
index ceef69969d9a..e8f9a789bb98 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeEventLogger.kt
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeEventLogger.kt
@@ -306,7 +306,7 @@ class DesktopModeEventLogger {
fun logTaskInfoStateInit() {
logTaskUpdate(
FrameworkStatsLog.DESKTOP_MODE_SESSION_TASK_UPDATE__TASK_EVENT__TASK_INIT_STATSD,
- /* session_id */ 0,
+ sessionId = 0,
TaskUpdate(
visibleTaskCount = 0,
instanceId = 0,
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeVisualIndicator.java b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeVisualIndicator.java
index cd37113666bb..32ee319a053b 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeVisualIndicator.java
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeVisualIndicator.java
@@ -274,7 +274,7 @@ public class DesktopModeVisualIndicator {
lp.inputFeatures |= INPUT_FEATURE_NO_INPUT_CHANNEL;
final WindowlessWindowManager windowManager = new WindowlessWindowManager(
mTaskInfo.configuration, mLeash,
- null /* hostInputToken */);
+ /* hostInputToken= */ null);
mViewHost = new SurfaceControlViewHost(mContext,
mDisplayController.getDisplay(mTaskInfo.displayId), windowManager,
"DesktopModeVisualIndicator");
@@ -338,7 +338,7 @@ public class DesktopModeVisualIndicator {
if (mCurrentType == NO_INDICATOR) {
fadeInIndicator(newType);
} else if (newType == NO_INDICATOR) {
- fadeOutIndicator(null /* finishCallback */);
+ fadeOutIndicator(/* finishCallback= */ null);
} else {
final VisualIndicatorAnimator animator = VisualIndicatorAnimator.animateIndicatorType(
mView, mDisplayController.getDisplayLayout(mTaskInfo.displayId), mCurrentType,
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksController.kt b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksController.kt
index 94955709bf79..4af92877e91e 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksController.kt
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksController.kt
@@ -758,7 +758,7 @@ class DesktopTasksController(
return
}
val wct = WindowContainerTransaction()
- wct.reorder(taskInfo.token, true /* onTop */, true /* includingParents */)
+ wct.reorder(taskInfo.token, /* onTop= */ true, /* includingParents= */ true)
startLaunchTransition(
transitionType = TRANSIT_TO_FRONT,
wct = wct,
@@ -880,7 +880,7 @@ class DesktopTasksController(
} else if (Flags.enableMoveToNextDisplayShortcut()) {
applyFreeformDisplayChange(wct, task, displayId)
}
- wct.reparent(task.token, displayAreaInfo.token, true /* onTop */)
+ wct.reparent(task.token, displayAreaInfo.token, /* onTop= */ true)
if (Flags.enableDisplayFocusInShellTransitions()) {
// Bring the destination display to top with includingParents=true, so that the
// destination display gains the display focus, which makes the top task in the display
@@ -892,7 +892,7 @@ class DesktopTasksController(
performDesktopExitCleanupIfNeeded(task.taskId, task.displayId, wct)
}
- transitions.startTransition(TRANSIT_CHANGE, wct, null /* handler */)
+ transitions.startTransition(TRANSIT_CHANGE, wct, /* handler= */ null)
}
/**
@@ -1645,7 +1645,7 @@ class DesktopTasksController(
requestedTaskId,
splitPosition,
options.toBundle(),
- null, /* hideTaskToken */
+ /* hideTaskToken= */ null,
)
}
}
@@ -1682,8 +1682,8 @@ class DesktopTasksController(
fillIn,
splitPosition,
options.toBundle(),
- null /* hideTaskToken */,
- true /* forceLaunchNewTask */,
+ /* hideTaskToken= */ null,
+ /* forceLaunchNewTask= */ true,
splitIndex,
)
}
@@ -1934,7 +1934,7 @@ class DesktopTasksController(
wct.setBounds(taskInfo.token, initialBounds)
}
wct.setWindowingMode(taskInfo.token, targetWindowingMode)
- wct.reorder(taskInfo.token, true /* onTop */)
+ wct.reorder(taskInfo.token, /* onTop= */ true)
if (useDesktopOverrideDensity()) {
wct.setDensityDpi(taskInfo.token, DESKTOP_DENSITY_OVERRIDE)
}
@@ -2757,7 +2757,7 @@ class DesktopTasksController(
controller,
"visibleTaskCount",
{ controller -> result[0] = controller.visibleTaskCount(displayId) },
- true, /* blocking */
+ /* blocking= */ true,
)
return result[0]
}
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksLimiter.kt b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksLimiter.kt
index 0330a5f0c4e7..c2dd4d28305b 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksLimiter.kt
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksLimiter.kt
@@ -234,7 +234,7 @@ class DesktopTasksLimiter(
// If it's a running task, reorder it to back.
taskIdToMinimize
?.let { shellTaskOrganizer.getRunningTaskInfo(it) }
- ?.let { wct.reorder(it.token, false /* onTop */) }
+ ?.let { wct.reorder(it.token, /* onTop= */ false) }
return taskIdToMinimize
}
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandler.kt b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandler.kt
index d23c9d0b8ffd..0410eb48f480 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandler.kt
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandler.kt
@@ -131,7 +131,7 @@ sealed class DragToDesktopTransitionHandler(
val pendingIntent =
PendingIntent.getActivityAsUser(
context.createContextAsUser(taskUser, /* flags= */ 0),
- 0 /* requestCode */,
+ /* requestCode= */ 0,
launchHomeIntent,
FLAG_MUTABLE or FLAG_ALLOW_UNSAFE_IMPLICIT_INTENT or FILL_IN_COMPONENT,
options.toBundle(),
@@ -234,7 +234,7 @@ sealed class DragToDesktopTransitionHandler(
val wct = WindowContainerTransaction()
restoreWindowOrder(wct, state)
state.startTransitionFinishTransaction?.apply()
- state.startTransitionFinishCb?.onTransitionFinished(null /* wct */)
+ state.startTransitionFinishCb?.onTransitionFinished(/* wct= */ null)
requestSplitFromScaledTask(splitPosition, wct)
clearState()
} else {
@@ -440,7 +440,7 @@ sealed class DragToDesktopTransitionHandler(
val wct = WindowContainerTransaction()
restoreWindowOrder(wct)
state.startTransitionFinishTransaction?.apply()
- state.startTransitionFinishCb?.onTransitionFinished(null /* wct */)
+ state.startTransitionFinishCb?.onTransitionFinished(/* wct= */ null)
requestSplitSelect(wct, taskInfo, splitPosition)
}
return true
@@ -492,7 +492,7 @@ sealed class DragToDesktopTransitionHandler(
finishTransaction = startTransactionFinishT,
)
// Call finishCallback to merge animation before startTransitionFinishCb is called
- finishCallback.onTransitionFinished(null /* wct */)
+ finishCallback.onTransitionFinished(/* wct= */ null)
animateEndDragToDesktop(startTransaction = t, startTransitionFinishCb)
} else if (isCancelTransition) {
info.changes.forEach { change ->
@@ -500,8 +500,8 @@ sealed class DragToDesktopTransitionHandler(
startTransactionFinishT.show(change.leash)
}
t.apply()
- finishCallback.onTransitionFinished(null /* wct */)
- startTransitionFinishCb.onTransitionFinished(null /* wct */)
+ finishCallback.onTransitionFinished(/* wct= */ null)
+ startTransitionFinishCb.onTransitionFinished(/* wct= */ null)
clearState()
}
}
@@ -653,7 +653,7 @@ sealed class DragToDesktopTransitionHandler(
interactionJankMonitor.cancel(CUJ_DESKTOP_MODE_ENTER_APP_HANDLE_DRAG_HOLD)
} else if (state.cancelTransitionToken == transition) {
state.draggedTaskChange?.leash?.let { state.startTransitionFinishTransaction?.show(it) }
- state.startTransitionFinishCb?.onTransitionFinished(null /* wct */)
+ state.startTransitionFinishCb?.onTransitionFinished(/* wct= */ null)
clearState()
} else {
// This transition being aborted is neither the start, nor the cancel transition, so
@@ -741,19 +741,19 @@ sealed class DragToDesktopTransitionHandler(
// TODO(b/322852244): investigate why even though these "other" tasks are
// reordered in front of home and behind the translucent dragged task, its
// surface is not visible on screen.
- wct.reorder(wc, true /* toTop */)
+ wct.reorder(wc, /* onTop= */ true)
}
val wc =
state.draggedTaskChange?.container
?: error("Dragged task should be non-null before cancelling")
// Then the dragged task a the very top.
- wct.reorder(wc, true /* toTop */)
+ wct.reorder(wc, /* onTop= */ true)
}
is TransitionState.FromSplit -> {
val wc =
state.splitRootChange?.container
?: error("Split root should be non-null before cancelling")
- wct.reorder(wc, true /* toTop */)
+ wct.reorder(wc, /* onTop= */ true)
}
}
val homeWc =
diff --git a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/CloseDesktopTaskTransitionHandlerTest.kt b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/CloseDesktopTaskTransitionHandlerTest.kt
index db00f41f723b..04f9ada8a9d7 100644
--- a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/CloseDesktopTaskTransitionHandlerTest.kt
+++ b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/CloseDesktopTaskTransitionHandlerTest.kt
@@ -142,7 +142,7 @@ class CloseDesktopTaskTransitionHandlerTest : ShellTestCase() {
changeMode: Int = WindowManager.TRANSIT_CLOSE,
task: RunningTaskInfo,
): TransitionInfo =
- TransitionInfo(type, 0 /* flags */).apply {
+ TransitionInfo(type, /* flags= */ 0).apply {
addChange(
TransitionInfo.Change(mock(), closingTaskLeash).apply {
mode = changeMode
diff --git a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopBackNavigationTransitionHandlerTest.kt b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopBackNavigationTransitionHandlerTest.kt
index d14c6402982d..c705f5a5ac87 100644
--- a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopBackNavigationTransitionHandlerTest.kt
+++ b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopBackNavigationTransitionHandlerTest.kt
@@ -153,7 +153,7 @@ class DesktopBackNavigationTransitionHandlerTest : ShellTestCase() {
changeMode: Int = WindowManager.TRANSIT_TO_BACK,
task: RunningTaskInfo,
): TransitionInfo =
- TransitionInfo(type, 0 /* flags */).apply {
+ TransitionInfo(type, /* flags= */ 0).apply {
addChange(
TransitionInfo.Change(mock(), closingTaskLeash).apply {
mode = changeMode
diff --git a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopMixedTransitionHandlerTest.kt b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopMixedTransitionHandlerTest.kt
index 3cf84d92a625..372e47ce6a17 100644
--- a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopMixedTransitionHandlerTest.kt
+++ b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopMixedTransitionHandlerTest.kt
@@ -777,7 +777,7 @@ class DesktopMixedTransitionHandlerTest : ShellTestCase() {
task: RunningTaskInfo,
withWallpaper: Boolean = false,
): TransitionInfo =
- TransitionInfo(WindowManager.TRANSIT_CLOSE, 0 /* flags */).apply {
+ TransitionInfo(WindowManager.TRANSIT_CLOSE, /* flags= */ 0).apply {
addChange(
TransitionInfo.Change(mock(), closingTaskLeash).apply {
mode = changeMode
diff --git a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksControllerTest.kt b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksControllerTest.kt
index 61aec739724a..aed3ac9a7bc5 100644
--- a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksControllerTest.kt
+++ b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksControllerTest.kt
@@ -1256,7 +1256,7 @@ class DesktopTasksControllerTest : ShellTestCase() {
// Set task as systemUI package
val systemUIPackageName =
context.resources.getString(com.android.internal.R.string.config_systemUi)
- val baseComponent = ComponentName(systemUIPackageName, /* class */ "")
+ val baseComponent = ComponentName(systemUIPackageName, /* cls= */ "")
val task =
setUpFullscreenTask().apply {
baseActivity = baseComponent
@@ -1273,7 +1273,7 @@ class DesktopTasksControllerTest : ShellTestCase() {
// Set task as systemUI package
val systemUIPackageName =
context.resources.getString(com.android.internal.R.string.config_systemUi)
- val baseComponent = ComponentName(systemUIPackageName, /* class */ "")
+ val baseComponent = ComponentName(systemUIPackageName, /* cls= */ "")
val task =
setUpFullscreenTask().apply {
baseActivity = baseComponent
@@ -2728,7 +2728,7 @@ class DesktopTasksControllerTest : ShellTestCase() {
// Set task as systemUI package
val systemUIPackageName =
context.resources.getString(com.android.internal.R.string.config_systemUi)
- val baseComponent = ComponentName(systemUIPackageName, /* class */ "")
+ val baseComponent = ComponentName(systemUIPackageName, /* cls= */ "")
val task =
setUpFreeformTask().apply {
baseActivity = baseComponent
@@ -2749,7 +2749,7 @@ class DesktopTasksControllerTest : ShellTestCase() {
// Set task as systemUI package
val systemUIPackageName =
context.resources.getString(com.android.internal.R.string.config_systemUi)
- val baseComponent = ComponentName(systemUIPackageName, /* class */ "")
+ val baseComponent = ComponentName(systemUIPackageName, /* cls= */ "")
val task =
setUpFullscreenTask().apply {
baseActivity = baseComponent
@@ -3382,11 +3382,11 @@ class DesktopTasksControllerTest : ShellTestCase() {
spyController.onDragPositioningEnd(
task,
mockSurface,
- Point(100, -100), /* position */
- PointF(200f, -200f), /* inputCoordinate */
- Rect(100, -100, 500, 1000), /* currentDragBounds */
- Rect(0, 50, 2000, 2000), /* validDragArea */
- Rect() /* dragStartBounds */,
+ position = Point(100, -100),
+ inputCoordinate = PointF(200f, -200f),
+ currentDragBounds = Rect(100, -100, 500, 1000),
+ validDragArea = Rect(0, 50, 2000, 2000),
+ dragStartBounds = Rect(),
motionEvent,
desktopWindowDecoration,
)
@@ -3421,11 +3421,11 @@ class DesktopTasksControllerTest : ShellTestCase() {
spyController.onDragPositioningEnd(
task,
mockSurface,
- Point(100, 200), /* position */
- PointF(200f, 300f), /* inputCoordinate */
- currentDragBounds, /* currentDragBounds */
- Rect(0, 50, 2000, 2000) /* validDragArea */,
- Rect() /* dragStartBounds */,
+ position = Point(100, 200),
+ inputCoordinate = PointF(200f, 300f),
+ currentDragBounds = currentDragBounds,
+ validDragArea = Rect(0, 50, 2000, 2000),
+ dragStartBounds = Rect(),
motionEvent,
desktopWindowDecoration,
)
@@ -3465,11 +3465,11 @@ class DesktopTasksControllerTest : ShellTestCase() {
spyController.onDragPositioningEnd(
task,
mockSurface,
- Point(100, 50), /* position */
- PointF(200f, 300f), /* inputCoordinate */
- Rect(100, 50, 500, 1000), /* currentDragBounds */
- Rect(0, 50, 2000, 2000) /* validDragArea */,
- Rect() /* dragStartBounds */,
+ position = Point(100, 50),
+ inputCoordinate = PointF(200f, 300f),
+ currentDragBounds = Rect(100, 50, 500, 1000),
+ validDragArea = Rect(0, 50, 2000, 2000),
+ dragStartBounds = Rect(),
motionEvent,
desktopWindowDecoration,
)
@@ -3504,11 +3504,11 @@ class DesktopTasksControllerTest : ShellTestCase() {
spyController.onDragPositioningEnd(
task,
mockSurface,
- Point(100, 50), /* position */
- PointF(200f, 300f), /* inputCoordinate */
+ position = Point(100, 50),
+ inputCoordinate = PointF(200f, 300f),
currentDragBounds,
- Rect(0, 50, 2000, 2000) /* validDragArea */,
- Rect() /* dragStartBounds */,
+ validDragArea = Rect(0, 50, 2000, 2000),
+ dragStartBounds = Rect(),
motionEvent,
desktopWindowDecoration,
)
@@ -3561,11 +3561,11 @@ class DesktopTasksControllerTest : ShellTestCase() {
spyController.onDragPositioningEnd(
task,
mockSurface,
- Point(100, 50), /* position */
- PointF(200f, 300f), /* inputCoordinate */
- currentDragBounds, /* currentDragBounds */
- Rect(0, 50, 2000, 2000) /* validDragArea */,
- Rect() /* dragStartBounds */,
+ position = Point(100, 50),
+ inputCoordinate = PointF(200f, 300f),
+ currentDragBounds = currentDragBounds,
+ validDragArea = Rect(0, 50, 2000, 2000),
+ dragStartBounds = Rect(),
motionEvent,
desktopWindowDecoration,
)
@@ -5062,7 +5062,7 @@ class DesktopTasksControllerTest : ShellTestCase() {
task: RunningTaskInfo?,
@WindowManager.TransitionType type: Int = TRANSIT_OPEN,
): TransitionRequestInfo {
- return TransitionRequestInfo(type, task, null /* remoteTransition */)
+ return TransitionRequestInfo(type, task, /* remoteTransition= */ null)
}
private companion object {
diff --git a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksLimiterTest.kt b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksLimiterTest.kt
index 52602f22fd4b..c8214b3838e2 100644
--- a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksLimiterTest.kt
+++ b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksLimiterTest.kt
@@ -193,10 +193,10 @@ class DesktopTasksLimiterTest : ShellTestCase() {
desktopTasksLimiter
.getTransitionObserver()
.onTransitionReady(
- Binder() /* transition */,
+ /* transition= */ Binder(),
TransitionInfoBuilder(TRANSIT_OPEN).addChange(TRANSIT_TO_BACK, task).build(),
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
assertThat(desktopTaskRepo.isMinimizedTask(taskId = task.taskId)).isFalse()
@@ -217,10 +217,10 @@ class DesktopTasksLimiterTest : ShellTestCase() {
desktopTasksLimiter
.getTransitionObserver()
.onTransitionReady(
- taskTransition /* transition */,
+ /* transition= */ taskTransition,
TransitionInfoBuilder(TRANSIT_OPEN).addChange(TRANSIT_TO_BACK, task).build(),
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
assertThat(desktopTaskRepo.isMinimizedTask(taskId = task.taskId)).isFalse()
@@ -242,8 +242,8 @@ class DesktopTasksLimiterTest : ShellTestCase() {
.onTransitionReady(
transition,
TransitionInfoBuilder(TRANSIT_OPEN).build(),
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
assertThat(desktopTaskRepo.isMinimizedTask(taskId = task.taskId)).isFalse()
@@ -265,8 +265,8 @@ class DesktopTasksLimiterTest : ShellTestCase() {
.onTransitionReady(
transition,
TransitionInfoBuilder(TRANSIT_OPEN).build(),
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
assertThat(desktopTaskRepo.isMinimizedTask(taskId = task.taskId)).isTrue()
@@ -287,8 +287,8 @@ class DesktopTasksLimiterTest : ShellTestCase() {
.onTransitionReady(
transition,
TransitionInfoBuilder(TRANSIT_OPEN).addChange(TRANSIT_TO_BACK, task).build(),
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
assertThat(desktopTaskRepo.isMinimizedTask(taskId = task.taskId)).isTrue()
@@ -316,8 +316,8 @@ class DesktopTasksLimiterTest : ShellTestCase() {
.onTransitionReady(
transition,
TransitionInfo(TRANSIT_OPEN, TransitionInfo.FLAG_NONE).apply { addChange(change) },
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
assertThat(desktopTaskRepo.isMinimizedTask(taskId = task.taskId)).isTrue()
@@ -344,8 +344,8 @@ class DesktopTasksLimiterTest : ShellTestCase() {
.onTransitionReady(
newTransition,
TransitionInfoBuilder(TRANSIT_OPEN).addChange(TRANSIT_TO_BACK, task).build(),
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
assertThat(desktopTaskRepo.isMinimizedTask(taskId = task.taskId)).isTrue()
@@ -552,8 +552,8 @@ class DesktopTasksLimiterTest : ShellTestCase() {
.onTransitionReady(
transition,
TransitionInfoBuilder(TRANSIT_OPEN).addChange(TRANSIT_TO_BACK, task).build(),
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
desktopTasksLimiter.getTransitionObserver().onTransitionStarting(transition)
@@ -584,8 +584,8 @@ class DesktopTasksLimiterTest : ShellTestCase() {
.onTransitionReady(
transition,
TransitionInfoBuilder(TRANSIT_OPEN).addChange(TRANSIT_TO_BACK, task).build(),
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
desktopTasksLimiter.getTransitionObserver().onTransitionStarting(transition)
@@ -617,8 +617,8 @@ class DesktopTasksLimiterTest : ShellTestCase() {
.onTransitionReady(
mergedTransition,
TransitionInfoBuilder(TRANSIT_OPEN).addChange(TRANSIT_TO_BACK, task).build(),
- StubTransaction() /* startTransaction */,
- StubTransaction(), /* finishTransaction */
+ /* startTransaction= */ StubTransaction(),
+ /* finishTransaction= */ StubTransaction(),
)
desktopTasksLimiter.getTransitionObserver().onTransitionStarting(mergedTransition)
diff --git a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksTransitionObserverTest.kt b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksTransitionObserverTest.kt
index c66d203fd89a..0044d2ecde2c 100644
--- a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksTransitionObserverTest.kt
+++ b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksTransitionObserverTest.kt
@@ -300,7 +300,7 @@ class DesktopTasksTransitionObserverTest {
type: Int = TRANSIT_TO_BACK,
withWallpaper: Boolean = false,
): TransitionInfo {
- return TransitionInfo(type, 0 /* flags */).apply {
+ return TransitionInfo(type, /* flags= */ 0).apply {
addChange(
Change(mock(), mock()).apply {
mode = type
@@ -326,7 +326,7 @@ class DesktopTasksTransitionObserverTest {
task: RunningTaskInfo?,
type: Int = TRANSIT_OPEN,
): TransitionInfo {
- return TransitionInfo(TRANSIT_OPEN, 0 /* flags */).apply {
+ return TransitionInfo(TRANSIT_OPEN, /* flags= */ 0).apply {
addChange(
Change(mock(), mock()).apply {
mode = TRANSIT_OPEN
@@ -339,7 +339,7 @@ class DesktopTasksTransitionObserverTest {
}
private fun createCloseTransition(task: RunningTaskInfo?): TransitionInfo {
- return TransitionInfo(TRANSIT_CLOSE, 0 /* flags */).apply {
+ return TransitionInfo(TRANSIT_CLOSE, /* flags= */ 0).apply {
addChange(
Change(mock(), mock()).apply {
mode = TRANSIT_CLOSE
@@ -352,7 +352,7 @@ class DesktopTasksTransitionObserverTest {
}
private fun createToBackTransition(task: RunningTaskInfo?): TransitionInfo {
- return TransitionInfo(TRANSIT_TO_BACK, 0 /* flags */).apply {
+ return TransitionInfo(TRANSIT_TO_BACK, /* flags= */ 0).apply {
addChange(
Change(mock(), mock()).apply {
mode = TRANSIT_TO_BACK
diff --git a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandlerTest.kt b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandlerTest.kt
index e4eff9f1d592..fad3d756fb6f 100644
--- a/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandlerTest.kt
+++ b/libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandlerTest.kt
@@ -677,7 +677,7 @@ class DragToDesktopTransitionHandlerTest : ShellTestCase() {
}
private fun createTransitionInfo(type: Int, draggedTask: RunningTaskInfo): TransitionInfo {
- return TransitionInfo(type, 0 /* flags */).apply {
+ return TransitionInfo(type, /* flags= */ 0).apply {
addChange( // Home.
TransitionInfo.Change(mock(), homeTaskLeash).apply {
parent = null