diff options
| author | 2022-06-06 21:40:49 +0000 | |
|---|---|---|
| committer | 2022-06-06 21:40:49 +0000 | |
| commit | 06e455018709b3a8ced50b21e02c2cbcff4707b0 (patch) | |
| tree | 6100b3b6e4c91bc03e2f2fec46376ba6fc1ebc61 | |
| parent | 92ce74409b095c3e653f91f2a5a77e57fe8cae66 (diff) | |
Parcel: warnings for 'REPLY' statuses
Comment a warning for this hack to add data into statuses. I've also
heard from jsharkey@ in the past a need for a generic solution here.
At a minimum, this prevents new bugs/bad interactions with native
code.
Bug: 235006086
Test: N/A
Change-Id: I3bcb2b8638803cde0f6ef257b65bb9456843abf7
| -rw-r--r-- | core/java/android/os/Parcel.java | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/core/java/android/os/Parcel.java b/core/java/android/os/Parcel.java index 08ab73b9dd92..524052241bbf 100644 --- a/core/java/android/os/Parcel.java +++ b/core/java/android/os/Parcel.java @@ -347,7 +347,15 @@ public final class Parcel { private static final int EX_SERVICE_SPECIFIC = -8; private static final int EX_PARCELABLE = -9; /** @hide */ + // WARNING: DO NOT add more 'reply' headers. These also need to add work to native + // code and this encodes extra information in object statuses. If we need to expand + // this design, we should add a generic way to attach parcelables/structured parcelables + // to transactions which can work across languages. public static final int EX_HAS_NOTED_APPOPS_REPLY_HEADER = -127; // special; see below + // WARNING: DO NOT add more 'reply' headers. These also need to add work to native + // code and this encodes extra information in object statuses. If we need to expand + // this design, we should add a generic way to attach parcelables/structured parcelables + // to transactions which can work across languages. private static final int EX_HAS_STRICTMODE_REPLY_HEADER = -128; // special; see below // EX_TRANSACTION_FAILED is used exclusively in native code. // see libbinder's binder/Status.h |