diff options
| author | 2020-09-28 10:24:39 +0000 | |
|---|---|---|
| committer | 2020-09-28 10:24:39 +0000 | |
| commit | 05c9d5d78d0eb387866b061a731c0f10d728fee5 (patch) | |
| tree | f7010e001766e47141e9f2f0ea82ac9b33018a59 | |
| parent | 7cbdbffe2b8e5419fbc2d2ac234fd61266a615b4 (diff) | |
| parent | 696e95fb137e90a99ec8c81f0492a741c5c1ee87 (diff) | |
Merge "Fix ignored HdmiCecLocalDevicePlaybackTest"
| -rw-r--r-- | services/core/java/com/android/server/hdmi/HdmiCecLocalDevicePlayback.java | 15 | ||||
| -rw-r--r-- | services/tests/servicestests/src/com/android/server/hdmi/HdmiCecLocalDevicePlaybackTest.java | 8 |
2 files changed, 1 insertions, 22 deletions
diff --git a/services/core/java/com/android/server/hdmi/HdmiCecLocalDevicePlayback.java b/services/core/java/com/android/server/hdmi/HdmiCecLocalDevicePlayback.java index f2f6dbe9bde5..6e6d848c2acc 100644 --- a/services/core/java/com/android/server/hdmi/HdmiCecLocalDevicePlayback.java +++ b/services/core/java/com/android/server/hdmi/HdmiCecLocalDevicePlayback.java @@ -58,11 +58,6 @@ public class HdmiCecLocalDevicePlayback extends HdmiCecLocalDeviceSource { // If true, turn off TV upon standby. False by default. private boolean mAutoTvOff; - // Local active port number used for Routing Control. - // Default 0 means HOME is the current active path. Temp solution only. - // TODO(amyjojo): adding system constants for input ports to TIF mapping. - private int mLocalActivePath = 0; - // Determines what action should be taken upon receiving Routing Control messages. @VisibleForTesting protected HdmiProperties.playback_device_action_on_routing_control_values @@ -438,16 +433,6 @@ public class HdmiCecLocalDevicePlayback extends HdmiCecLocalDeviceSource { checkIfPendingActionsCleared(); } - private void routeToPort(int portId) { - // TODO(AMYJOJO): route to specific input of the port - mLocalActivePath = portId; - } - - @VisibleForTesting - protected int getLocalActivePath() { - return mLocalActivePath; - } - @Override protected void dump(final IndentingPrintWriter pw) { super.dump(pw); diff --git a/services/tests/servicestests/src/com/android/server/hdmi/HdmiCecLocalDevicePlaybackTest.java b/services/tests/servicestests/src/com/android/server/hdmi/HdmiCecLocalDevicePlaybackTest.java index d160a3fab186..4d97a398032d 100644 --- a/services/tests/servicestests/src/com/android/server/hdmi/HdmiCecLocalDevicePlaybackTest.java +++ b/services/tests/servicestests/src/com/android/server/hdmi/HdmiCecLocalDevicePlaybackTest.java @@ -39,7 +39,6 @@ import androidx.test.InstrumentationRegistry; import androidx.test.filters.SmallTest; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; @@ -370,16 +369,11 @@ public class HdmiCecLocalDevicePlaybackTest { assertThat(mStandby).isFalse(); } - // Playback device does not handle routing control related feature right now - @Ignore("b/120845532") @Test - public void handleSetStreamPath_underCurrentDevice() { - assertThat(mHdmiCecLocalDevicePlayback.getLocalActivePath()).isEqualTo(0); + public void handleSetStreamPath() { HdmiCecMessage message = HdmiCecMessageBuilder.buildSetStreamPath(ADDR_TV, 0x2100); assertThat(mHdmiCecLocalDevicePlayback.handleSetStreamPath(message)).isTrue(); - // TODO(amyjojo): Move set and get LocalActivePath to Control Service. - assertThat(mHdmiCecLocalDevicePlayback.getLocalActivePath()).isEqualTo(1); } @Test |