diff options
| author | 2024-02-27 00:03:25 +0000 | |
|---|---|---|
| committer | 2024-02-27 00:03:25 +0000 | |
| commit | 05a19f506165641c0cdd97d835c5d28a7ac0902e (patch) | |
| tree | e7e6cc278b885930073bbedf796fb55bfeec13a2 | |
| parent | 42856d04f32b549888dda86e735232f7242f0e4b (diff) | |
| parent | 17d0b1ef6c605a239e0dc1a71048d55a604a6275 (diff) | |
Merge "Clean up and update ClientController TODOs" into main
| -rw-r--r-- | services/core/java/com/android/server/inputmethod/ClientController.java | 28 | ||||
| -rw-r--r-- | services/core/java/com/android/server/inputmethod/InputMethodManagerService.java | 2 | 
2 files changed, 2 insertions, 28 deletions
| diff --git a/services/core/java/com/android/server/inputmethod/ClientController.java b/services/core/java/com/android/server/inputmethod/ClientController.java index 86f4db959409..0381a317de5f 100644 --- a/services/core/java/com/android/server/inputmethod/ClientController.java +++ b/services/core/java/com/android/server/inputmethod/ClientController.java @@ -33,36 +33,10 @@ import java.util.List;  import java.util.function.Consumer;  /** - * Store and manage {@link InputMethodManagerService} clients. This class was designed to be a - * singleton in {@link InputMethodManagerService} since it stores information about all clients, - * still the current client will be defined per display. - * - * <p> - * As part of the re-architecture plan (described in go/imms-rearchitecture-plan), the following - * fields and methods will be moved out from IMMS and placed here: - * <ul> - * <li>mClients (ArrayMap of ClientState indexed by IBinder)</li> - * </ul> - * <p> - * Nested Classes (to move from IMMS): - * <ul> - * <li>ClientDeathRecipient</li> - * <li>ClientState<</li> - * </ul> - * <p> - * Methods to rewrite and/or extract from IMMS and move here: - * <ul> - * <li>addClient</li> - * <li>removeClient</li> - * <li>verifyClientAndPackageMatch</li> - * <li>setImeTraceEnabledForAllClients (make it reactive)</li> - * </ul> + * Store and manage {@link InputMethodManagerService} clients.   */ -// TODO(b/314150112): Update the Javadoc above, by removing the re-architecture steps, once this -//  class is finalized  final class ClientController { -    // TODO(b/314150112): Make this field private when breaking the cycle with IMMS.      @GuardedBy("ImfLock.class")      private final ArrayMap<IBinder, ClientState> mClients = new ArrayMap<>(); diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java index 76956c88695d..307b70a89634 100644 --- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java +++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java @@ -2193,7 +2193,7 @@ public final class InputMethodManagerService extends IInputMethodManager.Stub          }      } -    // TODO(b/314150112): Move this method to InputMethodBindingController +    // TODO(b/325515685): Move this method to InputMethodBindingController      /**       * Hide the IME if the removed user is the current user.       */ |