diff options
author | 2025-02-18 13:28:21 -0800 | |
---|---|---|
committer | 2025-02-24 13:17:32 -0800 | |
commit | 051b787c41866a4c9a16bca767b144fbf121276e (patch) | |
tree | d55cda845ad1edcf65af1c7a79036fae8dbb0431 | |
parent | 6a91d1399e1185f7eb9c31c6aca498b31bf916e7 (diff) |
Cleaned up the flag enforce_telephony_feature_mapping_for_public_apis
Cleaned up the 24Q3 flag enforce_telephony_feature_mapping_for_public_apis
Test: Basic telephony functionality tests
Test: atest FrameworksTelephonyTests
Bug: 297989574
Flag: EXEMPT flag cleanup
Change-Id: If41ad237f55baa9df032564a5316d216e9d5838b
4 files changed, 20 insertions, 41 deletions
diff --git a/location/java/com/android/internal/location/GpsNetInitiatedHandler.java b/location/java/com/android/internal/location/GpsNetInitiatedHandler.java index 8b6194fa66f5..fb89973bcc11 100644 --- a/location/java/com/android/internal/location/GpsNetInitiatedHandler.java +++ b/location/java/com/android/internal/location/GpsNetInitiatedHandler.java @@ -28,7 +28,6 @@ import android.telephony.emergency.EmergencyNumber; import android.util.Log; import com.android.internal.annotations.KeepForWeakReference; -import com.android.internal.telephony.flags.Flags; import java.util.concurrent.TimeUnit; @@ -146,17 +145,12 @@ public class GpsNetInitiatedHandler { < emergencyExtensionMillis); boolean isInEmergencyCallback = false; boolean isInEmergencySmsMode = false; - if (!Flags.enforceTelephonyFeatureMappingForPublicApis()) { + PackageManager pm = mContext.getPackageManager(); + if (pm != null && pm.hasSystemFeature(PackageManager.FEATURE_TELEPHONY_CALLING)) { isInEmergencyCallback = mTelephonyManager.getEmergencyCallbackMode(); + } + if (pm != null && pm.hasSystemFeature(PackageManager.FEATURE_TELEPHONY_MESSAGING)) { isInEmergencySmsMode = mTelephonyManager.isInEmergencySmsMode(); - } else { - PackageManager pm = mContext.getPackageManager(); - if (pm != null && pm.hasSystemFeature(PackageManager.FEATURE_TELEPHONY_CALLING)) { - isInEmergencyCallback = mTelephonyManager.getEmergencyCallbackMode(); - } - if (pm != null && pm.hasSystemFeature(PackageManager.FEATURE_TELEPHONY_MESSAGING)) { - isInEmergencySmsMode = mTelephonyManager.isInEmergencySmsMode(); - } } return mIsInEmergencyCall || isInEmergencyCallback || isInEmergencyExtension || isInEmergencySmsMode; diff --git a/services/core/java/com/android/server/TelephonyRegistry.java b/services/core/java/com/android/server/TelephonyRegistry.java index bd7a0ac55117..b75b7ddf8181 100644 --- a/services/core/java/com/android/server/TelephonyRegistry.java +++ b/services/core/java/com/android/server/TelephonyRegistry.java @@ -2816,13 +2816,11 @@ public class TelephonyRegistry extends ITelephonyRegistry.Stub { if (!checkNotifyPermission("notifyEmergencyNumberList()")) { return; } - if (Flags.enforceTelephonyFeatureMappingForPublicApis()) { - if (!mContext.getPackageManager().hasSystemFeature( - PackageManager.FEATURE_TELEPHONY_CALLING)) { - // TelephonyManager.getEmergencyNumberList() throws an exception if - // FEATURE_TELEPHONY_CALLING is not defined. - return; - } + if (!mContext.getPackageManager().hasSystemFeature( + PackageManager.FEATURE_TELEPHONY_CALLING)) { + // TelephonyManager.getEmergencyNumberList() throws an exception if + // FEATURE_TELEPHONY_CALLING is not defined. + return; } synchronized (mRecords) { diff --git a/services/core/java/com/android/server/pm/UserManagerService.java b/services/core/java/com/android/server/pm/UserManagerService.java index c7737e9f8bbd..c1ebc736d492 100644 --- a/services/core/java/com/android/server/pm/UserManagerService.java +++ b/services/core/java/com/android/server/pm/UserManagerService.java @@ -2937,28 +2937,20 @@ public class UserManagerService extends IUserManager.Stub { int flags = UserManager.SWITCHABILITY_STATUS_OK; - t.traceBegin("TM.isInCall"); - final long identity = Binder.clearCallingIdentity(); - try { - final TelecomManager telecomManager = mContext.getSystemService(TelecomManager.class); - if (com.android.internal.telephony.flags - .Flags.enforceTelephonyFeatureMappingForPublicApis()) { - if (mContext.getPackageManager().hasSystemFeature( - PackageManager.FEATURE_TELECOM)) { - if (telecomManager != null && telecomManager.isInCall()) { - flags |= UserManager.SWITCHABILITY_STATUS_USER_IN_CALL; - } - } - } else { + if (mContext.getPackageManager().hasSystemFeature(PackageManager.FEATURE_TELECOM)) { + t.traceBegin("TM.isInCall"); + final long identity = Binder.clearCallingIdentity(); + try { + final TelecomManager telecomManager = mContext.getSystemService( + TelecomManager.class); if (telecomManager != null && telecomManager.isInCall()) { flags |= UserManager.SWITCHABILITY_STATUS_USER_IN_CALL; } + } finally { + Binder.restoreCallingIdentity(identity); } - } finally { - Binder.restoreCallingIdentity(identity); + t.traceEnd(); } - t.traceEnd(); - t.traceBegin("hasUserRestriction-DISALLOW_USER_SWITCH"); if (mLocalService.hasUserRestriction(DISALLOW_USER_SWITCH, userId)) { flags |= UserManager.SWITCHABILITY_STATUS_USER_SWITCH_DISALLOWED; diff --git a/telephony/java/android/telephony/euicc/EuiccManager.java b/telephony/java/android/telephony/euicc/EuiccManager.java index ca4a643d7b20..ae7346eb6df4 100644 --- a/telephony/java/android/telephony/euicc/EuiccManager.java +++ b/telephony/java/android/telephony/euicc/EuiccManager.java @@ -1737,13 +1737,8 @@ public class EuiccManager { private int getCardIdForDefaultEuicc() { int cardId = TelephonyManager.UNINITIALIZED_CARD_ID; - if (Flags.enforceTelephonyFeatureMappingForPublicApis()) { - PackageManager pm = mContext.getPackageManager(); - if (pm != null && pm.hasSystemFeature(PackageManager.FEATURE_TELEPHONY_EUICC)) { - TelephonyManager tm = mContext.getSystemService(TelephonyManager.class); - cardId = tm.getCardIdForDefaultEuicc(); - } - } else { + PackageManager pm = mContext.getPackageManager(); + if (pm != null && pm.hasSystemFeature(PackageManager.FEATURE_TELEPHONY_EUICC)) { TelephonyManager tm = mContext.getSystemService(TelephonyManager.class); cardId = tm.getCardIdForDefaultEuicc(); } |