diff options
| author | 2023-12-14 17:34:27 +0000 | |
|---|---|---|
| committer | 2023-12-14 17:34:27 +0000 | |
| commit | 0368d533a1ca5c3c2b47a1fe2c6e93a0774909b7 (patch) | |
| tree | 2358eadc59375f9d27090e638b287eb59cf60629 | |
| parent | 2ed24ae0a58c98b7dfd46be3dcaea95eae388217 (diff) | |
| parent | 991684d6001c9407fbe08c11249ec5743153f482 (diff) | |
Merge "Require non-null arguments for AutomaticZenRule.Builder constructor" into main
| -rw-r--r-- | core/java/android/app/AutomaticZenRule.java | 4 | ||||
| -rw-r--r-- | core/tests/coretests/src/android/app/AutomaticZenRuleTest.java | 9 |
2 files changed, 11 insertions, 2 deletions
diff --git a/core/java/android/app/AutomaticZenRule.java b/core/java/android/app/AutomaticZenRule.java index 53a21cdd78c9..343348b89625 100644 --- a/core/java/android/app/AutomaticZenRule.java +++ b/core/java/android/app/AutomaticZenRule.java @@ -645,8 +645,8 @@ public final class AutomaticZenRule implements Parcelable { } public Builder(@NonNull String name, @NonNull Uri conditionId) { - mName = name; - mConditionId = conditionId; + mName = Objects.requireNonNull(name); + mConditionId = Objects.requireNonNull(conditionId); } /** diff --git a/core/tests/coretests/src/android/app/AutomaticZenRuleTest.java b/core/tests/coretests/src/android/app/AutomaticZenRuleTest.java index d629f6a8c57c..1925588e8904 100644 --- a/core/tests/coretests/src/android/app/AutomaticZenRuleTest.java +++ b/core/tests/coretests/src/android/app/AutomaticZenRuleTest.java @@ -166,6 +166,15 @@ public class AutomaticZenRuleTest { @Test @EnableFlags(Flags.FLAG_MODES_API) + public void builderConstructor_nullInputs_throws() { + assertThrows(NullPointerException.class, + () -> new AutomaticZenRule.Builder(null, Uri.parse("condition"))); + assertThrows(NullPointerException.class, + () -> new AutomaticZenRule.Builder("name", null)); + } + + @Test + @EnableFlags(Flags.FLAG_MODES_API) public void validate_builderWithValidType_succeeds() throws Exception { AutomaticZenRule rule = new AutomaticZenRule.Builder("rule", Uri.parse("uri")) .setType(AutomaticZenRule.TYPE_BEDTIME) |