diff options
| author | 2018-11-19 10:53:04 -0800 | |
|---|---|---|
| committer | 2018-11-19 10:53:04 -0800 | |
| commit | 026d70ba45832acac08d76ec962ec00dad2b9f82 (patch) | |
| tree | 2538a6aa5332929c3a4c358c70cd16a5f6581e89 | |
| parent | e9f5e860547e7314c4c0e03fa4838c5b06164f5d (diff) | |
Do not use both "virtual" and "override".
C++'s "override" keyword implies "virtual". When "virtual" and
"override" are both specified it means something slightly different from
just "override", which is what was intended here.
I teach the C++11 class here at Google. I asked the C++ arbitors to help
me understand this difference. They warned that it is dangerous and not
worth knowing. But that it is worth avoiding.
Test: Tested on local device -- no noticable change.
BUG=115613038
Change-Id: I372821053755fc4cbb1d001b71af7f02dffde5b2
| -rw-r--r-- | libs/hwui/pipeline/skia/GLFunctorDrawable.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libs/hwui/pipeline/skia/GLFunctorDrawable.h b/libs/hwui/pipeline/skia/GLFunctorDrawable.h index dd6ef25f30c5..b06f7f029f23 100644 --- a/libs/hwui/pipeline/skia/GLFunctorDrawable.h +++ b/libs/hwui/pipeline/skia/GLFunctorDrawable.h @@ -38,7 +38,7 @@ public: void syncFunctor() const override; protected: - virtual void onDraw(SkCanvas* canvas) override; + void onDraw(SkCanvas* canvas) override; }; }; // namespace skiapipeline |