summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Svetoslav Ganov <svetoslavganov@google.com> 2016-05-10 18:52:15 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2016-05-10 18:52:17 +0000
commit01da140aced14162d6d1bf4a0b2bf33e23b9c2c4 (patch)
tree2d55be474cd6b5c94195b85843d609d2687b9e17
parent0158baf9fb7017b40c804528f622ab86c35a2b9c (diff)
parent7e01af424355b5bbac64126fef4e3d37c9c41dd7 (diff)
Merge "Don't throw runtime exceptions for permission flags" into nyc-dev
-rw-r--r--packages/SettingsLib/src/com/android/settingslib/applications/ApplicationsState.java2
-rw-r--r--services/core/java/com/android/server/pm/PackageManagerService.java6
2 files changed, 4 insertions, 4 deletions
diff --git a/packages/SettingsLib/src/com/android/settingslib/applications/ApplicationsState.java b/packages/SettingsLib/src/com/android/settingslib/applications/ApplicationsState.java
index 9aaddaa66cfa..6d6a4b55bd93 100644
--- a/packages/SettingsLib/src/com/android/settingslib/applications/ApplicationsState.java
+++ b/packages/SettingsLib/src/com/android/settingslib/applications/ApplicationsState.java
@@ -646,7 +646,7 @@ public class ApplicationsState {
if (DEBUG) Log.i(TAG, "Rebuilding...");
for (int i=0; i<apps.size(); i++) {
AppEntry entry = apps.get(i);
- if (filter == null || filter.filterApp(entry)) {
+ if (entry != null && (filter == null || filter.filterApp(entry))) {
synchronized (mEntriesMap) {
if (DEBUG_LOCKING) Log.v(TAG, "rebuild acquired lock");
if (comparator != null) {
diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java
index 311876dc1684..4e48e4d7f6d6 100644
--- a/services/core/java/com/android/server/pm/PackageManagerService.java
+++ b/services/core/java/com/android/server/pm/PackageManagerService.java
@@ -4265,17 +4265,17 @@ public class PackageManagerService extends IPackageManager.Stub {
synchronized (mPackages) {
final PackageParser.Package pkg = mPackages.get(packageName);
if (pkg == null) {
- throw new IllegalArgumentException("Unknown package: " + packageName);
+ return 0;
}
final BasePermission bp = mSettings.mPermissions.get(name);
if (bp == null) {
- throw new IllegalArgumentException("Unknown permission: " + name);
+ return 0;
}
SettingBase sb = (SettingBase) pkg.mExtras;
if (sb == null) {
- throw new IllegalArgumentException("Unknown package: " + packageName);
+ return 0;
}
PermissionsState permissionsState = sb.getPermissionsState();