summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Phil Elwell <phil@raspberrypi.org> 2014-10-17 23:22:11 +0100
committer David Gibson <david@gibson.dropbear.id.au> 2014-10-24 11:45:41 +0200
commit242c2642709436ceb144f9949868ff54050c70a2 (patch)
tree4f3ee2729048bcc1fbd8081ccf05af4133975f41
parent6a76a9d30c977c6c9cb18cf15ba3bd2c2e89db4c (diff)
Improve portability
1) Remove the double parentheses around two comparisons in checks.c. The OSX LLVM-based C compiler warns about them. 2) Put an explicit "=" in the TN() macro, in accordance with c99. Signed-off-by: Phil Elwell <phil@raspberrypi.org>
-rw-r--r--checks.c4
-rw-r--r--fdtdump.c2
2 files changed, 3 insertions, 3 deletions
diff --git a/checks.c b/checks.c
index 47eda65..3bf0fa4 100644
--- a/checks.c
+++ b/checks.c
@@ -624,11 +624,11 @@ static void check_avoid_default_addr_size(struct check *c, struct node *dt,
if (!reg && !ranges)
return;
- if ((node->parent->addr_cells == -1))
+ if (node->parent->addr_cells == -1)
FAIL(c, "Relying on default #address-cells value for %s",
node->fullpath);
- if ((node->parent->size_cells == -1))
+ if (node->parent->size_cells == -1)
FAIL(c, "Relying on default #size-cells value for %s",
node->fullpath);
}
diff --git a/fdtdump.c b/fdtdump.c
index a29aa5e..95a6a20 100644
--- a/fdtdump.c
+++ b/fdtdump.c
@@ -22,7 +22,7 @@
static const char *tagname(uint32_t tag)
{
static const char * const names[] = {
-#define TN(t) [t] #t
+#define TN(t) [t] = #t
TN(FDT_BEGIN_NODE),
TN(FDT_END_NODE),
TN(FDT_PROP),