From 64aeaaddef14cf83a6ffeca5c683a989c07fda7d Mon Sep 17 00:00:00 2001 From: Martin Stjernholm Date: Wed, 13 May 2020 22:11:40 +0100 Subject: Fix special case when appending a visibility rule to //visibility:private. Test: m nothing Bug: 151303681 Change-Id: Ibe7e953219e4660c653063e87cb08407a2cb513d --- sdk/sdk_test.go | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'sdk/sdk_test.go') diff --git a/sdk/sdk_test.go b/sdk/sdk_test.go index 9bbf410b7..56be7417b 100644 --- a/sdk/sdk_test.go +++ b/sdk/sdk_test.go @@ -103,6 +103,7 @@ func TestSnapshotVisibility(t *testing.T) { "myjavalib", "mypublicjavalib", "mydefaultedjavalib", + "myprivatejavalib", ], } @@ -140,6 +141,14 @@ func TestSnapshotVisibility(t *testing.T) { system_modules: "none", sdk_version: "none", } + + java_library { + name: "myprivatejavalib", + srcs: ["Test.java"], + visibility: ["//visibility:private"], + system_modules: "none", + sdk_version: "none", + } ` result := testSdkWithFs(t, ``, @@ -206,6 +215,20 @@ java_import { jars: ["java/mydefaultedjavalib.jar"], } +java_import { + name: "mysdk_myprivatejavalib@current", + sdk_member_name: "myprivatejavalib", + visibility: ["//package"], + jars: ["java/myprivatejavalib.jar"], +} + +java_import { + name: "myprivatejavalib", + prefer: false, + visibility: ["//package"], + jars: ["java/myprivatejavalib.jar"], +} + sdk_snapshot { name: "mysdk@current", visibility: [ @@ -216,6 +239,7 @@ sdk_snapshot { "mysdk_myjavalib@current", "mysdk_mypublicjavalib@current", "mysdk_mydefaultedjavalib@current", + "mysdk_myprivatejavalib@current", ], } `)) -- cgit v1.2.3-59-g8ed1b