From 8bb10e8f8a72e6f6e87e9812dacb3816a37c7ed5 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Thu, 7 Jun 2018 16:46:02 -0700 Subject: Add a script to inject values into manifests Add a script that can inject a into AndroidManifest.xml files. This will help with merging LOCAL_STATIC_ANDROID_LIBRARIES, because ManifestMerger treats a missing minSdkVersion as minSdkVersion=1 and throws errors if libraries use a larger minSdkVersion. It will also help with cases where an app has a manifest that specifies an old minSdkVersion, but the build system is compiling the app in a way that is not compatibile with old devices, for example using a newer dex format. Bug: 110167203 Test: m java Test: build/soong/scripts/manifest_fixer_test.py Change-Id: I528d71a225feb86464c530e11b223babb0ea9edf --- scripts/manifest_fixer_test.py | 162 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 162 insertions(+) create mode 100755 scripts/manifest_fixer_test.py (limited to 'scripts/manifest_fixer_test.py') diff --git a/scripts/manifest_fixer_test.py b/scripts/manifest_fixer_test.py new file mode 100755 index 000000000..ccfa8fbe9 --- /dev/null +++ b/scripts/manifest_fixer_test.py @@ -0,0 +1,162 @@ +#!/usr/bin/env python +# +# Copyright (C) 2018 The Android Open Source Project +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +"""Unit tests for manifest_fixer_test.py.""" + +import StringIO +import sys +import unittest +from xml.dom import minidom + +import manifest_fixer + +sys.dont_write_bytecode = True + + +class CompareVersionGtTest(unittest.TestCase): + """Unit tests for compare_version_gt function.""" + + def test_sdk(self): + """Test comparing sdk versions.""" + self.assertTrue(manifest_fixer.compare_version_gt('28', '27')) + self.assertFalse(manifest_fixer.compare_version_gt('27', '28')) + self.assertFalse(manifest_fixer.compare_version_gt('28', '28')) + + def test_codename(self): + """Test comparing codenames.""" + self.assertTrue(manifest_fixer.compare_version_gt('Q', 'P')) + self.assertFalse(manifest_fixer.compare_version_gt('P', 'Q')) + self.assertFalse(manifest_fixer.compare_version_gt('Q', 'Q')) + + def test_sdk_codename(self): + """Test comparing sdk versions with codenames.""" + self.assertTrue(manifest_fixer.compare_version_gt('Q', '28')) + self.assertFalse(manifest_fixer.compare_version_gt('28', 'Q')) + + def test_compare_numeric(self): + """Test that numbers are compared in numeric and not lexicographic order.""" + self.assertTrue(manifest_fixer.compare_version_gt('18', '8')) + + +class RaiseMinSdkVersionTest(unittest.TestCase): + """Unit tests for raise_min_sdk_version function.""" + + def raise_min_sdk_version_test(self, input_manifest, min_sdk_version): + doc = minidom.parseString(input_manifest) + manifest_fixer.raise_min_sdk_version(doc, min_sdk_version) + output = StringIO.StringIO() + manifest_fixer.write_xml(output, doc) + return output.getvalue() + + manifest_tmpl = ( + '\n' + '\n' + '%s' + '\n') + + def uses_sdk(self, v, extra=''): + if extra: + extra = ' ' + extra + return ' \n' % (v, extra) + + def test_no_uses_sdk(self): + """Tests inserting a uses-sdk element into a manifest.""" + + manifest_input = self.manifest_tmpl % '' + expected = self.manifest_tmpl % self.uses_sdk('28') + output = self.raise_min_sdk_version_test(manifest_input, '28') + self.assertEqual(output, expected) + + def test_no_min(self): + """Tests inserting a minSdkVersion attribute into a uses-sdk element.""" + + manifest_input = self.manifest_tmpl % ' \n' + expected = self.manifest_tmpl % self.uses_sdk('28', 'extra="foo"') + output = self.raise_min_sdk_version_test(manifest_input, '28') + self.assertEqual(output, expected) + + def test_raise_min(self): + """Tests inserting a minSdkVersion attribute into a uses-sdk element.""" + + manifest_input = self.manifest_tmpl % self.uses_sdk('27') + expected = self.manifest_tmpl % self.uses_sdk('28') + output = self.raise_min_sdk_version_test(manifest_input, '28') + self.assertEqual(output, expected) + + def test_raise(self): + """Tests raising a minSdkVersion attribute.""" + + manifest_input = self.manifest_tmpl % self.uses_sdk('27') + expected = self.manifest_tmpl % self.uses_sdk('28') + output = self.raise_min_sdk_version_test(manifest_input, '28') + self.assertEqual(output, expected) + + def test_no_raise_min(self): + """Tests a minSdkVersion that doesn't need raising.""" + + manifest_input = self.manifest_tmpl % self.uses_sdk('28') + expected = manifest_input + output = self.raise_min_sdk_version_test(manifest_input, '27') + self.assertEqual(output, expected) + + def test_raise_codename(self): + """Tests raising a minSdkVersion attribute to a codename.""" + + manifest_input = self.manifest_tmpl % self.uses_sdk('28') + expected = self.manifest_tmpl % self.uses_sdk('P') + output = self.raise_min_sdk_version_test(manifest_input, 'P') + self.assertEqual(output, expected) + + def test_no_raise_codename(self): + """Tests a minSdkVersion codename that doesn't need raising.""" + + manifest_input = self.manifest_tmpl % self.uses_sdk('P') + expected = manifest_input + output = self.raise_min_sdk_version_test(manifest_input, '28') + self.assertEqual(output, expected) + + def test_extra(self): + """Tests that extra attributes and elements are maintained.""" + + manifest_input = self.manifest_tmpl % ( + ' \n' + ' \n' + ' \n') + + expected = self.manifest_tmpl % ( + ' \n' + ' \n' + ' \n') + + output = self.raise_min_sdk_version_test(manifest_input, '28') + + self.assertEqual(output, expected) + + def test_indent(self): + """Tests that an inserted element copies the existing indentation.""" + + manifest_input = self.manifest_tmpl % ' \n' + + expected = self.manifest_tmpl % ( + ' \n' + ' \n') + + output = self.raise_min_sdk_version_test(manifest_input, '28') + + self.assertEqual(output, expected) + +if __name__ == '__main__': + unittest.main() -- cgit v1.2.3-59-g8ed1b