From 012cfd094c7de9203ef801745ba4ae45eb036196 Mon Sep 17 00:00:00 2001 From: Nick Kralevich Date: Tue, 11 Mar 2025 09:33:06 -0700 Subject: manifest_check.py: Clarify that ordering matters When comparing the library declaration from AndroidManifest.xml and Android.bp, the library ordering must match (see b/132357300#comment3). The error message does not make it clear that ordering is significant and a mismatch in ordering is an error. Improve the error message to make this more obvious. Bug: 401287317 Test: compiles Change-Id: Idfb3e1e96893f81190dc320c49d40677b76f9853 --- scripts/manifest_check.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scripts/manifest_check.py') diff --git a/scripts/manifest_check.py b/scripts/manifest_check.py index 175451e74..96dc5a6ce 100755 --- a/scripts/manifest_check.py +++ b/scripts/manifest_check.py @@ -132,7 +132,7 @@ def enforce_uses_libraries(manifest, required, optional, missing_optional, relax #pylint: disable=line-too-long errmsg = ''.join([ - 'mismatch in the tags between the build system and the ' + 'mismatch or misordering in the tags between the build system and the ' 'manifest:\n', '\t- required libraries in build system: %s[%s]%s\n' % (C_RED, ', '.join(required), C_OFF), '\t vs. in the manifest: %s[%s]%s\n' % (C_RED, ', '.join(manifest_required), C_OFF), -- cgit v1.2.3-59-g8ed1b