From a0cd8f9acb8c5c04c1082cc980cc8cca28aff5a9 Mon Sep 17 00:00:00 2001 From: Ivan Lozano Date: Thu, 9 Apr 2020 09:56:02 -0400 Subject: Add gcov coverage support to Rust modules. This adds gcov coverage support for Rust device library and binary modules (including test modules). Support is provided to pass Rust static library gcno files to CC modules and visa versa. Additional changes: * Begin mutator added for Rust modules. * SuffixInList added to android package. * CoverageEnabled added to Coverage interface. * CoverageFiles added to LinkableLibrary interface. * Fix in coverage mutator for non-CC modules which marked the wrong variant as the coverage variant. * Added coverage libraries to the cc.GatherRequiredDepsForTest. Bug: 146448203 Test: NATIVE_COVERAGE=true COVERAGE_PATHS='*' m -j Change-Id: If20728bdde42a1dd544a35a40f0d981b80a5835f --- rust/coverage_test.go | 181 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 181 insertions(+) create mode 100644 rust/coverage_test.go (limited to 'rust/coverage_test.go') diff --git a/rust/coverage_test.go b/rust/coverage_test.go new file mode 100644 index 000000000..27acad325 --- /dev/null +++ b/rust/coverage_test.go @@ -0,0 +1,181 @@ +// Copyright 2020 The Android Open Source Project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package rust + +import ( + "strings" + "testing" + + "android/soong/android" +) + +// Test that coverage flags are being correctly generated. +func TestCoverageFlags(t *testing.T) { + ctx := testRustCov(t, ` + rust_library { + name: "libfoo_cov", + srcs: ["foo.rs"], + crate_name: "foo", + } + rust_binary { + name: "fizz_cov", + srcs: ["foo.rs"], + } + rust_binary { + name: "buzzNoCov", + srcs: ["foo.rs"], + native_coverage: false, + } + rust_library { + name: "libbar_nocov", + srcs: ["foo.rs"], + crate_name: "bar", + native_coverage: false, + }`) + + // Make sure native_coverage: false isn't creating a coverage variant. + if android.InList("android_arm64_armv8-a_dylib_cov", ctx.ModuleVariantsForTests("libbar_nocov")) { + t.Fatalf("coverage variant created for module 'libbar_nocov' with native coverage disabled") + } + + // Just test the dylib variants unless the library coverage logic changes to distinguish between the types. + libfooCov := ctx.ModuleForTests("libfoo_cov", "android_arm64_armv8-a_dylib_cov").Rule("rustc") + libbarNoCov := ctx.ModuleForTests("libbar_nocov", "android_arm64_armv8-a_dylib").Rule("rustc") + fizzCov := ctx.ModuleForTests("fizz_cov", "android_arm64_armv8-a_cov").Rule("rustc") + buzzNoCov := ctx.ModuleForTests("buzzNoCov", "android_arm64_armv8-a").Rule("rustc") + + rustcCoverageFlags := []string{"-Z profile", " -g ", "-C opt-level=0", "-C link-dead-code", "-Z no-landing-pads"} + for _, flag := range rustcCoverageFlags { + missingErrorStr := "missing rustc flag '%s' for '%s' module with coverage enabled; rustcFlags: %#v" + containsErrorStr := "contains rustc flag '%s' for '%s' module with coverage disabled; rustcFlags: %#v" + + if !strings.Contains(fizzCov.Args["rustcFlags"], flag) { + t.Fatalf(missingErrorStr, flag, "fizz_cov", fizzCov.Args["rustcFlags"]) + } + if !strings.Contains(libfooCov.Args["rustcFlags"], flag) { + t.Fatalf(missingErrorStr, flag, "libfoo_cov dylib", libfooCov.Args["rustcFlags"]) + } + if strings.Contains(buzzNoCov.Args["rustcFlags"], flag) { + t.Fatalf(containsErrorStr, flag, "buzzNoCov", buzzNoCov.Args["rustcFlags"]) + } + if strings.Contains(libbarNoCov.Args["rustcFlags"], flag) { + t.Fatalf(containsErrorStr, flag, "libbar_cov", libbarNoCov.Args["rustcFlags"]) + } + } + + linkCoverageFlags := []string{"--coverage", " -g "} + for _, flag := range linkCoverageFlags { + missingErrorStr := "missing rust linker flag '%s' for '%s' module with coverage enabled; rustcFlags: %#v" + containsErrorStr := "contains rust linker flag '%s' for '%s' module with coverage disabled; rustcFlags: %#v" + + if !strings.Contains(fizzCov.Args["linkFlags"], flag) { + t.Fatalf(missingErrorStr, flag, "fizz_cov", fizzCov.Args["linkFlags"]) + } + if !strings.Contains(libfooCov.Args["linkFlags"], flag) { + t.Fatalf(missingErrorStr, flag, "libfoo_cov dylib", libfooCov.Args["linkFlags"]) + } + if strings.Contains(buzzNoCov.Args["linkFlags"], flag) { + t.Fatalf(containsErrorStr, flag, "buzzNoCov", buzzNoCov.Args["linkFlags"]) + } + if strings.Contains(libbarNoCov.Args["linkFlags"], flag) { + t.Fatalf(containsErrorStr, flag, "libbar_cov", libbarNoCov.Args["linkFlags"]) + } + } + +} + +// Test coverage files are included correctly +func TestCoverageZip(t *testing.T) { + ctx := testRustCov(t, ` + rust_library { + name: "libfoo", + srcs: ["foo.rs"], + rlibs: ["librlib"], + crate_name: "foo", + } + rust_library_rlib { + name: "librlib", + srcs: ["foo.rs"], + crate_name: "rlib", + } + rust_binary { + name: "fizz", + rlibs: ["librlib"], + static_libs: ["libfoo"], + srcs: ["foo.rs"], + } + cc_binary { + name: "buzz", + static_libs: ["libfoo"], + srcs: ["foo.c"], + } + cc_library { + name: "libbar", + static_libs: ["libfoo"], + compile_multilib: "64", + srcs: ["foo.c"], + }`) + + fizzZipInputs := ctx.ModuleForTests("fizz", "android_arm64_armv8-a_cov").Rule("zip").Inputs.Strings() + libfooZipInputs := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_dylib_cov").Rule("zip").Inputs.Strings() + buzzZipInputs := ctx.ModuleForTests("buzz", "android_arm64_armv8-a_cov").Rule("zip").Inputs.Strings() + libbarZipInputs := ctx.ModuleForTests("libbar", "android_arm64_armv8-a_shared_cov").Rule("zip").Inputs.Strings() + + // Make sure the expected number of input files are included. + if len(fizzZipInputs) != 3 { + t.Fatalf("expected only 3 coverage inputs for rust 'fizz' binary, got %#v: %#v", len(fizzZipInputs), fizzZipInputs) + } + if len(libfooZipInputs) != 2 { + t.Fatalf("expected only 2 coverage inputs for rust 'libfoo' library, got %#v: %#v", len(libfooZipInputs), libfooZipInputs) + } + if len(buzzZipInputs) != 2 { + t.Fatalf("expected only 2 coverage inputs for cc 'buzz' binary, got %#v: %#v", len(buzzZipInputs), buzzZipInputs) + } + if len(libbarZipInputs) != 2 { + t.Fatalf("expected only 2 coverage inputs for cc 'libbar' library, got %#v: %#v", len(libbarZipInputs), libbarZipInputs) + } + + // Make sure the expected inputs are provided to the zip rule. + if !android.SuffixInList(fizzZipInputs, "android_arm64_armv8-a_rlib_cov/librlib.gcno") || + !android.SuffixInList(fizzZipInputs, "android_arm64_armv8-a_static_cov/libfoo.gcno") || + !android.SuffixInList(fizzZipInputs, "android_arm64_armv8-a_cov/fizz.gcno") { + t.Fatalf("missing expected coverage files for rust 'fizz' binary: %#v", fizzZipInputs) + } + if !android.SuffixInList(libfooZipInputs, "android_arm64_armv8-a_rlib_cov/librlib.gcno") || + !android.SuffixInList(libfooZipInputs, "android_arm64_armv8-a_dylib_cov/libfoo.dylib.gcno") { + t.Fatalf("missing expected coverage files for rust 'fizz' binary: %#v", libfooZipInputs) + } + if !android.SuffixInList(buzzZipInputs, "android_arm64_armv8-a_cov/obj/foo.gcno") || + !android.SuffixInList(buzzZipInputs, "android_arm64_armv8-a_static_cov/libfoo.gcno") { + t.Fatalf("missing expected coverage files for cc 'buzz' binary: %#v", buzzZipInputs) + } + if !android.SuffixInList(libbarZipInputs, "android_arm64_armv8-a_static_cov/obj/foo.gcno") || + !android.SuffixInList(libbarZipInputs, "android_arm64_armv8-a_static_cov/libfoo.gcno") { + t.Fatalf("missing expected coverage files for cc 'libbar' library: %#v", libbarZipInputs) + } +} + +func TestCoverageDeps(t *testing.T) { + ctx := testRustCov(t, ` + rust_binary { + name: "fizz", + srcs: ["foo.rs"], + }`) + + fizz := ctx.ModuleForTests("fizz", "android_arm64_armv8-a_cov").Rule("rustc") + if !strings.Contains(fizz.Args["linkFlags"], "libprofile-extras.a") { + t.Fatalf("missing expected coverage 'libprofile-extras' dependency in linkFlags: %#v", fizz.Args["linkFlags"]) + } +} -- cgit v1.2.3-59-g8ed1b