From aa5b377ee956f2e7ff2e0fb6630f636ecfe15b84 Mon Sep 17 00:00:00 2001 From: Cole Faust Date: Thu, 2 Feb 2023 12:11:29 -0800 Subject: Dynamically assemble the list of python launcher shared libs for precompiling Still fall back to the hardcoded list for what to put in LOCAL_SHARED_LIBRARIES, because I couldn't figure out a good way to get those modules at the moment. Bug: 259718110 Test: Presubmits Change-Id: Ia992ffea8819d8c67280b08bc45505f77af09de0 --- python/binary.go | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) (limited to 'python/binary.go') diff --git a/python/binary.go b/python/binary.go index 75135f345..95c751a82 100644 --- a/python/binary.go +++ b/python/binary.go @@ -125,6 +125,25 @@ func (p *PythonBinaryModule) buildBinary(ctx android.ModuleContext) { launcherPath = provider.IntermPathForModuleOut() } }) + + // TODO: get the list of shared libraries directly from the launcher module somehow + var sharedLibs []string + sharedLibs = append(sharedLibs, "libsqlite") + if ctx.Target().Os.Bionic() { + sharedLibs = append(sharedLibs, "libc", "libdl", "libm") + } + if ctx.Target().Os == android.LinuxMusl && !ctx.Config().HostStaticBinaries() { + sharedLibs = append(sharedLibs, "libc_musl") + } + switch p.properties.Actual_version { + case pyVersion2: + sharedLibs = append(sharedLibs, "libc++") + case pyVersion3: + if ctx.Device() { + sharedLibs = append(sharedLibs, "liblog") + } + } + p.androidMkSharedLibs = sharedLibs } srcsZips := make(android.Paths, 0, len(depsSrcsZips)+1) if embeddedLauncher { @@ -136,14 +155,6 @@ func (p *PythonBinaryModule) buildBinary(ctx android.ModuleContext) { p.installSource = registerBuildActionForParFile(ctx, embeddedLauncher, launcherPath, p.getHostInterpreterName(ctx, p.properties.Actual_version), main, p.getStem(ctx), srcsZips) - - var sharedLibs []string - // if embedded launcher is enabled, we need to collect the shared library dependencies of the - // launcher - for _, dep := range ctx.GetDirectDepsWithTag(launcherSharedLibTag) { - sharedLibs = append(sharedLibs, ctx.OtherModuleName(dep)) - } - p.androidMkSharedLibs = sharedLibs } func (p *PythonBinaryModule) AndroidMkEntries() []android.AndroidMkEntries { @@ -176,7 +187,7 @@ func (p *PythonBinaryModule) DepsMutator(ctx android.BottomUpMutatorContext) { p.PythonLibraryModule.DepsMutator(ctx) if p.isEmbeddedLauncherEnabled() { - p.AddDepsOnPythonLauncherAndStdlib(ctx, pythonLibTag, launcherTag, launcherSharedLibTag, p.autorun(), ctx.Target()) + p.AddDepsOnPythonLauncherAndStdlib(ctx, pythonLibTag, launcherTag, p.autorun(), ctx.Target()) } } -- cgit v1.2.3-59-g8ed1b