From 7cd1d422c72f8ae0f0b9d8b312e113c3110c29a7 Mon Sep 17 00:00:00 2001
From: Colin Cross <ccross@android.com>
Date: Wed, 13 Nov 2024 13:05:49 -0800
Subject: Don't use echo -e

A rule that uses echo -e may execute in a dash shell instead of bash
when running on the build servers.  The dash echo builtin is posix
compliant, and does not treat -e as an option[1].  Replace all uses
of echo -e with echo if it does not need escape sequences, or printf
if it does.

[1] https://wiki.ubuntu.com/DashAsBinSh#echo

Bug: 378931009
Test: manual
Change-Id: I2974f59ea10a613bc3bd36e3591fd81f38a1769a
---
 java/java.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'java/java.go')

diff --git a/java/java.go b/java/java.go
index 078f578e1..64ef782f5 100644
--- a/java/java.go
+++ b/java/java.go
@@ -226,9 +226,9 @@ var (
 
 	// Rule for generating device binary default wrapper
 	deviceBinaryWrapper = pctx.StaticRule("deviceBinaryWrapper", blueprint.RuleParams{
-		Command: `echo -e '#!/system/bin/sh\n` +
+		Command: `printf '#!/system/bin/sh\n` +
 			`export CLASSPATH=/system/framework/$jar_name\n` +
-			`exec app_process /$partition/bin $main_class "$$@"'> ${out}`,
+			`exec app_process /$partition/bin $main_class "$$@"\n'> ${out}`,
 		Description: "Generating device binary wrapper ${jar_name}",
 	}, "jar_name", "partition", "main_class")
 )
-- 
cgit v1.2.3-59-g8ed1b