From 50e790074444da8d850e4b11e075ed8a329dc3ea Mon Sep 17 00:00:00 2001 From: Paul Duffin Date: Mon, 25 Nov 2019 19:28:10 +0000 Subject: Dedup code for generating java_import in snapshot Removes duplicated code for generating a versioned and non-versioned form of the java_import module in the snapshot. Bug: 143678475 Test: m nothing and check output for dummy sdk Change-Id: Ia8d05c3bf9ef79953a817b168dd9d59f2af2d2ce --- java/java.go | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) (limited to 'java/java.go') diff --git a/java/java.go b/java/java.go index d4f65ba42..110478574 100644 --- a/java/java.go +++ b/java/java.go @@ -1691,25 +1691,27 @@ func (j *Library) BuildSnapshot(sdkModuleContext android.ModuleContext, builder } } - name := j.Name() - bp := builder.AndroidBpFile() - bp.Printfln("java_import {") - bp.Indent() - bp.Printfln("name: %q,", builder.VersionedSdkMemberName(name)) - bp.Printfln("sdk_member_name: %q,", name) - bp.Printfln("jars: [%q],", snapshotRelativeJavaLibPath) - bp.Dedent() - bp.Printfln("}") - bp.Printfln("") + j.generateJavaImport(builder, snapshotRelativeJavaLibPath, true) // This module is for the case when the source tree for the unversioned module // doesn't exist (i.e. building in an unbundled tree). "prefer:" is set to false // so that this module does not eclipse the unversioned module if it exists. + j.generateJavaImport(builder, snapshotRelativeJavaLibPath, false) +} + +func (j *Library) generateJavaImport(builder android.SnapshotBuilder, snapshotRelativeJavaLibPath string, versioned bool) { + bp := builder.AndroidBpFile() + name := j.Name() bp.Printfln("java_import {") bp.Indent() - bp.Printfln("name: %q,", name) + if versioned { + bp.Printfln("name: %q,", builder.VersionedSdkMemberName(name)) + bp.Printfln("sdk_member_name: %q,", name) + } else { + bp.Printfln("name: %q,", name) + bp.Printfln("prefer: false,") + } bp.Printfln("jars: [%q],", snapshotRelativeJavaLibPath) - bp.Printfln("prefer: false,") bp.Dedent() bp.Printfln("}") bp.Printfln("") -- cgit v1.2.3-59-g8ed1b