From 8d8c660710037e87c7094a612246d64e5af74846 Mon Sep 17 00:00:00 2001 From: Qiao Yang Date: Fri, 5 May 2023 15:03:24 +0000 Subject: Revert "Generate boot image profiles even if dexpreopt is disabled." Revert submission 2574032 Reason for revert: DroidMonitor-triggered revert due to breakage , bug Reverted changes: /q/submissionid:2574032 Change-Id: I8e99f8231639198b149ea8d822ee7f9a5b391a89 BUG: <280902279> --- java/bootclasspath_fragment.go | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) (limited to 'java/bootclasspath_fragment.go') diff --git a/java/bootclasspath_fragment.go b/java/bootclasspath_fragment.go index d1a020e4d..f69256347 100644 --- a/java/bootclasspath_fragment.go +++ b/java/bootclasspath_fragment.go @@ -506,6 +506,10 @@ func (b *BootclasspathFragmentModule) DepsMutator(ctx android.BottomUpMutatorCon } } + if SkipDexpreoptBootJars(ctx) { + return + } + // Add a dependency onto the dex2oat tool which is needed for creating the boot image. The // path is retrieved from the dependency by GetGlobalSoongConfig(ctx). dexpreopt.RegisterToolDeps(ctx) @@ -897,6 +901,10 @@ func (b *BootclasspathFragmentModule) produceHiddenAPIOutput(ctx android.ModuleC // produceBootImageFiles builds the boot image files from the source if it is required. func (b *BootclasspathFragmentModule) produceBootImageFiles(ctx android.ModuleContext, imageConfig *bootImageConfig) bootImageOutputs { + if SkipDexpreoptBootJars(ctx) { + return bootImageOutputs{} + } + // Only generate the boot image if the configuration does not skip it. return b.generateBootImageBuildActions(ctx, imageConfig) } @@ -924,13 +932,6 @@ func (b *BootclasspathFragmentModule) generateBootImageBuildActions(ctx android. // Build boot image files for the host variants. buildBootImageVariantsForBuildOs(ctx, imageConfig, profile) - // If dexpreopt of boot image jars should be skipped, generate only a profile. - if SkipDexpreoptBootJars(ctx) { - return bootImageOutputs{ - profile: profile, - } - } - // Build boot image files for the android variants. bootImageFiles := buildBootImageVariantsForAndroidOs(ctx, imageConfig, profile) -- cgit v1.2.3-59-g8ed1b