From 1fe91a79985a01d65d3a51d3f44e11b02c4aa60c Mon Sep 17 00:00:00 2001 From: "Priyanka Advani (xWF)" Date: Wed, 26 Feb 2025 11:37:40 -0800 Subject: Revert "cc: Add cc_rustlibs_for_make to bundle rust_ffi_static" Revert submission 3469976-ICU4X-in-bionic Reason for revert: Droidmonitor created revert due to b/399425763. Will be verifying through ABTD before submission. Reverted changes: /q/submissionid:3469976-ICU4X-in-bionic Change-Id: Id8e9b68c2e44bbdd363d303a794041dc370f29fc --- cc/library.go | 28 ---------------------------- 1 file changed, 28 deletions(-) (limited to 'cc') diff --git a/cc/library.go b/cc/library.go index 86196ce24..532b7e9aa 100644 --- a/cc/library.go +++ b/cc/library.go @@ -220,7 +220,6 @@ func init() { func RegisterLibraryBuildComponents(ctx android.RegistrationContext) { ctx.RegisterModuleType("cc_library_static", LibraryStaticFactory) - ctx.RegisterModuleType("cc_rustlibs_for_make", LibraryMakeRustlibsFactory) ctx.RegisterModuleType("cc_library_shared", LibrarySharedFactory) ctx.RegisterModuleType("cc_library", LibraryFactory) ctx.RegisterModuleType("cc_library_host_static", LibraryHostStaticFactory) @@ -250,19 +249,6 @@ func LibraryStaticFactory() android.Module { return module.Init() } -// cc_rustlibs_for_make creates a static library which bundles together rust_ffi_static -// deps for Make. This should not be depended on in Soong, and is probably not the -// module you need unless you are sure of what you're doing. These should only -// be declared as dependencies in Make. To ensure inclusion, rust_ffi_static modules -// should be declared in the whole_static_libs property. -func LibraryMakeRustlibsFactory() android.Module { - module, library := NewLibrary(android.HostAndDeviceSupported) - library.BuildOnlyStatic() - library.wideStaticlibForMake = true - module.sdkMemberTypes = []android.SdkMemberType{staticLibrarySdkMemberType} - return module.Init() -} - // cc_library_shared creates a shared library for a device and/or host. func LibrarySharedFactory() android.Module { module, library := NewLibrary(android.HostAndDeviceSupported) @@ -451,10 +437,6 @@ type libraryDecorator struct { // Path to the file containing the APIs exported by this library stubsSymbolFilePath android.Path - - // Forces production of the generated Rust staticlib for cc_library_static. - // Intended to be used to provide these generated staticlibs for Make. - wideStaticlibForMake bool } // linkerProps returns the list of properties structs relevant for this library. (For example, if @@ -1073,16 +1055,6 @@ func (library *libraryDecorator) linkStatic(ctx ModuleContext, library.objects = library.objects.Append(objs) library.wholeStaticLibsFromPrebuilts = android.CopyOfPaths(deps.WholeStaticLibsFromPrebuilts) - if library.wideStaticlibForMake { - if generatedLib := GenerateRustStaticlib(ctx, deps.RustRlibDeps); generatedLib != nil { - // WholeStaticLibsFromPrebuilts are .a files that get included whole into the resulting staticlib - // so reuse that here for our Rust staticlibs because we don't have individual object files for - // these. - deps.WholeStaticLibsFromPrebuilts = append(deps.WholeStaticLibsFromPrebuilts, generatedLib) - } - - } - fileName := ctx.ModuleName() + staticLibraryExtension outputFile := android.PathForModuleOut(ctx, fileName) builderFlags := flagsToBuilderFlags(flags) -- cgit v1.2.3-59-g8ed1b