From 45e4001f7a4c4e30e237a8f8a00d9b352785f31a Mon Sep 17 00:00:00 2001 From: Spandan Das Date: Mon, 2 Dec 2024 22:45:48 +0000 Subject: Move withNativeBridgeEnabled to build/soong/android This fixture creates the setup for native bridge targets. Moving this to android package reduces code duplication. Bug: 376873507 Test: go test ./android ./apex ./fsgen Change-Id: I7e14b623ee4da803a7f78adeeeb18b3ad7a0622d --- apex/apex_test.go | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) (limited to 'apex/apex_test.go') diff --git a/apex/apex_test.go b/apex/apex_test.go index 6cdb225ff..27c0340de 100644 --- a/apex/apex_test.go +++ b/apex/apex_test.go @@ -84,26 +84,6 @@ func withFiles(files android.MockFS) android.FixturePreparer { return files.AddToFixture() } -// withNativeBridgeTargets sets configuration with targets including: -// - X86_64 (primary) -// - X86 (secondary) -// - Arm64 on X86_64 (native bridge) -// - Arm on X86 (native bridge) -var withNativeBridgeEnabled = android.FixtureModifyConfig( - func(config android.Config) { - config.Targets[android.Android] = []android.Target{ - {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}}, - NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, - {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}}, - NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""}, - {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, - NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"}, - {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, - NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"}, - } - }, -) - func withManifestPackageNameOverrides(specs []string) android.FixturePreparer { return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { variables.ManifestPackageNameOverrides = specs @@ -3198,7 +3178,7 @@ func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) { }, }, } - `, withNativeBridgeEnabled) + `, android.PrepareForNativeBridgeEnabled) ensureExactContents(t, ctx, "myapex", "android_common_myapex", []string{ "bin/foo/bar/mybin", "bin/foo/bar/mybin64", -- cgit v1.2.3-59-g8ed1b