summaryrefslogtreecommitdiff
path: root/sdk/bp_test.go
AgeCommit message (Collapse)Author
2025-02-06Add t.Parallel() to SDK tests Colin Cross
Reduces time to run go test ./sdk from 44 seconds to 22.5 seconds. Requires moving snapshotTestCustomizations from a map to a struct with individual fields to avoid concurrent map accesses between subtests. Test: go test ./sdk Change-Id: Id6f451ba9cbace8bc7ea915033a795456b85cf3f
2021-03-20Replace AssertPanic with AssertPanicMessageContains Paul Duffin
Bug: 182885307 Test: m nothing Change-Id: Idffa314285c90080796cc3df391de9c314eaa422
2021-03-13Stop sdk package depending on testing.T being embedded in TestResult Paul Duffin
This change is in preparation for removing testing.T from TestResult. Bug: 181070625 Test: m nothing Change-Id: I67535aff0d894e6e3d8456b75540f340af853355
2021-03-10Remove duplicate sdk.TestHelper Paul Duffin
As part of the work on the new fixture mechanism some of the TestHelper functionality was moved into the android/fixture.go package. This moves the rest and removes the now duplicated TestHelper from the sdk package. Also removed some unnecessary & operators. Bug: 181070625 Test: m nothing Change-Id: Ia09a5d05e4fab3a4e28cf44b2d947a33541e3925
2020-10-09Revert "Make lots of tests run in parallel" Colin Cross
This reverts commit 323dc60712491c71ccdc5363c42df61f0a192487. Reason for revert: Possible cause of test instability Bug: 170513220 Test: soong tests Change-Id: Iee168e9fbb4210569e6cffcc23e60d111403abb8
2020-10-06Make lots of tests run in parallel Colin Cross
Putting t.Parallel() in each test makes them run in parallel. Additional t.Parallel() could be added to each subtest, although that requires making a local copy of the loop variable for table driven tests. Test: m checkbuild Change-Id: I5d9869ead441093f4d7c5757f2447385333a95a4
2020-09-25Handle property structs and BpPropertySets as values to AddProperty. Martin Stjernholm
Both will create a nested property set, that may be merged with an existing one. Test: m nothing Bug: 151303681 Change-Id: I30696ba3eb8960ca6fa54c9ee2cf6229ab9f5da9
2020-05-11Defer \n quoting generatedContents until creating the ninja rule Paul Duffin
Previously, when writing to generatedContents \n characters were quoted (replaced with \\n) so as to allow them to be preserved through ninja/rsp/bash and were unquoted (replaced \\n with \n) just before redirecting to the output file. That meant that any code which wanted to access the contents for other purposes, e.g. testing had to unquote \\n. This change moves the quoting to be part of the code that generates the ninja rule which simplifies any other code that has to access the contents. Without quoting the generated Android.bp files are not formatted properly, are all on one line and completely unreadable. Bug: 156286550 Test: m art-module-sdk and check generated Android.bp file to make sure it is properly formatted. Change-Id: I768c3b96ed08a3daf251730e2a10d9d72338c49a
2020-02-24Add support for transforming a property set after its contents Paul Duffin
This change adds support for transforming a property set after its contents. This allows a transform to recursively prune empty property sets that were created for a module. The transformPropertySet method was renamed to transformPropertySetBeforeContents and a new transformPropertySetAfterContents method was added. Bug: 148933848 Test: m nothing Change-Id: Ia198d47e042b98c69406db4bc12859869816a387
2020-02-24Fix issues with bp transformation Paul Duffin
Returning nil from transformPropertySet in order to remove it did not work because it ends up comparing as (*bpPropertySet, nil) and not an untyped nil which causes the test against nil to fail. This change adds tests to check that returning nil will delete a property/property set from the containing property set and fixes the code so that it passes the tests. It extracts common code to transform a property set and its contents as well as code for creating new property sets. Bug: 148933848 Test: m nothing Change-Id: I35dc3c39c76e701821891622615c09b094cf697f