summaryrefslogtreecommitdiff
path: root/filesystem
diff options
context:
space:
mode:
Diffstat (limited to 'filesystem')
-rw-r--r--filesystem/filesystem.go7
-rw-r--r--filesystem/filesystem_test.go23
-rw-r--r--filesystem/system_image.go2
3 files changed, 1 insertions, 31 deletions
diff --git a/filesystem/filesystem.go b/filesystem/filesystem.go
index 5bcfce7a3..cadf9c246 100644
--- a/filesystem/filesystem.go
+++ b/filesystem/filesystem.go
@@ -137,7 +137,6 @@ type filesystemProperties struct {
// partitions like system.img. For example, cc_library modules are placed under ./lib[64] directory.
func filesystemFactory() android.Module {
module := &filesystem{}
- module.filterPackagingSpec = module.filterInstallablePackagingSpec
initFilesystemModule(module)
return module
}
@@ -190,12 +189,6 @@ func (f *filesystem) partitionName() string {
return proptools.StringDefault(f.properties.Partition_name, f.Name())
}
-func (f *filesystem) filterInstallablePackagingSpec(ps android.PackagingSpec) bool {
- // Filesystem module respects the installation semantic. A PackagingSpec from a module with
- // IsSkipInstall() is skipped.
- return !ps.SkipInstall()
-}
-
var pctx = android.NewPackageContext("android/soong/filesystem")
func (f *filesystem) GenerateAndroidBuildActions(ctx android.ModuleContext) {
diff --git a/filesystem/filesystem_test.go b/filesystem/filesystem_test.go
index acd481352..121504867 100644
--- a/filesystem/filesystem_test.go
+++ b/filesystem/filesystem_test.go
@@ -442,26 +442,3 @@ func TestInconsistentPartitionTypesInDefaults(t *testing.T) {
}
`)
}
-
-func TestPreventDuplicatedEntries(t *testing.T) {
- fixture.ExtendWithErrorHandler(android.FixtureExpectsOneErrorPattern(
- "packaging conflict at")).
- RunTestWithBp(t, `
- android_filesystem {
- name: "fs",
- deps: [
- "foo",
- "foo_dup",
- ],
- }
-
- cc_binary {
- name: "foo",
- }
-
- cc_binary {
- name: "foo_dup",
- stem: "foo",
- }
- `)
-}
diff --git a/filesystem/system_image.go b/filesystem/system_image.go
index 15cacfb4f..5028a493e 100644
--- a/filesystem/system_image.go
+++ b/filesystem/system_image.go
@@ -98,5 +98,5 @@ func (s *systemImage) buildLinkerConfigFile(ctx android.ModuleContext, root andr
// Note that "apex" module installs its contents to "apex"(fake partition) as well
// for symbol lookup by imitating "activated" paths.
func (s *systemImage) filterPackagingSpec(ps android.PackagingSpec) bool {
- return s.filesystem.filterInstallablePackagingSpec(ps) && ps.Partition() == "system"
+ return ps.Partition() == "system"
}