diff options
Diffstat (limited to 'apex/apex_test.go')
| -rw-r--r-- | apex/apex_test.go | 28 | 
1 files changed, 22 insertions, 6 deletions
diff --git a/apex/apex_test.go b/apex/apex_test.go index b5b1d4401..422e46c4d 100644 --- a/apex/apex_test.go +++ b/apex/apex_test.go @@ -4687,16 +4687,26 @@ func TestPrebuiltExportDexImplementationJars(t *testing.T) {  		p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)  		dexJarBuildPath := p.DexJarBuildPath()  		stem := android.RemoveOptionalPrebuiltPrefix(name) -		if expected, actual := ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar", android.NormalizePathForTesting(dexJarBuildPath); actual != expected { -			t.Errorf("Incorrect DexJarBuildPath value '%s', expected '%s'", actual, expected) -		} +		android.AssertStringEquals(t, "DexJarBuildPath should be apex-related path.", +			".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar", +			android.NormalizePathForTesting(dexJarBuildPath)) +	} + +	checkDexJarInstallPath := func(t *testing.T, ctx *android.TestContext, name string) { +		// Make sure the import has been given the correct path to the dex jar. +		p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency) +		dexJarBuildPath := p.DexJarInstallPath() +		stem := android.RemoveOptionalPrebuiltPrefix(name) +		android.AssertStringEquals(t, "DexJarInstallPath should be apex-related path.", +			"target/product/test_device/apex/myapex/javalib/"+stem+".jar", +			android.NormalizePathForTesting(dexJarBuildPath))  	}  	ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {  		// Make sure that an apex variant is not created for the source module. -		if expected, actual := []string{"android_common"}, ctx.ModuleVariantsForTests(name); !reflect.DeepEqual(expected, actual) { -			t.Errorf("invalid set of variants for %q: expected %q, found %q", "libfoo", expected, actual) -		} +		android.AssertArrayString(t, "Check if there is no source variant", +			[]string{"android_common"}, +			ctx.ModuleVariantsForTests(name))  	}  	t.Run("prebuilt only", func(t *testing.T) { @@ -4745,8 +4755,10 @@ func TestPrebuiltExportDexImplementationJars(t *testing.T) {  		}  		checkDexJarBuildPath(t, ctx, "libfoo") +		checkDexJarInstallPath(t, ctx, "libfoo")  		checkDexJarBuildPath(t, ctx, "libbar") +		checkDexJarInstallPath(t, ctx, "libbar")  	})  	t.Run("prebuilt with source preferred", func(t *testing.T) { @@ -4792,9 +4804,11 @@ func TestPrebuiltExportDexImplementationJars(t *testing.T) {  		ctx := testDexpreoptWithApexes(t, bp, "", transform)  		checkDexJarBuildPath(t, ctx, "prebuilt_libfoo") +		checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")  		ensureNoSourceVariant(t, ctx, "libfoo")  		checkDexJarBuildPath(t, ctx, "prebuilt_libbar") +		checkDexJarInstallPath(t, ctx, "prebuilt_libbar")  		ensureNoSourceVariant(t, ctx, "libbar")  	}) @@ -4842,9 +4856,11 @@ func TestPrebuiltExportDexImplementationJars(t *testing.T) {  		ctx := testDexpreoptWithApexes(t, bp, "", transform)  		checkDexJarBuildPath(t, ctx, "prebuilt_libfoo") +		checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")  		ensureNoSourceVariant(t, ctx, "libfoo")  		checkDexJarBuildPath(t, ctx, "prebuilt_libbar") +		checkDexJarInstallPath(t, ctx, "prebuilt_libbar")  		ensureNoSourceVariant(t, ctx, "libbar")  	})  }  |