diff options
| -rw-r--r-- | Android.bp | 10 | ||||
| -rw-r--r-- | aconfig/init.go | 1 | ||||
| -rw-r--r-- | android/Android.bp | 1 | ||||
| -rw-r--r-- | android/androidmk.go | 2 | ||||
| -rw-r--r-- | android/mutator.go | 19 | ||||
| -rw-r--r-- | android/transition.go | 4 | ||||
| -rw-r--r-- | android/util.go | 4 | ||||
| -rw-r--r-- | android/variable.go | 2 | ||||
| -rw-r--r-- | cc/test.go | 3 | ||||
| -rw-r--r-- | filesystem/android_device.go | 47 | ||||
| -rw-r--r-- | filesystem/filesystem.go | 80 | ||||
| -rw-r--r-- | filesystem/super_image.go | 5 | ||||
| -rw-r--r-- | filesystem/system_other.go | 37 | ||||
| -rw-r--r-- | fsgen/filesystem_creator.go | 5 | ||||
| -rw-r--r-- | rust/androidmk.go | 10 | ||||
| -rw-r--r-- | rust/compiler.go | 2 |
16 files changed, 175 insertions, 57 deletions
diff --git a/Android.bp b/Android.bp index 523f55c4b..6c4066160 100644 --- a/Android.bp +++ b/Android.bp @@ -147,16 +147,6 @@ all_apex_contributions { // Framework guests. cc_defaults { name: "cc_baremetal_defaults", - arch: { - arm64: { - cflags: [ - // Prevent the compiler from optimizing code using SVE, as the - // baremetal environment might not have configured the hardware. - "-Xclang -target-feature", - "-Xclang -sve", - ], - }, - }, defaults_visibility: ["//visibility:public"], } diff --git a/aconfig/init.go b/aconfig/init.go index 210aec3b9..b2fe5a309 100644 --- a/aconfig/init.go +++ b/aconfig/init.go @@ -104,6 +104,7 @@ var ( ` --mode=exported` + ` --allow-instrumentation ${use_new_storage}` + ` --new-exported ${use_new_exported}` + + ` --single-exported-file true` + ` --check-api-level ${check_api_level}` + ` --out ${out}.tmp; ` + ` fi ` + diff --git a/android/Android.bp b/android/Android.bp index 540d65bd4..aef18fec0 100644 --- a/android/Android.bp +++ b/android/Android.bp @@ -11,6 +11,7 @@ bootstrap_go_package { "blueprint-depset", "blueprint-gobtools", "blueprint-metrics", + "blueprint-pool", "sbox_proto", "soong", "soong-android_team_proto", diff --git a/android/androidmk.go b/android/androidmk.go index 951e03c36..7d6b05673 100644 --- a/android/androidmk.go +++ b/android/androidmk.go @@ -64,7 +64,6 @@ type AndroidMkDataProvider interface { type AndroidMkData struct { Class string SubName string - DistFiles TaggedDistFiles OutputFile OptionalPath Disabled bool Include string @@ -1093,7 +1092,6 @@ func (data *AndroidMkData) fillInData(ctx fillInEntriesContext, mod blueprint.Mo data.Entries = AndroidMkEntries{ Class: data.Class, SubName: data.SubName, - DistFiles: data.DistFiles, OutputFile: data.OutputFile, Disabled: data.Disabled, Include: data.Include, diff --git a/android/mutator.go b/android/mutator.go index d6166d2de..12861c074 100644 --- a/android/mutator.go +++ b/android/mutator.go @@ -15,9 +15,8 @@ package android import ( - "sync" - "github.com/google/blueprint" + "github.com/google/blueprint/pool" ) // Phases: @@ -272,15 +271,9 @@ type BottomUpMutatorContext interface { // for each transition mutator. bottomUpMutatorContext is created once for every module for every BottomUp mutator. // Use a global pool for each to avoid reallocating every time. var ( - outgoingTransitionContextPool = sync.Pool{ - New: func() any { return &outgoingTransitionContextImpl{} }, - } - incomingTransitionContextPool = sync.Pool{ - New: func() any { return &incomingTransitionContextImpl{} }, - } - bottomUpMutatorContextPool = sync.Pool{ - New: func() any { return &bottomUpMutatorContext{} }, - } + outgoingTransitionContextPool = pool.New[outgoingTransitionContextImpl]() + incomingTransitionContextPool = pool.New[incomingTransitionContextImpl]() + bottomUpMutatorContextPool = pool.New[bottomUpMutatorContext]() ) type bottomUpMutatorContext struct { @@ -291,10 +284,10 @@ type bottomUpMutatorContext struct { // callers must immediately follow the call to this function with defer bottomUpMutatorContextPool.Put(mctx). func bottomUpMutatorContextFactory(ctx blueprint.BottomUpMutatorContext, a Module, - finalPhase bool) BottomUpMutatorContext { + finalPhase bool) *bottomUpMutatorContext { moduleContext := a.base().baseModuleContextFactory(ctx) - mctx := bottomUpMutatorContextPool.Get().(*bottomUpMutatorContext) + mctx := bottomUpMutatorContextPool.Get() *mctx = bottomUpMutatorContext{ bp: ctx, baseModuleContext: moduleContext, diff --git a/android/transition.go b/android/transition.go index e1aa891d1..0677ca1dd 100644 --- a/android/transition.go +++ b/android/transition.go @@ -197,7 +197,7 @@ func (a *androidTransitionMutatorAdapter) Split(ctx blueprint.BaseModuleContext) func (a *androidTransitionMutatorAdapter) OutgoingTransition(bpctx blueprint.OutgoingTransitionContext, sourceTransitionInfo blueprint.TransitionInfo) blueprint.TransitionInfo { m := bpctx.Module().(Module) - ctx := outgoingTransitionContextPool.Get().(*outgoingTransitionContextImpl) + ctx := outgoingTransitionContextPool.Get() defer outgoingTransitionContextPool.Put(ctx) *ctx = outgoingTransitionContextImpl{ archModuleContext: m.base().archModuleContextFactory(bpctx), @@ -209,7 +209,7 @@ func (a *androidTransitionMutatorAdapter) OutgoingTransition(bpctx blueprint.Out func (a *androidTransitionMutatorAdapter) IncomingTransition(bpctx blueprint.IncomingTransitionContext, incomingTransitionInfo blueprint.TransitionInfo) blueprint.TransitionInfo { m := bpctx.Module().(Module) - ctx := incomingTransitionContextPool.Get().(*incomingTransitionContextImpl) + ctx := incomingTransitionContextPool.Get() defer incomingTransitionContextPool.Put(ctx) *ctx = incomingTransitionContextImpl{ archModuleContext: m.base().archModuleContextFactory(bpctx), diff --git a/android/util.go b/android/util.go index 30d8ec6b3..e8d9301dd 100644 --- a/android/util.go +++ b/android/util.go @@ -221,13 +221,13 @@ func ListSetDifference[T comparable](l1, l2 []T) (bool, []T, []T) { diff2 := []T{} m1 := setFromList(l1) m2 := setFromList(l2) - for t := range m1 { + for _, t := range l1 { if _, ok := m2[t]; !ok { diff1 = append(diff1, t) listsDiffer = true } } - for t := range m2 { + for _, t := range l2 { if _, ok := m1[t]; !ok { diff2 = append(diff2, t) listsDiffer = true diff --git a/android/variable.go b/android/variable.go index 4867067b0..aace6ed05 100644 --- a/android/variable.go +++ b/android/variable.go @@ -664,6 +664,8 @@ type PartitionVariables struct { ProductVirtualAbCompressionFactor string `json:",omitempty"` ProductVirtualAbCowVersion string `json:",omitempty"` AbOtaUpdater bool `json:",omitempty"` + AbOtaPartitions []string `json:",omitempty"` + AbOtaKeys []string `json:",omitempty"` // Avb (android verified boot) stuff BoardAvbEnable bool `json:",omitempty"` diff --git a/cc/test.go b/cc/test.go index 9f86c7af3..b3b2ae8c4 100644 --- a/cc/test.go +++ b/cc/test.go @@ -442,6 +442,9 @@ func (test *testBinary) install(ctx ModuleContext, file android.Path) { if standaloneTestDep.ToGob().SrcPath == nil { continue } + if standaloneTestDep.SkipInstall() { + continue + } test.binaryDecorator.baseInstaller.installStandaloneTestDep(ctx, standaloneTestDep) } } diff --git a/filesystem/android_device.go b/filesystem/android_device.go index 960c96acf..514fd2816 100644 --- a/filesystem/android_device.go +++ b/filesystem/android_device.go @@ -70,7 +70,9 @@ type DeviceProperties struct { // blueprint:"mutated" and still set it from filesystem_creator Main_device *bool - Ab_ota_updater *bool + Ab_ota_updater *bool + Ab_ota_partitions []string + Ab_ota_keys []string } type androidDevice struct { @@ -237,6 +239,26 @@ func (a *androidDevice) GenerateAndroidBuildActions(ctx android.ModuleContext) { ctx.CheckbuildFile(allImagesStamp) a.setVbmetaPhonyTargets(ctx) + + a.distFiles(ctx) +} + +func (a *androidDevice) distFiles(ctx android.ModuleContext) { + if !ctx.Config().KatiEnabled() { + if proptools.Bool(a.deviceProps.Main_device) { + fsInfoMap := a.getFsInfos(ctx) + for _, partition := range android.SortedKeys(fsInfoMap) { + fsInfo := fsInfoMap[partition] + if fsInfo.InstalledFiles.Json != nil { + ctx.DistForGoal("droidcore-unbundled", fsInfo.InstalledFiles.Json) + } + if fsInfo.InstalledFiles.Txt != nil { + ctx.DistForGoal("droidcore-unbundled", fsInfo.InstalledFiles.Txt) + } + } + } + } + } func (a *androidDevice) MakeVars(ctx android.MakeVarsModuleContext) { @@ -398,8 +420,12 @@ func (a *androidDevice) copyImagesToTargetZip(ctx android.ModuleContext, builder superPartition := ctx.GetDirectDepProxyWithTag(*a.partitionProps.Super_partition_name, superPartitionDepTag) if info, ok := android.OtherModuleProvider(ctx, superPartition, SuperImageProvider); ok { for _, partition := range android.SortedKeys(info.SubImageInfo) { - builder.Command().Textf("cp ").Input(info.SubImageInfo[partition].OutputHermetic).Textf(" %s/IMAGES/", targetFilesDir.String()) - builder.Command().Textf("cp ").Input(info.SubImageInfo[partition].MapFile).Textf(" %s/IMAGES/", targetFilesDir.String()) + if info.SubImageInfo[partition].OutputHermetic != nil { + builder.Command().Textf("cp ").Input(info.SubImageInfo[partition].OutputHermetic).Textf(" %s/IMAGES/", targetFilesDir.String()) + } + if info.SubImageInfo[partition].MapFile != nil { + builder.Command().Textf("cp ").Input(info.SubImageInfo[partition].MapFile).Textf(" %s/IMAGES/", targetFilesDir.String()) + } } } else { ctx.ModuleErrorf("Super partition %s does set SuperImageProvider\n", superPartition.Name()) @@ -415,9 +441,20 @@ func (a *androidDevice) copyMetadataToTargetZip(ctx android.ModuleContext, build info, _ := android.OtherModuleProvider(ctx, child, android.OutputFilesProvider) builder.Command().Textf("cp").Inputs(info.DefaultOutputFiles).Textf(" %s/META/", targetFilesDir.String()) }) + builder.Command().Textf("cp").Input(android.PathForSource(ctx, "external/zucchini/version_info.h")).Textf(" %s/META/zucchini_config.txt", targetFilesDir.String()) + builder.Command().Textf("cp").Input(android.PathForSource(ctx, "system/update_engine/update_engine.conf")).Textf(" %s/META/update_engine_config.txt", targetFilesDir.String()) + if a.getFsInfos(ctx)["system"].ErofsCompressHints != nil { + builder.Command().Textf("cp").Input(a.getFsInfos(ctx)["system"].ErofsCompressHints).Textf(" %s/META/erofs_default_compress_hints.txt", targetFilesDir.String()) + } + // ab_partitions.txt + abPartitionsSorted := android.SortedUniqueStrings(a.deviceProps.Ab_ota_partitions) + abPartitionsSortedString := proptools.ShellEscape(strings.Join(abPartitionsSorted, "\\n")) + builder.Command().Textf("echo -e").Flag(abPartitionsSortedString).Textf(" > %s/META/ab_partitions.txt", targetFilesDir.String()) + // otakeys.txt + abOtaKeysSorted := android.SortedUniqueStrings(a.deviceProps.Ab_ota_keys) + abOtaKeysSortedString := proptools.ShellEscape(strings.Join(abOtaKeysSorted, "\\n")) + builder.Command().Textf("echo -e").Flag(abOtaKeysSortedString).Textf(" > %s/META/otakeys.txt", targetFilesDir.String()) } - builder.Command().Textf("cp").Input(android.PathForSource(ctx, "external/zucchini/version_info.h")).Textf(" %s/META/zucchini_config.txt", targetFilesDir.String()) - builder.Command().Textf("cp").Input(android.PathForSource(ctx, "system/update_engine/update_engine.conf")).Textf(" %s/META/update_engine_config.txt", targetFilesDir.String()) } func (a *androidDevice) getFilesystemInfo(ctx android.ModuleContext, depName string) FilesystemInfo { diff --git a/filesystem/filesystem.go b/filesystem/filesystem.go index 3f774331d..c3c06bd58 100644 --- a/filesystem/filesystem.go +++ b/filesystem/filesystem.go @@ -36,6 +36,7 @@ import ( func init() { registerBuildComponents(android.InitRegistrationContext) registerMutators(android.InitRegistrationContext) + pctx.HostBinToolVariable("fileslist", "fileslist") } func registerBuildComponents(ctx android.RegistrationContext) { @@ -54,11 +55,24 @@ func registerMutators(ctx android.RegistrationContext) { }) } -// Remember to add referenced files to implicits! -var textFileProcessorRule = pctx.AndroidStaticRule("text_file_processing", blueprint.RuleParams{ - Command: "build/soong/scripts/text_file_processor.py $in $out", - CommandDeps: []string{"build/soong/scripts/text_file_processor.py"}, -}) +var ( + // Remember to add referenced files to implicits! + textFileProcessorRule = pctx.AndroidStaticRule("text_file_processing", blueprint.RuleParams{ + Command: "build/soong/scripts/text_file_processor.py $in $out", + CommandDeps: []string{"build/soong/scripts/text_file_processor.py"}, + }) + + // Remember to add the output image file as an implicit dependency! + installedFilesJsonRule = pctx.AndroidStaticRule("installed_files_json", blueprint.RuleParams{ + Command: `${fileslist} ${rootDir} > ${out}`, + CommandDeps: []string{"${fileslist}"}, + }, "rootDir") + + installedFilesTxtRule = pctx.AndroidStaticRule("installed_files_txt", blueprint.RuleParams{ + Command: `build/make/tools/fileslist_util.py -c ${in} > ${out}`, + CommandDeps: []string{"build/make/tools/fileslist_util.py"}, + }) +) type filesystem struct { android.ModuleBase @@ -358,6 +372,11 @@ func (fs fsType) IsUnknown() bool { return fs == unknown } +type InstalledFilesStruct struct { + Txt android.Path + Json android.Path +} + type FilesystemInfo struct { // The built filesystem image Output android.Path @@ -391,6 +410,13 @@ type FilesystemInfo struct { SpecsForSystemOther map[string]android.PackagingSpec FullInstallPaths []FullInstallPathInfo + + // Installed files list + InstalledFiles InstalledFilesStruct + + // Path to compress hints file for erofs filesystems + // This will be nil for other fileystems like ext4 + ErofsCompressHints android.Path } // FullInstallPathInfo contains information about the "full install" paths of all the files @@ -498,6 +524,34 @@ func (f *filesystem) ModifyPackagingSpec(ps *android.PackagingSpec) { } } +func buildInstalledFiles(ctx android.ModuleContext, partition string, rootDir android.Path, image android.Path) (txt android.ModuleOutPath, json android.ModuleOutPath) { + fileName := "installed-files" + if len(partition) > 0 { + fileName += fmt.Sprintf("-%s", partition) + } + txt = android.PathForModuleOut(ctx, fmt.Sprintf("%s.txt", fileName)) + json = android.PathForModuleOut(ctx, fmt.Sprintf("%s.json", fileName)) + + ctx.Build(pctx, android.BuildParams{ + Rule: installedFilesJsonRule, + Implicit: image, + Output: json, + Description: "Installed file list json", + Args: map[string]string{ + "rootDir": rootDir.String(), + }, + }) + + ctx.Build(pctx, android.BuildParams{ + Rule: installedFilesTxtRule, + Input: json, + Output: txt, + Description: "Installed file list txt", + }) + + return txt, json +} + var pctx = android.NewPackageContext("android/soong/filesystem") func (f *filesystem) GenerateAndroidBuildActions(ctx android.ModuleContext) { @@ -578,6 +632,17 @@ func (f *filesystem) GenerateAndroidBuildActions(ctx android.ModuleContext) { fileListFile := android.PathForModuleOut(ctx, "fileList") android.WriteFileRule(ctx, fileListFile, f.installedFilesList()) + partitionName := f.partitionName() + if partitionName == "system" { + partitionName = "" + } + installedFileTxt, installedFileJson := buildInstalledFiles(ctx, partitionName, rootDir, f.output) + + var erofsCompressHints android.Path + if f.properties.Erofs.Compress_hints != nil { + erofsCompressHints = android.PathForModuleSrc(ctx, *f.properties.Erofs.Compress_hints) + } + fsInfo := FilesystemInfo{ Output: f.output, OutputHermetic: outputHermetic, @@ -590,6 +655,11 @@ func (f *filesystem) GenerateAndroidBuildActions(ctx android.ModuleContext) { BuildImagePropFileDeps: buildImagePropFileDeps, SpecsForSystemOther: f.systemOtherFiles(ctx), FullInstallPaths: fullInstallPaths, + InstalledFiles: InstalledFilesStruct{ + Txt: installedFileTxt, + Json: installedFileJson, + }, + ErofsCompressHints: erofsCompressHints, } android.SetProvider(ctx, FilesystemProvider, fsInfo) diff --git a/filesystem/super_image.go b/filesystem/super_image.go index da007bbb5..58c938aee 100644 --- a/filesystem/super_image.go +++ b/filesystem/super_image.go @@ -291,8 +291,6 @@ func (s *superImage) buildMiscInfo(ctx android.ModuleContext) (android.Path, and switch p { case "system": handleSubPartition("system", s.partitionProps.System_partition) - // TODO: add system_other to deps after it can be generated - //getFsInfo("system_other", s.partitionProps.System_other_partition, &subImageInfo.System_other) case "system_dlkm": handleSubPartition("system_dlkm", s.partitionProps.System_dlkm_partition) case "system_ext": @@ -321,8 +319,7 @@ func (s *superImage) buildMiscInfo(ctx android.ModuleContext) (android.Path, and if len(systemOtherFiles) != 1 { ctx.PropertyErrorf("system_other_partition", "Expected 1 output file from module %q", *&s.properties.System_other_partition) } else { - addStr("system_other_image", systemOtherFiles[0].String()) - deps = append(deps, systemOtherFiles[0]) + handleSubPartition("system_other", s.partitionProps.System_other_partition) } } diff --git a/filesystem/system_other.go b/filesystem/system_other.go index 28fe1ce49..1c00dd35e 100644 --- a/filesystem/system_other.go +++ b/filesystem/system_other.go @@ -85,6 +85,7 @@ func (m *systemOtherImage) GenerateAndroidBuildActions(ctx android.ModuleContext output := android.PathForModuleOut(ctx, "system_other.img") stagingDir := android.PathForModuleOut(ctx, "staging_dir") + stagingDirTimestamp := android.PathForModuleOut(ctx, "staging_dir.timestamp") builder := android.NewRuleBuilder(pctx, ctx) builder.Command().Textf("rm -rf %s && mkdir -p %s", stagingDir, stagingDir) @@ -113,6 +114,8 @@ func (m *systemOtherImage) GenerateAndroidBuildActions(ctx android.ModuleContext if len(m.properties.Preinstall_dexpreopt_files_from) > 0 { builder.Command().Textf("touch %s", filepath.Join(stagingDir.String(), "system-other-odex-marker")) } + builder.Command().Textf("touch").Output(stagingDirTimestamp) + builder.Build("assemble_filesystem_staging_dir", "Assemble filesystem staging dir") // Most of the time, if build_image were to call a host tool, it accepts the path to the // host tool in a field in the prop file. However, it doesn't have that option for fec, which @@ -120,6 +123,7 @@ func (m *systemOtherImage) GenerateAndroidBuildActions(ctx android.ModuleContext fec := ctx.Config().HostToolPath(ctx, "fec") pathToolDirs := []string{filepath.Dir(fec.String())} + builder = android.NewRuleBuilder(pctx, ctx) builder.Command(). Textf("PATH=%s:$PATH", strings.Join(pathToolDirs, ":")). BuiltTool("build_image"). @@ -127,11 +131,44 @@ func (m *systemOtherImage) GenerateAndroidBuildActions(ctx android.ModuleContext Input(systemInfo.BuildImagePropFile). Implicits(systemInfo.BuildImagePropFileDeps). Implicit(fec). + Implicit(stagingDirTimestamp). Output(output). Text(stagingDir.String()) builder.Build("build_system_other", "build system other") + // Create a hermetic system_other.img with pinned timestamps + builder = android.NewRuleBuilder(pctx, ctx) + outputHermetic := android.PathForModuleOut(ctx, "for_target_files", "system_other.img") + outputHermeticPropFile := m.propFileForHermeticImg(ctx, builder, systemInfo.BuildImagePropFile) + builder.Command(). + Textf("PATH=%s:$PATH", strings.Join(pathToolDirs, ":")). + BuiltTool("build_image"). + Text(stagingDir.String()). // input directory + Input(outputHermeticPropFile). + Implicits(systemInfo.BuildImagePropFileDeps). + Implicit(fec). + Implicit(stagingDirTimestamp). + Output(outputHermetic). + Text(stagingDir.String()) + + builder.Build("build_system_other_hermetic", "build system other") + + fsInfo := FilesystemInfo{ + Output: output, + OutputHermetic: outputHermetic, + RootDir: stagingDir, + } + + android.SetProvider(ctx, FilesystemProvider, fsInfo) + ctx.SetOutputFiles(android.Paths{output}, "") ctx.CheckbuildFile(output) } + +func (f *systemOtherImage) propFileForHermeticImg(ctx android.ModuleContext, builder *android.RuleBuilder, inputPropFile android.Path) android.Path { + propFilePinnedTimestamp := android.PathForModuleOut(ctx, "for_target_files", "prop") + builder.Command().Textf("cat").Input(inputPropFile).Flag(">").Output(propFilePinnedTimestamp). + Textf(" && echo use_fixed_timestamp=true >> %s", propFilePinnedTimestamp) + return propFilePinnedTimestamp +} diff --git a/fsgen/filesystem_creator.go b/fsgen/filesystem_creator.go index 2c2da1772..9217e1c33 100644 --- a/fsgen/filesystem_creator.go +++ b/fsgen/filesystem_creator.go @@ -381,8 +381,9 @@ func (f *filesystemCreator) createDeviceModule( partitionProps.Vbmeta_partitions = vbmetaPartitions deviceProps := &filesystem.DeviceProperties{ - Main_device: proptools.BoolPtr(true), - Ab_ota_updater: proptools.BoolPtr(ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.AbOtaUpdater), + Main_device: proptools.BoolPtr(true), + Ab_ota_updater: proptools.BoolPtr(ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.AbOtaUpdater), + Ab_ota_partitions: ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.AbOtaPartitions, } if bootloader, ok := f.createBootloaderFilegroup(ctx); ok { deviceProps.Bootloader = proptools.StringPtr(":" + bootloader) diff --git a/rust/androidmk.go b/rust/androidmk.go index 8de6b6004..98946844d 100644 --- a/rust/androidmk.go +++ b/rust/androidmk.go @@ -92,9 +92,6 @@ func (mod *Module) AndroidMkEntries() []android.AndroidMkEntries { func (binary *binaryDecorator) AndroidMk(ctx AndroidMkContext, ret *android.AndroidMkEntries) { ctx.SubAndroidMk(ret, binary.baseCompiler) - if binary.distFile.Valid() { - ret.DistFiles = android.MakeDefaultDistFiles(binary.distFile.Path()) - } ret.Class = "EXECUTABLES" } @@ -143,9 +140,6 @@ func (library *libraryDecorator) AndroidMk(ctx AndroidMkContext, ret *android.An } else if library.shared() { ret.Class = "SHARED_LIBRARIES" } - if library.distFile.Valid() { - ret.DistFiles = android.MakeDefaultDistFiles(library.distFile.Path()) - } ret.ExtraEntries = append(ret.ExtraEntries, func(ctx android.AndroidMkExtraEntriesContext, entries *android.AndroidMkEntries) { if library.tocFile.Valid() { @@ -158,10 +152,6 @@ func (procMacro *procMacroDecorator) AndroidMk(ctx AndroidMkContext, ret *androi ctx.SubAndroidMk(ret, procMacro.baseCompiler) ret.Class = "PROC_MACRO_LIBRARIES" - if procMacro.distFile.Valid() { - ret.DistFiles = android.MakeDefaultDistFiles(procMacro.distFile.Path()) - } - } func (sourceProvider *BaseSourceProvider) AndroidMk(ctx AndroidMkContext, ret *android.AndroidMkEntries) { diff --git a/rust/compiler.go b/rust/compiler.go index f186ef38f..c3bc937da 100644 --- a/rust/compiler.go +++ b/rust/compiler.go @@ -257,8 +257,6 @@ type baseCompiler struct { location installLocation sanitize *sanitize - distFile android.OptionalPath - installDeps android.InstallPaths // unstripped output file. |