summaryrefslogtreecommitdiff
path: root/scripts/manifest_check_test.py
diff options
context:
space:
mode:
author Colin Cross <ccross@android.com> 2024-09-11 11:34:35 -0700
committer Colin Cross <ccross@android.com> 2024-09-11 14:22:34 -0700
commit6cb462b38c07507e0fc1518762ac2b579a3ede8c (patch)
treebb742f2f529576715a7de9e1f64d2b8add5cb6cb /scripts/manifest_check_test.py
parentaa8ceca851efaf057df5472dc95fe8eb4b0496e8 (diff)
Fix manifest_fixer.py warnings
Fix a few warnings showing up in manifest_*.py Test: manifest_fixer_test.py Test: manifest_check_test.py Flag: EXEMPT refactor Change-Id: I144100d6d4aa7f5dff7eec79b4bd2d9d5da52153
Diffstat (limited to 'scripts/manifest_check_test.py')
-rwxr-xr-xscripts/manifest_check_test.py16
1 files changed, 8 insertions, 8 deletions
diff --git a/scripts/manifest_check_test.py b/scripts/manifest_check_test.py
index 8003b3e19..7aaf8a966 100755
--- a/scripts/manifest_check_test.py
+++ b/scripts/manifest_check_test.py
@@ -44,8 +44,8 @@ def required_apk(value):
class EnforceUsesLibrariesTest(unittest.TestCase):
"""Unit tests for add_extract_native_libs function."""
- def run_test(self, xml, apk, uses_libraries=[], optional_uses_libraries=[],
- missing_optional_uses_libraries=[]): #pylint: disable=dangerous-default-value
+ def run_test(self, xml, apk, uses_libraries=(), optional_uses_libraries=(),
+ missing_optional_uses_libraries=()): #pylint: disable=dangerous-default-value
doc = minidom.parseString(xml)
try:
relax = False
@@ -114,14 +114,14 @@ class EnforceUsesLibrariesTest(unittest.TestCase):
self.assertFalse(matches)
def test_missing_uses_library(self):
- xml = self.xml_tmpl % ('')
- apk = self.apk_tmpl % ('')
+ xml = self.xml_tmpl % ''
+ apk = self.apk_tmpl % ''
matches = self.run_test(xml, apk, uses_libraries=['foo'])
self.assertFalse(matches)
def test_missing_optional_uses_library(self):
- xml = self.xml_tmpl % ('')
- apk = self.apk_tmpl % ('')
+ xml = self.xml_tmpl % ''
+ apk = self.apk_tmpl % ''
matches = self.run_test(xml, apk, optional_uses_libraries=['foo'])
self.assertFalse(matches)
@@ -256,12 +256,12 @@ class ExtractTargetSdkVersionTest(unittest.TestCase):
"targetSdkVersion:'%s'\n"
"uses-permission: name='android.permission.ACCESS_NETWORK_STATE'\n")
- def test_targert_sdk_version_28(self):
+ def test_target_sdk_version_28(self):
xml = self.xml_tmpl % '28'
apk = self.apk_tmpl % '28'
self.run_test(xml, apk, '28')
- def test_targert_sdk_version_29(self):
+ def test_target_sdk_version_29(self):
xml = self.xml_tmpl % '29'
apk = self.apk_tmpl % '29'
self.run_test(xml, apk, '29')