diff options
author | 2023-01-23 10:14:58 -0800 | |
---|---|---|
committer | 2023-01-25 10:40:59 -0800 | |
commit | 4d247e6f21004d3998bf32d46c22111a380b81af (patch) | |
tree | 8b92c1e1f8b1df6e40c5831f40145f482e70d7b8 /python/androidmk.go | |
parent | 6cf5e0d9cb89b909b5087d4057e6f09e4d093f85 (diff) |
Refactor python rules
The goal of this cl is to simplify the python rules,
mostly by removing the "decorator" pattern that they
currently use, and instead making separate module
types for libraries, binaries, and tests that inherit
from each other.
Bug: 259718110
Test: Verified ninja files are unchanged (they only change in the list of soong sources because I added/deleted files)
Change-Id: I1e836e2cc4782c7818f91db7df7895de3b8db7ca
Diffstat (limited to 'python/androidmk.go')
-rw-r--r-- | python/androidmk.go | 90 |
1 files changed, 0 insertions, 90 deletions
diff --git a/python/androidmk.go b/python/androidmk.go deleted file mode 100644 index 7dc471397..000000000 --- a/python/androidmk.go +++ /dev/null @@ -1,90 +0,0 @@ -// Copyright 2017 Google Inc. All rights reserved. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package python - -import ( - "path/filepath" - "strings" - - "android/soong/android" -) - -type subAndroidMkProvider interface { - AndroidMk(*Module, *android.AndroidMkEntries) -} - -func (p *Module) subAndroidMk(entries *android.AndroidMkEntries, obj interface{}) { - if p.subAndroidMkOnce == nil { - p.subAndroidMkOnce = make(map[subAndroidMkProvider]bool) - } - if androidmk, ok := obj.(subAndroidMkProvider); ok { - if !p.subAndroidMkOnce[androidmk] { - p.subAndroidMkOnce[androidmk] = true - androidmk.AndroidMk(p, entries) - } - } -} - -func (p *Module) AndroidMkEntries() []android.AndroidMkEntries { - entries := android.AndroidMkEntries{OutputFile: p.installSource} - - p.subAndroidMk(&entries, p.installer) - - return []android.AndroidMkEntries{entries} -} - -func (p *binaryDecorator) AndroidMk(base *Module, entries *android.AndroidMkEntries) { - entries.Class = "EXECUTABLES" - - entries.ExtraEntries = append(entries.ExtraEntries, - func(ctx android.AndroidMkExtraEntriesContext, entries *android.AndroidMkEntries) { - entries.AddCompatibilityTestSuites(p.binaryProperties.Test_suites...) - }) - base.subAndroidMk(entries, p.pythonInstaller) -} - -func (p *testDecorator) AndroidMk(base *Module, entries *android.AndroidMkEntries) { - entries.Class = "NATIVE_TESTS" - - entries.ExtraEntries = append(entries.ExtraEntries, - func(ctx android.AndroidMkExtraEntriesContext, entries *android.AndroidMkEntries) { - entries.AddCompatibilityTestSuites(p.binaryDecorator.binaryProperties.Test_suites...) - if p.testConfig != nil { - entries.SetString("LOCAL_FULL_TEST_CONFIG", p.testConfig.String()) - } - - entries.SetBoolIfTrue("LOCAL_DISABLE_AUTO_GENERATE_TEST_CONFIG", !BoolDefault(p.binaryProperties.Auto_gen_config, true)) - - entries.AddStrings("LOCAL_TEST_DATA", android.AndroidMkDataPaths(p.data)...) - - p.testProperties.Test_options.SetAndroidMkEntries(entries) - }) - base.subAndroidMk(entries, p.binaryDecorator.pythonInstaller) -} - -func (installer *pythonInstaller) AndroidMk(base *Module, entries *android.AndroidMkEntries) { - entries.Required = append(entries.Required, "libc++") - entries.ExtraEntries = append(entries.ExtraEntries, - func(ctx android.AndroidMkExtraEntriesContext, entries *android.AndroidMkEntries) { - path, file := filepath.Split(installer.path.String()) - stem := strings.TrimSuffix(file, filepath.Ext(file)) - - entries.SetString("LOCAL_MODULE_SUFFIX", filepath.Ext(file)) - entries.SetString("LOCAL_MODULE_PATH", path) - entries.SetString("LOCAL_MODULE_STEM", stem) - entries.AddStrings("LOCAL_SHARED_LIBRARIES", installer.androidMkSharedLibs...) - entries.SetBool("LOCAL_CHECK_ELF_FILES", false) - }) -} |