summaryrefslogtreecommitdiff
path: root/phony
diff options
context:
space:
mode:
author Nelson Li <nelsonli@google.com> 2023-12-20 02:37:52 +0000
committer Nelson Li <nelsonli@google.com> 2024-01-03 02:01:36 +0000
commitf3c706868a6252ba50f7433e456935a3b25bc531 (patch)
tree90430131787f5c87f2f70aba048becc16e42e349 /phony
parentad579a8c713215e60ac9f560bd32684f604cda7b (diff)
Enable Soong to correctly add dependencies to .PHONY targets.
Previously, Soong's phony simply added "required" or "host_required" to LOCAL_REQUIRED_MODULES and `include BUILD_PHONY_PACKAGE` without correctly adding them to the dependency list. This change add a new `phony_rule` module type to Soong that acts like `.PHONY` instead of `BUILD_PHONY_PACKAGE` Bug: 316838256 Bug: 309730110 Test: 1. Use `phony_rule` and adding "phony_deps: [dep_modules]" to Android.bp. 2. make target and check the dep_modules be built. Change-Id: I3e9e9ac26ecc456668f1b6baf5c08f9c9139b3b2
Diffstat (limited to 'phony')
-rw-r--r--phony/phony.go38
1 files changed, 38 insertions, 0 deletions
diff --git a/phony/phony.go b/phony/phony.go
index a8b651aa8..bb4878899 100644
--- a/phony/phony.go
+++ b/phony/phony.go
@@ -24,6 +24,7 @@ import (
func init() {
android.RegisterModuleType("phony", PhonyFactory)
+ android.RegisterModuleType("phony_rule", PhonyRuleFactory)
}
type phony struct {
@@ -71,3 +72,40 @@ func (p *phony) AndroidMk() android.AndroidMkData {
},
}
}
+
+type PhonyRule struct {
+ android.ModuleBase
+
+ properties PhonyProperties
+}
+
+type PhonyProperties struct {
+ // The Phony_deps is the set of all dependencies for this target,
+ // and it can function similarly to .PHONY in a makefile.
+ // Additionally, dependencies within it can even include genrule.
+ Phony_deps []string
+}
+
+// The phony_rule provides functionality similar to the .PHONY in a makefile.
+// It can create a phony target and include relevant dependencies associated with it.
+func PhonyRuleFactory() android.Module {
+ module := &PhonyRule{}
+ android.InitAndroidModule(module)
+ module.AddProperties(&module.properties)
+ return module
+}
+
+func (p *PhonyRule) GenerateAndroidBuildActions(ctx android.ModuleContext) {
+}
+
+func (p *PhonyRule) AndroidMk() android.AndroidMkData {
+ return android.AndroidMkData{
+ Custom: func(w io.Writer, name, prefix, moduleDir string, data android.AndroidMkData) {
+ if len(p.properties.Phony_deps) > 0 {
+ depModulesStr := strings.Join(p.properties.Phony_deps, " ")
+ fmt.Fprintln(w, ".PHONY:", name)
+ fmt.Fprintln(w, name, ":", depModulesStr)
+ }
+ },
+ }
+}