summaryrefslogtreecommitdiff
path: root/java/robolectric.go
diff options
context:
space:
mode:
author Kevin Liu <congxiliu@google.com> 2024-05-02 16:40:08 +0000
committer Kevin Liu <congxiliu@google.com> 2024-06-14 21:13:17 +0000
commitba791b18fbbfe421db859272dc19cbde55497632 (patch)
treeb95592215c13e1bec505f952af87b01cbbce94d8 /java/robolectric.go
parenta551b011d0f25e5d41ec63922e69f8b86539920e (diff)
Set strict_mode to true
The default strict_mode is now set to true. We are encourage teams to write tests in strict_mode to make tests Bivalent (able to run on device and devicelessly) When opting out from strict_mode, "robolectric_strict_mode_res" should be included in lib for whitelisting purpose. Test: atest MyRoboTests Bug: 334089788 Change-Id: I3098e2c1ef1b5fd2ee1a98950db5e4f2e8d87d1e
Diffstat (limited to 'java/robolectric.go')
-rw-r--r--java/robolectric.go7
1 files changed, 5 insertions, 2 deletions
diff --git a/java/robolectric.go b/java/robolectric.go
index 18386c90c..cb22fa0db 100644
--- a/java/robolectric.go
+++ b/java/robolectric.go
@@ -116,7 +116,7 @@ func (r *robolectricTest) DepsMutator(ctx android.BottomUpMutatorContext) {
if v := String(r.robolectricProperties.Robolectric_prebuilt_version); v != "" {
ctx.AddVariationDependencies(nil, libTag, fmt.Sprintf(robolectricPrebuiltLibPattern, v))
- } else if !proptools.Bool(r.robolectricProperties.Strict_mode) {
+ } else if !proptools.BoolDefault(r.robolectricProperties.Strict_mode, true) {
if proptools.Bool(r.robolectricProperties.Upstream) {
ctx.AddVariationDependencies(nil, libTag, robolectricCurrentLib+"_upstream")
} else {
@@ -124,8 +124,11 @@ func (r *robolectricTest) DepsMutator(ctx android.BottomUpMutatorContext) {
}
}
- if proptools.Bool(r.robolectricProperties.Strict_mode) {
+ if proptools.BoolDefault(r.robolectricProperties.Strict_mode, true) {
ctx.AddVariationDependencies(nil, roboRuntimeOnlyTag, robolectricCurrentLib+"_upstream")
+ } else {
+ // opting out from strict mode, robolectric_non_strict_mode_permission lib should be added
+ ctx.AddVariationDependencies(nil, libTag, "robolectric_non_strict_mode_permission")
}
ctx.AddVariationDependencies(nil, libTag, robolectricDefaultLibs...)