summaryrefslogtreecommitdiff
path: root/java/plugin.go
diff options
context:
space:
mode:
author Sam Delmerico <delmerico@google.com> 2022-02-25 21:34:51 +0000
committer Sam Delmerico <delmerico@google.com> 2022-03-30 18:58:38 +0000
commitc0161436020df70a66885d1d5e98c5bfa42890ce (patch)
tree3830ab4dda620e19c4e4ee143c18f62677e4a664 /java/plugin.go
parentad40fffa644ada1c0113b9de18bdaa2bb1e1490f (diff)
emulate java_library static_deps with Bazel exports
In Soong, java_library can specify static_deps which are dependencies that get aggregated into the final jar (akin to static linking). This is useful because it allows dependencies higher up in the chain to compile against the APIs exported by transitive dependencies. Bazel does not support this functionality directly, but it can be emulated via the exports attribute which makes any targets listed in the attribute public to targets further up the chain. Bug: 217236083 Bug: 219908977 Test: b build //external/error_prone:error_prone_core Test: b build //external/bouncycastle:bouncycastle-host Test: b build --platforms=//build/bazel/platforms:linux_x86 //prebuilts/sdk/tools/jetifier/jetifier-standalone:jetifier Change-Id: I2867e3f816de720a6f4bd9ff7a847d1b0c2da2d6
Diffstat (limited to 'java/plugin.go')
-rw-r--r--java/plugin.go29
1 files changed, 17 insertions, 12 deletions
diff --git a/java/plugin.go b/java/plugin.go
index 4b174b930..123dbd4c0 100644
--- a/java/plugin.go
+++ b/java/plugin.go
@@ -58,27 +58,32 @@ type PluginProperties struct {
}
type pluginAttributes struct {
- *javaLibraryAttributes
- Processor_class *string
- Target_compatible_with bazel.LabelListAttribute
+ *javaCommonAttributes
+ Deps bazel.LabelListAttribute
+ Processor_class *string
}
// ConvertWithBp2build is used to convert android_app to Bazel.
func (p *Plugin) ConvertWithBp2build(ctx android.TopDownMutatorContext) {
- libAttrs := p.convertLibraryAttrsBp2Build(ctx)
- attrs := &pluginAttributes{
- libAttrs,
- nil,
- bazel.LabelListAttribute{},
- }
+ pluginName := p.Name()
+ commonAttrs, depLabels := p.convertLibraryAttrsBp2Build(ctx)
+
+ deps := depLabels.Deps
+ deps.Append(depLabels.StaticDeps)
+ var processorClass *string
if p.pluginProperties.Processor_class != nil {
- attrs.Processor_class = p.pluginProperties.Processor_class
+ processorClass = p.pluginProperties.Processor_class
+ }
+
+ attrs := &pluginAttributes{
+ javaCommonAttributes: commonAttrs,
+ Deps: deps,
+ Processor_class: processorClass,
}
props := bazel.BazelTargetModuleProperties{
Rule_class: "java_plugin",
}
-
- ctx.CreateBazelTargetModule(props, android.CommonAttributes{Name: p.Name()}, attrs)
+ ctx.CreateBazelTargetModule(props, android.CommonAttributes{Name: pluginName}, attrs)
}