diff options
author | 2021-04-12 14:15:22 +0100 | |
---|---|---|
committer | 2021-04-13 00:23:55 +0100 | |
commit | 6a766453fd32697f612674bf675a17866e896256 (patch) | |
tree | 75455a2f95dcfaa874a0913c42ac490af30f7c00 /java/platform_bootclasspath.go | |
parent | 8e1c08cda662b0848e8407eb9d260598b82067bc (diff) |
Export monolithic hidden API files from platform_bootclasspath
Makes the monolithic hidden API files accessible from the
platform_bootclasspath so they can be output to the dist build target
and used by other modules, e.g. by doing something like this:
java_resources: [
":platform-bootclasspath{hiddenapi-flags.csv}",
],
It makes the paths relative to the out/soong/hiddenapi directory rather
than the out/soong directory to make them easier to use in the
java_resources property without changing the structure of the APK.
Without that attempting to use them in a java_resources property will
result in them being copied to a hiddenapi/ within the APK instead of
being used at the top level as existing APKs like
CtsHiddenApiBlocklistTestApiTestCases expect.
Bug: 177892522
Test: m nothing
Change-Id: I829412fc7d25411e0c2e0713d0d219a18f4af2ee
Diffstat (limited to 'java/platform_bootclasspath.go')
-rw-r--r-- | java/platform_bootclasspath.go | 50 |
1 files changed, 50 insertions, 0 deletions
diff --git a/java/platform_bootclasspath.go b/java/platform_bootclasspath.go index e292d8057..86ab70865 100644 --- a/java/platform_bootclasspath.go +++ b/java/platform_bootclasspath.go @@ -15,6 +15,8 @@ package java import ( + "fmt" + "android/soong/android" "android/soong/dexpreopt" "github.com/google/blueprint" @@ -69,6 +71,15 @@ type platformBootclasspathModule struct { // // Currently only for testing. fragments []android.Module + + // Path to the monolithic hiddenapi-flags.csv file. + hiddenAPIFlagsCSV android.Path + + // Path to the monolithic hiddenapi-index.csv file. + hiddenAPIIndexCSV android.Path + + // Path to the monolithic hiddenapi-unsupported.csv file. + hiddenAPIMetadataCSV android.Path } // ApexVariantReference specifies a particular apex variant of a module. @@ -98,6 +109,34 @@ func platformBootclasspathFactory() android.Module { return m } +var _ android.OutputFileProducer = (*platformBootclasspathModule)(nil) + +// A minimal AndroidMkEntries is needed in order to support the dists property. +func (b *platformBootclasspathModule) AndroidMkEntries() []android.AndroidMkEntries { + return []android.AndroidMkEntries{ + { + Class: "FAKE", + // Need at least one output file in order for this to take effect. + OutputFile: android.OptionalPathForPath(b.hiddenAPIFlagsCSV), + Include: "$(BUILD_PHONY_PACKAGE)", + }, + } +} + +// Make the hidden API files available from the platform-bootclasspath module. +func (b *platformBootclasspathModule) OutputFiles(tag string) (android.Paths, error) { + switch tag { + case "hiddenapi-flags.csv": + return android.Paths{b.hiddenAPIFlagsCSV}, nil + case "hiddenapi-index.csv": + return android.Paths{b.hiddenAPIIndexCSV}, nil + case "hiddenapi-metadata.csv": + return android.Paths{b.hiddenAPIMetadataCSV}, nil + } + + return nil, fmt.Errorf("unknown tag %s", tag) +} + func (b *platformBootclasspathModule) DepsMutator(ctx android.BottomUpMutatorContext) { if SkipDexpreoptBootJars(ctx) { return @@ -222,6 +261,17 @@ func (b *platformBootclasspathModule) getImageConfig(ctx android.EarlyModuleCont // generateHiddenAPIBuildActions generates all the hidden API related build rules. func (b *platformBootclasspathModule) generateHiddenAPIBuildActions(ctx android.ModuleContext, modules []android.Module) { + // Save the paths to the monolithic files for retrieval via OutputFiles() + // Make the paths relative to the out/soong/hiddenapi directory instead of to the out/soong/ + // directory. This ensures that if they are used as java_resources they do not end up in a + // hiddenapi directory in the resulting APK. + relToHiddenapiDir := func(path android.OutputPath) android.Path { + return path + } + b.hiddenAPIFlagsCSV = relToHiddenapiDir(hiddenAPISingletonPaths(ctx).flags) + b.hiddenAPIIndexCSV = relToHiddenapiDir(hiddenAPISingletonPaths(ctx).index) + b.hiddenAPIMetadataCSV = relToHiddenapiDir(hiddenAPISingletonPaths(ctx).metadata) + moduleSpecificFlagsPaths := android.Paths{} for _, module := range modules { if h, ok := module.(hiddenAPIIntf); ok { |