diff options
| author | 2024-01-30 01:30:53 +0000 | |
|---|---|---|
| committer | 2024-01-30 01:30:53 +0000 | |
| commit | c6db30b81ab2141dbbe984461e43abda00f9462a (patch) | |
| tree | bfc91d54f021a5d3a6b6968ec26c3af9a4a687ec /java/lint.go | |
| parent | 19631d51939871672342700fbca724d6eb27df47 (diff) | |
| parent | 5fd64b9c708553375ff2df3a7c85095cf3085cd5 (diff) | |
Merge "Prevent disabling checks via flags property" into main am: 59739666e6 am: 5fd64b9c70
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2933578
Change-Id: I274a32a4cbadb85fadb192f7e60049506791e1e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
Diffstat (limited to 'java/lint.go')
| -rw-r--r-- | java/lint.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/java/lint.go b/java/lint.go index bd6c1bae6..c79f6e7bb 100644 --- a/java/lint.go +++ b/java/lint.go @@ -364,6 +364,12 @@ func (l *linter) lint(ctx android.ModuleContext) { return } + for _, flag := range l.properties.Lint.Flags { + if strings.Contains(flag, "--disable") || strings.Contains(flag, "--enable") || strings.Contains(flag, "--check") { + ctx.PropertyErrorf("lint.flags", "Don't use --disable, --enable, or --check in the flags field, instead use the dedicated disabled_checks, warning_checks, error_checks, or fatal_checks fields") + } + } + if l.minSdkVersion.CompareTo(l.compileSdkVersion) == -1 { l.extraMainlineLintErrors = append(l.extraMainlineLintErrors, updatabilityChecks...) // Skip lint warning checks for NewApi warnings for libcore where they come from source |