diff options
| author | 2024-01-30 00:47:45 +0000 | |
|---|---|---|
| committer | 2024-01-30 00:47:45 +0000 | |
| commit | 5fd64b9c708553375ff2df3a7c85095cf3085cd5 (patch) | |
| tree | 064d892bb907eed2828440feafa947c723e5f32a /java/lint.go | |
| parent | e0e733571fe78a8815550fb452fc06c5490ff96e (diff) | |
| parent | 59739666e62b523b81c3c891fbc02cc7b6a7b37c (diff) | |
Merge "Prevent disabling checks via flags property" into main am: 59739666e6
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2933578
Change-Id: Ie49923115baf0fb0ffa8599621c0cad80398a9a9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
Diffstat (limited to 'java/lint.go')
| -rw-r--r-- | java/lint.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/java/lint.go b/java/lint.go index c3d723b40..31e7f353d 100644 --- a/java/lint.go +++ b/java/lint.go @@ -370,6 +370,12 @@ func (l *linter) lint(ctx android.ModuleContext) { return } + for _, flag := range l.properties.Lint.Flags { + if strings.Contains(flag, "--disable") || strings.Contains(flag, "--enable") || strings.Contains(flag, "--check") { + ctx.PropertyErrorf("lint.flags", "Don't use --disable, --enable, or --check in the flags field, instead use the dedicated disabled_checks, warning_checks, error_checks, or fatal_checks fields") + } + } + if l.minSdkVersion.CompareTo(l.compileSdkVersion) == -1 { l.extraMainlineLintErrors = append(l.extraMainlineLintErrors, updatabilityChecks...) // Skip lint warning checks for NewApi warnings for libcore where they come from source |