diff options
| author | 2024-01-29 13:49:14 -0800 | |
|---|---|---|
| committer | 2024-01-29 14:48:23 -0800 | |
| commit | 5d0aaf42dbc6bc3e492c3dd19ff66458baccb587 (patch) | |
| tree | b01a10f4bf34fec040ab4f4c8f498fb7eacde335 /java/lint.go | |
| parent | 78885cae81eb54053953fbcfb9af8c1715265e06 (diff) | |
Prevent disabling checks via flags property
strict_updatability_linting currently only checks that updatability
checks aren't disabled via disabled_checks / warning_checks, you could
get around it using the `flags` property. Only allow controlling checks
via the *_checks properties.
Bug: 322802379
Test: m nothing --no-skip-soong-tests
Change-Id: Ia311622e1409f9cc201ab55f8749f2d13fccf551
Diffstat (limited to 'java/lint.go')
| -rw-r--r-- | java/lint.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/java/lint.go b/java/lint.go index c3d723b40..31e7f353d 100644 --- a/java/lint.go +++ b/java/lint.go @@ -370,6 +370,12 @@ func (l *linter) lint(ctx android.ModuleContext) { return } + for _, flag := range l.properties.Lint.Flags { + if strings.Contains(flag, "--disable") || strings.Contains(flag, "--enable") || strings.Contains(flag, "--check") { + ctx.PropertyErrorf("lint.flags", "Don't use --disable, --enable, or --check in the flags field, instead use the dedicated disabled_checks, warning_checks, error_checks, or fatal_checks fields") + } + } + if l.minSdkVersion.CompareTo(l.compileSdkVersion) == -1 { l.extraMainlineLintErrors = append(l.extraMainlineLintErrors, updatabilityChecks...) // Skip lint warning checks for NewApi warnings for libcore where they come from source |