summaryrefslogtreecommitdiff
path: root/java/lint.go
diff options
context:
space:
mode:
author Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com> 2024-01-30 00:14:17 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2024-01-30 00:14:17 +0000
commit59739666e62b523b81c3c891fbc02cc7b6a7b37c (patch)
tree064d892bb907eed2828440feafa947c723e5f32a /java/lint.go
parenta8a5f64222ccaf2fa805c1d87c3985ac640a352f (diff)
parent5d0aaf42dbc6bc3e492c3dd19ff66458baccb587 (diff)
Merge "Prevent disabling checks via flags property" into main
Diffstat (limited to 'java/lint.go')
-rw-r--r--java/lint.go6
1 files changed, 6 insertions, 0 deletions
diff --git a/java/lint.go b/java/lint.go
index c3d723b40..31e7f353d 100644
--- a/java/lint.go
+++ b/java/lint.go
@@ -370,6 +370,12 @@ func (l *linter) lint(ctx android.ModuleContext) {
return
}
+ for _, flag := range l.properties.Lint.Flags {
+ if strings.Contains(flag, "--disable") || strings.Contains(flag, "--enable") || strings.Contains(flag, "--check") {
+ ctx.PropertyErrorf("lint.flags", "Don't use --disable, --enable, or --check in the flags field, instead use the dedicated disabled_checks, warning_checks, error_checks, or fatal_checks fields")
+ }
+ }
+
if l.minSdkVersion.CompareTo(l.compileSdkVersion) == -1 {
l.extraMainlineLintErrors = append(l.extraMainlineLintErrors, updatabilityChecks...)
// Skip lint warning checks for NewApi warnings for libcore where they come from source